From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH v2 06/35] acpi: mc146818rtc: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml
Date: Wed, 8 Jun 2022 09:53:11 -0400 [thread overview]
Message-ID: <20220608135340.3304695-7-imammedo@redhat.com> (raw)
In-Reply-To: <20220608135340.3304695-1-imammedo@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/rtc/mc146818rtc.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c
index f235c2ddbe..ef9765bb8f 100644
--- a/hw/rtc/mc146818rtc.c
+++ b/hw/rtc/mc146818rtc.c
@@ -26,7 +26,7 @@
#include "qemu/cutils.h"
#include "qemu/module.h"
#include "qemu/bcd.h"
-#include "hw/acpi/aml-build.h"
+#include "hw/acpi/acpi_aml_interface.h"
#include "hw/irq.h"
#include "hw/qdev-properties.h"
#include "hw/qdev-properties-system.h"
@@ -1017,9 +1017,9 @@ static void rtc_reset_hold(Object *obj)
qemu_irq_lower(s->irq);
}
-static void rtc_build_aml(ISADevice *isadev, Aml *scope)
+static void rtc_build_aml(AcpiDevAmlIf *adev, Aml *scope)
{
- RTCState *s = MC146818_RTC(isadev);
+ RTCState *s = MC146818_RTC(adev);
Aml *dev;
Aml *crs;
@@ -1043,13 +1043,13 @@ static void rtc_class_initfn(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
ResettableClass *rc = RESETTABLE_CLASS(klass);
- ISADeviceClass *isa = ISA_DEVICE_CLASS(klass);
+ AcpiDevAmlIfClass *adevc = ACPI_DEV_AML_IF_CLASS(klass);
dc->realize = rtc_realizefn;
dc->vmsd = &vmstate_rtc;
rc->phases.enter = rtc_reset_enter;
rc->phases.hold = rtc_reset_hold;
- isa->build_aml = rtc_build_aml;
+ adevc->build_dev_aml = rtc_build_aml;
device_class_set_props(dc, mc146818rtc_properties);
set_bit(DEVICE_CATEGORY_MISC, dc->categories);
}
@@ -1059,6 +1059,10 @@ static const TypeInfo mc146818rtc_info = {
.parent = TYPE_ISA_DEVICE,
.instance_size = sizeof(RTCState),
.class_init = rtc_class_initfn,
+ .interfaces = (InterfaceInfo[]) {
+ { TYPE_ACPI_DEV_AML_IF },
+ { },
+ },
};
static void mc146818rtc_register_types(void)
--
2.31.1
next prev parent reply other threads:[~2022-06-08 14:24 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 13:53 [PATCH v2 00/35] pc/q35: refactor ISA and SMBUS AML generation Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 01/35] acpi: add interface to build device specific AML Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 02/35] acpi: make isa_build_aml() support AcpiDevAmlIf interface Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 03/35] acpi: fdc-isa: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 04/35] acpi: parallel port: " Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 05/35] acpi: serial-is: " Igor Mammedov
2022-06-08 13:53 ` Igor Mammedov [this message]
2022-06-08 13:53 ` [PATCH v2 07/35] acpi: pckbd: " Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 08/35] isa-bus: drop no longer used ISADeviceClass::build_aml Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 09/35] tests: acpi: add and whitelist DSDT.ipmismbus expected blob Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 10/35] tests: acpi: q35: add test for smbus-ipmi device Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 11/35] tests: acpi: update expected blob DSDT.ipmismbus Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 12/35] tests: acpi: whitelist DSDT.ipmismbus expected blob Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 13/35] ipmi: acpi: use relative path to resource source Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 14/35] tests: acpi: update expected DSDT.ipmismbus blob Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 15/35] acpi: ich9-smb: add support for AcpiDevAmlIf interface Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 16/35] acpi: ipmi: use AcpiDevAmlIf interface to build IPMI device descriptors Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 17/35] q35: acpi: drop not needed PCMachineClass::do_not_add_smb_acpi Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 18/35] tests: acpi: white-list to be re-factored pc/q35 DSDT Igor Mammedov
2022-06-09 11:48 ` [PATCH v3 " Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 19/35] acpi: pc: isa bridge: use AcpiDevAmlIf interface to build ISA device descriptors Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 20/35] acpi: q35: " Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 21/35] tests: acpi: update expected blobs Igor Mammedov
2022-06-09 11:51 ` [PATCH v3 " Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 22/35] tests: acpi: add and white-list DSDT.applesmc expected blob Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 23/35] tests: acpi: add applesmc testcase Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 24/35] acpi: applesmc: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 25/35] tests: acpi: update expected blobs Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 26/35] tests: acpi: white-lists expected DSDT.pvpanic-isa blob Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 27/35] tests: acpi: add pvpanic-isa: testcase Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 28/35] acpi: pvpanic-isa: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 29/35] tests: acpi: update expected DSDT.pvpanic-isa blob Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 30/35] tests: acpi: white-list DSDT.tis.tpm2/DSDT.tis.tpm12 expected blobs Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 31/35] acpi: pc/q35: tpm-tis: fix TPM device scope Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 32/35] acpi: pc/q35: remove not needed 'if' condition on pci bus Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 33/35] acpi: tpm-tis: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 34/35] tests: acpi: update expected DSDT.tis.tpm2/DSDT.tis.tpm12 blobs Igor Mammedov
2022-06-08 13:53 ` [PATCH v2 35/35] x86: acpi-build: do not include hw/isa/isa.h directly Igor Mammedov
2022-06-09 9:30 ` [PATCH v2 00/35] pc/q35: refactor ISA and SMBUS AML generation Igor Mammedov
2022-06-09 11:55 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608135340.3304695-7-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).