From: Gerd Hoffmann <kraxel@redhat.com>
To: "Hongren (Zenithal) Zheng" <i@zenithal.me>
Cc: qemu-devel@nongnu.org, contact@canokeys.org,
MkfsSion <myychina28759@gmail.com>
Subject: Re: [PATCH 2/3] hw/usb/canokey: fix compatibility of qemu-xhci
Date: Mon, 13 Jun 2022 12:31:18 +0200 [thread overview]
Message-ID: <20220613103118.3m5wgis6sov4avdt@sirius.home.kraxel.org> (raw)
In-Reply-To: <YqYsBRT9CuqqJyOG@Sun>
Hi,
> case CANOKEY_EP_IN_WAIT:
> /* NAK for early INTR IN */
> p->status = USB_RET_NAK;
> + /* store pointer here for later emu_transmit wakeup */
> + key->ep_in_pointer[ep_in] = p->ep;
There is no need to fish the ep pointer out of usb packets.
You can just use usb_ep_get() instead.
take care,
Gerd
next prev parent reply other threads:[~2022-06-13 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 18:06 [PATCH 0/3] CanoKey: Fix xHCI compatibility and CCID ZLP Hongren (Zenithal) Zheng
2022-06-12 18:09 ` [PATCH 1/3] hw/usb/canokey: Fix " Hongren (Zenithal) Zheng
2022-06-12 18:10 ` [PATCH 2/3] hw/usb/canokey: fix compatibility of qemu-xhci Hongren (Zenithal) Zheng
2022-06-13 10:31 ` Gerd Hoffmann [this message]
2022-06-12 18:10 ` [PATCH 3/3] docs/system/devices/usb/canokey: remove limitations on qemu-xhci Hongren (Zenithal) Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613103118.3m5wgis6sov4avdt@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=contact@canokeys.org \
--cc=i@zenithal.me \
--cc=myychina28759@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).