qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Joe Komlodi" <komlodi@google.com>,
	"Troy Lee" <troy_lee@aspeedtech.com>,
	"Jamin Lin" <jamin_lin@aspeedtech.com>,
	"Steven Lee" <steven_lee@aspeedtech.com>,
	"Klaus Jensen" <k.jensen@samsung.com>,
	"Peter Delevoryas" <pdel@fb.com>,
	"Corey Minyard" <cminyard@mvista.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	"Damien Hedde" <damien.hedde@greensocs.com>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Joel Stanley" <joel@jms.id.au>, "Cleber Rosa" <crosa@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH v2 00/17] aspeed: Extend ast2600 I2C model with new mode
Date: Mon, 13 Jun 2022 15:25:22 +0200	[thread overview]
Message-ID: <20220613132539.2199772-1-clg@kaod.org> (raw)

Hello,

Here is a series aggregating recent changes proposed on the Aspeed
ast2600 I2C controller model. 

First comes a large set of changes converting the model to use the
registerfield interface and adding the I2C new register mode
(Joe). Since this is complex to review, extra tests are added to the
acceptance test suite to check that I2C devices are still functional
in the ast2600-evb machine. These tests use small buildroot images
available on GH.

The ast1030 and ast2600 SoC share the same I2C logic. This series adds
I2C support to the ast1030 now that new register mode is supported.
There was a previous proposal from Troy doing the same but Joe's
patchset covers the same need (and converts the model to registerfield)

Klaus made a proposal to add support for multi master in the I2C core
and the Aspeed I2C model. The last patches add the required bits to
let this happen.  

Thanks,

C.

Changes in v2:

 - reworked I2C avocado tests
 - dropped ctrl_global_rsvd property
 - removed support for multiple masters from Klaus. this change should
   come in its own series.
  

Cédric Le Goater (8):
  aspeed: Remove fake RTC device on ast2500-evb
  test/avocado/machine_aspeed.py: Move OpenBMC tests
  test/avocado/machine_aspeed.py: Add tests using buildroot images
  test/avocado/machine_aspeed.py: Add I2C tests to ast2500-evb
  test/avocado/machine_aspeed.py: Add I2C tests to ast2600-evb
  test/avocado/machine_aspeed.py: Add an I2C RTC test
  aspeed/i2c: Add ast1030 controller models
  aspeed/i2c: Enable SLAVE_ADDR_RX_MATCH always

Joe Komlodi (6):
  hw/registerfields: Add shared fields macros
  aspeed: i2c: Migrate to registerfields API
  aspeed: i2c: Use reg array instead of individual vars
  aspeed: i2c: Add new mode support
  aspeed: i2c: Add PKT_DONE IRQ to trace
  aspeed: i2c: Move regs and helpers to header file

Klaus Jensen (2):
  hw/i2c/aspeed: rework raise interrupt trace event
  hw/i2c/aspeed: add DEV_ADDR in old register mode

Troy Lee (1):
  aspeed: Add I2C buses to AST1030 model

 include/hw/i2c/aspeed_i2c.h         | 289 +++++++++-
 include/hw/registerfields.h         |  70 +++
 hw/arm/aspeed.c                     |  17 +-
 hw/arm/aspeed_ast10x0.c             |  18 +
 hw/i2c/aspeed_i2c.c                 | 820 +++++++++++++++++-----------
 hw/i2c/trace-events                 |   2 +-
 tests/avocado/boot_linux_console.py |  43 --
 tests/avocado/machine_aspeed.py     | 136 +++++
 8 files changed, 1030 insertions(+), 365 deletions(-)

-- 
2.35.3



             reply	other threads:[~2022-06-13 13:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 13:25 Cédric Le Goater [this message]
2022-06-13 13:25 ` [PATCH v2 01/17] aspeed: Remove fake RTC device on ast2500-evb Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 02/17] test/avocado/machine_aspeed.py: Move OpenBMC tests Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 03/17] test/avocado/machine_aspeed.py: Add tests using buildroot images Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 04/17] test/avocado/machine_aspeed.py: Add I2C tests to ast2500-evb Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 05/17] test/avocado/machine_aspeed.py: Add I2C tests to ast2600-evb Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 06/17] test/avocado/machine_aspeed.py: Add an I2C RTC test Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 07/17] hw/registerfields: Add shared fields macros Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 08/17] aspeed: i2c: Migrate to registerfields API Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 09/17] aspeed: i2c: Use reg array instead of individual vars Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 10/17] aspeed: i2c: Add new mode support Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 11/17] aspeed: i2c: Add PKT_DONE IRQ to trace Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 12/17] aspeed: i2c: Move regs and helpers to header file Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 13/17] aspeed/i2c: Add ast1030 controller models Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 14/17] aspeed: Add I2C buses to AST1030 model Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 15/17] hw/i2c/aspeed: rework raise interrupt trace event Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 16/17] hw/i2c/aspeed: add DEV_ADDR in old register mode Cédric Le Goater
2022-06-13 13:25 ` [PATCH v2 17/17] aspeed/i2c: Enable SLAVE_ADDR_RX_MATCH always Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220613132539.2199772-1-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=andrew@aj.id.au \
    --cc=bleal@redhat.com \
    --cc=cminyard@mvista.com \
    --cc=crosa@redhat.com \
    --cc=damien.hedde@greensocs.com \
    --cc=f4bug@amsat.org \
    --cc=jamin_lin@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=k.jensen@samsung.com \
    --cc=komlodi@google.com \
    --cc=pdel@fb.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=steven_lee@aspeedtech.com \
    --cc=troy_lee@aspeedtech.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).