From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D5D7C43334 for ; Tue, 14 Jun 2022 20:04:31 +0000 (UTC) Received: from localhost ([::1]:51406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1Cm6-0001ni-Hq for qemu-devel@archiver.kernel.org; Tue, 14 Jun 2022 16:04:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1CkD-0000oi-Qk; Tue, 14 Jun 2022 16:02:33 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:34519) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1CkC-0006LN-9P; Tue, 14 Jun 2022 16:02:33 -0400 Received: by mail-pl1-x636.google.com with SMTP id i15so8650567plr.1; Tue, 14 Jun 2022 13:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=S62nPbtbbIN1tRJDkkzrKOcK+QaqYtFFKTsgN4rya54=; b=AhoeM/ItgHz8L5Nt8rDOH/RlHMHRzKGELXAgEs6T4BA+SUv63uHP4b0HfhEzleOsWk p6ifbb0NPZEhOcNJ3LluMKe55qFQnCdE7eDv9RWhnxcLeGvVl7Oj5sqkrL0NmiLNTQ4Q vHR6CeItODM39/2gicG55a6tV+7xsnUdS2orJ7u0S2c5Rb9Lg7NWjiJjXCjlRNKWE+y6 lryuDAP7/sHNZSzEdXlFe5BFI4/3CD1jy6c5ltH2+cBvt4WIeg+sFssdUlTRh37Eiq+R BrC9s1yy33eSJI6qIJkGCWmFfOrsXZL1k3gJQpQZMTAOKgSJXPaCL3nca2Zjr4NSOKWL iMxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=S62nPbtbbIN1tRJDkkzrKOcK+QaqYtFFKTsgN4rya54=; b=F18FtWMMtNT42f2zO91jXiV07Txn18YbVahSF+2zhzYtE+KPdx63WdUKmzM42MDEDc PT4py65SRl9O7jtzF1GuEZ3GGHz2Qy0ImqEXpMCu+0zwctw9kW0m9pEySoiud4Tg1sxq RlOTUbb3svUisVqQt8RKEc1OO+eo+xxzGah0TAv2Pi8NdSV96DVBiWYkNLv/+s+Xdxkp pFLuvIMJg4idKPr9xoQfOF/sP3mjlszSZXqzXtKqhXeL/HvZKTlJqeC+AsjCmps2x8h1 j//aG/LL0VRXWWFUKA4Bzb+P7ZODsVSdoIWvQ9T+AvYLuyIo7dJ9AybyFxPsLjgYq/nV zPLw== X-Gm-Message-State: AJIora8+TmB3YxNotgsojnEG5or5qJdQdokC0vuswpx0LhRV72iPXO2c S8KteiTSKjXxYFLbLCOYBRxkpw8XUUm1SA== X-Google-Smtp-Source: AGRyM1uy5HLKcF4ISOvLMZF5NurAQzo4dxa5hql8iX9qRF/Bs0Q0Deb0nLr1fHOVIBJ9zXCDkETh/Q== X-Received: by 2002:a17:90b:2404:b0:1e3:4db0:f32a with SMTP id nr4-20020a17090b240400b001e34db0f32amr6277906pjb.201.1655236949933; Tue, 14 Jun 2022 13:02:29 -0700 (PDT) Received: from zhdaniel-fedora-MJ0FVN0B.corp.tfbnw.net ([2620:10d:c090:500::2:9ac3]) by smtp.gmail.com with ESMTPSA id s30-20020a056a001c5e00b005184c9c46dbsm7945777pfw.81.2022.06.14.13.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 13:02:29 -0700 (PDT) From: Dan Zhang To: qemu-devel@nongnu.org Cc: clg@kaod.org, alistair@alistair23.me, andrew@aj.id.au, dz4list@gmail.com, frasse.iglesias@gmail.com, hreitz@redhat.com, irischenlj@fb.com, irischenlj@gmail.com, joel@jms.id.au, kwolf@redhat.com, lvivier@redhat.com, patrick@stwcx.xyz, pbonzini@redhat.com, pdel@fb.com, peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-block@nongnu.org, thuth@redhat.com Subject: [PATCH] hw:m25p80: Add STATE_STANDBY command state Date: Tue, 14 Jun 2022 13:02:05 -0700 Message-Id: <20220614200205.2945065-1-dz4list@gmail.com> X-Mailer: git-send-email 2.34.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=dz4list@gmail.com; helo=mail-pl1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" HW normally will switch it to stand by mode when receive incorrect command. i.e. Macronix MX66L1G45G data sheet section 8 DEVICE OPERATION described ``` 2. When an incorrect command is written to this device, it enters standby mode and stays in standby mode until the next CS# falling edge. In standby mode, This device's SO pin should be High-Z. ``` Add STATE_STANDBY CMDState and let the device ignore all input and keep SO as HIZ (output 1) Signed-off-by: Dan Zhang --- A usage of this new state can be aborting in HPM checking or unknown command code received. hw/block/m25p80.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index b6bd430a99..9f89773b11 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -423,6 +423,7 @@ typedef enum { STATE_COLLECTING_DATA, STATE_COLLECTING_VAR_LEN_DATA, STATE_READING_DATA, + STATE_STANDBY, } CMDState; typedef enum { @@ -1472,6 +1473,9 @@ static uint32_t m25p80_transfer8(SSIPeripheral *ss, uint32_t tx) s->cur_addr, (uint8_t)tx); switch (s->state) { + case STATE_STANDBY: + r = 0xFFFFFFFF; /* StandBy state SO shall be HiZ */ + break; case STATE_PAGE_PROGRAM: trace_m25p80_page_program(s, s->cur_addr, (uint8_t)tx); -- 2.34.3