From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Beraldo Leal" <bleal@redhat.com>,
qemu-block@nongnu.org, "Hanna Reitz" <hreitz@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Kevin Wolf" <kwolf@redhat.com>,
"Daniel Berrange" <berrange@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"John Snow" <jsnow@redhat.com>
Subject: [PATCH v2 03/10] qga: treat get-guest-fsinfo as "best effort"
Date: Thu, 16 Jun 2022 10:26:52 -0400 [thread overview]
Message-ID: <20220616142659.3184115-4-jsnow@redhat.com> (raw)
In-Reply-To: <20220616142659.3184115-1-jsnow@redhat.com>
In some container environments, there may be references to block devices
witnessable from a container through /proc/self/mountinfo that reference
devices we simply don't have access to in the container, and could not
provide information about.
Instead of failing the entire fsinfo command, return stub information
for these failed lookups.
This allows test-qga to pass under docker tests, which are in turn used
by the CentOS VM tests.
Signed-off-by: John Snow <jsnow@redhat.com>
---
qga/commands-posix.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 0469dc409d4..5989d4dca9d 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -1207,7 +1207,13 @@ static void build_guest_fsinfo_for_device(char const *devpath,
syspath = realpath(devpath, NULL);
if (!syspath) {
- error_setg_errno(errp, errno, "realpath(\"%s\")", devpath);
+ if (errno == ENOENT) {
+ /* This devpath may not exist because of container config, etc. */
+ fprintf(stderr, "realpath(%s) returned NULL/ENOENT\n", devpath);
+ fs->name = g_strdup("??\?-ENOENT");
+ } else {
+ error_setg_errno(errp, errno, "realpath(\"%s\")", devpath);
+ }
return;
}
--
2.34.3
next prev parent reply other threads:[~2022-06-16 14:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 14:26 [PATCH v2 00/10] Improve reliability of VM tests John Snow
2022-06-16 14:26 ` [PATCH v2 01/10] tests/qemu-iotests: hotfix for 307, 223 output John Snow
2022-07-01 8:03 ` Hanna Reitz
2022-06-16 14:26 ` [PATCH v2 02/10] tests/qemu-iotests: skip 108 when FUSE is not loaded John Snow
2022-06-17 9:20 ` Thomas Huth
2022-07-01 8:05 ` Hanna Reitz
2022-07-01 16:15 ` John Snow
2022-07-04 15:36 ` Hanna Reitz
2022-06-16 14:26 ` John Snow [this message]
2022-06-16 14:35 ` [PATCH v2 03/10] qga: treat get-guest-fsinfo as "best effort" Marc-André Lureau
2022-06-16 14:43 ` John Snow
2022-06-17 9:17 ` Thomas Huth
2022-06-17 9:49 ` Daniel P. Berrangé
2022-06-17 14:04 ` John Snow
2022-06-17 14:29 ` Daniel P. Berrangé
2022-06-16 14:26 ` [PATCH v2 04/10] tests/vm: use 'cp' instead of 'ln' for temporary vm images John Snow
2022-06-16 14:26 ` [PATCH v2 05/10] tests/vm: switch CentOS 8 to CentOS 8 Stream John Snow
2022-06-16 14:26 ` [PATCH v2 06/10] tests/vm: switch centos.aarch64 " John Snow
2022-06-16 14:26 ` [PATCH v2 07/10] tests/vm: update sha256sum for ubuntu.aarch64 John Snow
2022-06-16 14:26 ` [PATCH v2 08/10] tests/vm: remove ubuntu.i386 VM test John Snow
2022-06-17 9:24 ` Thomas Huth
2022-06-16 14:26 ` [PATCH v2 09/10] tests/vm: remove duplicate 'centos' " John Snow
2022-06-17 9:30 ` Thomas Huth
2022-06-16 14:26 ` [PATCH v2 10/10] tests/vm: add 512MB extra memory per core John Snow
2022-06-17 16:05 ` [PATCH v2 00/10] Improve reliability of VM tests John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616142659.3184115-4-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=f4bug@amsat.org \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).