* [PATCH] aspeed/hace: Add missing newlines to unimp messages
@ 2022-06-18 9:01 Joel Stanley
2022-06-19 12:54 ` Cédric Le Goater
0 siblings, 1 reply; 2+ messages in thread
From: Joel Stanley @ 2022-06-18 9:01 UTC (permalink / raw)
To: Cédric Le Goater, Peter Maydell; +Cc: qemu-arm, qemu-devel
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
hw/misc/aspeed_hace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c
index 4b5997e18fad..731234b78c4c 100644
--- a/hw/misc/aspeed_hace.c
+++ b/hw/misc/aspeed_hace.c
@@ -340,12 +340,12 @@ static void aspeed_hace_write(void *opaque, hwaddr addr, uint64_t data,
if ((data & HASH_HMAC_MASK)) {
qemu_log_mask(LOG_UNIMP,
- "%s: HMAC engine command mode %"PRIx64" not implemented",
+ "%s: HMAC engine command mode %"PRIx64" not implemented\n",
__func__, (data & HASH_HMAC_MASK) >> 8);
}
if (data & BIT(1)) {
qemu_log_mask(LOG_UNIMP,
- "%s: Cascaded mode not implemented",
+ "%s: Cascaded mode not implemented\n",
__func__);
}
algo = hash_algo_lookup(data);
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] aspeed/hace: Add missing newlines to unimp messages
2022-06-18 9:01 [PATCH] aspeed/hace: Add missing newlines to unimp messages Joel Stanley
@ 2022-06-19 12:54 ` Cédric Le Goater
0 siblings, 0 replies; 2+ messages in thread
From: Cédric Le Goater @ 2022-06-19 12:54 UTC (permalink / raw)
To: Joel Stanley, Peter Maydell; +Cc: qemu-arm, qemu-devel
On 6/18/22 11:01, Joel Stanley wrote:
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> hw/misc/aspeed_hace.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c
> index 4b5997e18fad..731234b78c4c 100644
> --- a/hw/misc/aspeed_hace.c
> +++ b/hw/misc/aspeed_hace.c
> @@ -340,12 +340,12 @@ static void aspeed_hace_write(void *opaque, hwaddr addr, uint64_t data,
>
> if ((data & HASH_HMAC_MASK)) {
> qemu_log_mask(LOG_UNIMP,
> - "%s: HMAC engine command mode %"PRIx64" not implemented",
> + "%s: HMAC engine command mode %"PRIx64" not implemented\n",
> __func__, (data & HASH_HMAC_MASK) >> 8);
> }
> if (data & BIT(1)) {
> qemu_log_mask(LOG_UNIMP,
> - "%s: Cascaded mode not implemented",
> + "%s: Cascaded mode not implemented\n",
> __func__);
> }
> algo = hash_algo_lookup(data);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-19 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-18 9:01 [PATCH] aspeed/hace: Add missing newlines to unimp messages Joel Stanley
2022-06-19 12:54 ` Cédric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).