qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ben Dooks <qemu@ben.fluff.org>
To: qemu-devel@nongnu.org
Cc: palmer@dabbelt.com, Alistair.Francis@wdc.com,
	bin.meng@windriver.com, qemu-riscv@nongnu.org,
	Ben Dooks <qemu@ben.fluff.org>
Subject: [PATCH 3/4] device_tree: add qemu_fdt_setprop_strings() helper
Date: Sat, 18 Jun 2022 21:14:32 +0100	[thread overview]
Message-ID: <20220618201433.240973-4-qemu@ben.fluff.org> (raw)
In-Reply-To: <20220618201433.240973-1-qemu@ben.fluff.org>

Add a helper to set a property from a set of strings
to reduce the following code:

    static const char * const clint_compat[2] = {
        "sifive,clint0", "riscv,clint0"
    };

    qemu_fdt_setprop_string_array(fdt, nodename, "compatible",
        (char **)&clint_compat, ARRAY_SIZE(clint_compat));

Signed-off-by: Ben Dooks <qemu@ben.fluff.org>
--
v2:
- fix node/path in comment
---
 include/sysemu/device_tree.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/include/sysemu/device_tree.h b/include/sysemu/device_tree.h
index 79ce009a22..28b68bacaf 100644
--- a/include/sysemu/device_tree.h
+++ b/include/sysemu/device_tree.h
@@ -87,6 +87,21 @@ int qemu_fdt_setprop_string(void *fdt, const char *node_path,
 int qemu_fdt_setprop_string_array(void *fdt, const char *node_path,
                                   const char *prop, char **array, int len);
 
+/**
+ * qemu_fdt_setprop_strings: set a property from a set of strings
+ *
+ * @fdt: pointer to the dt blob
+ * @path: node name
+ * @prop: property array
+ */
+#define qemu_fdt_setprop_strings(fdt, path, prop, ...)          \
+    do {                                                        \
+        static const char * const __strs[] = { __VA_ARGS__ };   \
+        qemu_fdt_setprop_string_array(fdt, path, prop,          \
+                (char **)&__strs, ARRAY_SIZE(__strs));          \
+    } while(0)
+
+
 int qemu_fdt_setprop_phandle(void *fdt, const char *node_path,
                              const char *property,
                              const char *target_node_path);
-- 
2.35.1



  parent reply	other threads:[~2022-06-18 20:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-18 20:14 [v2] pair of device-tree helpers Ben Dooks
2022-06-18 20:14 ` [PATCH 1/4] device_tree: add qemu_fdt_setprop_reg64_map helper Ben Dooks
2022-06-20  6:41   ` Alistair Francis
2022-06-18 20:14 ` [PATCH 2/4] hw/riscv: use qemu_fdt_setprop_reg64_map() in sifive_u.c Ben Dooks
2022-06-20  6:42   ` Alistair Francis
2022-06-20  6:44     ` Alistair Francis
2022-06-18 20:14 ` Ben Dooks [this message]
2022-06-20  6:47   ` [PATCH 3/4] device_tree: add qemu_fdt_setprop_strings() helper Alistair Francis
2022-06-18 20:14 ` [PATCH 4/4] hw/riscv: use qemu_fdt_setprop_strings() in sifive_u.c Ben Dooks
2022-06-20  6:47   ` Alistair Francis
2022-06-21 10:54     ` Ben Dooks
2022-06-22  5:13       ` Alistair Francis
  -- strict thread matches above, loose matches on Subject: below --
2022-04-16 19:30 A couple of new device-tree helpers Ben Dooks
2022-04-16 19:30 ` [PATCH 3/4] device_tree: add qemu_fdt_setprop_strings() helper Ben Dooks
2022-04-19 22:19   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220618201433.240973-4-qemu@ben.fluff.org \
    --to=qemu@ben.fluff.org \
    --cc=Alistair.Francis@wdc.com \
    --cc=bin.meng@windriver.com \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).