From: Warner Losh <imp@bsdimp.com>
To: qemu-devel@nongnu.org
Cc: Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>,
Stacey Son <sson@FreeBSD.org>, Jung-uk Kim <jkim@FreeBSD.org>
Subject: [PATCH 02/10] bsd-user: Implement symlink, symlinkat, readlink and readlinkat
Date: Mon, 20 Jun 2022 11:42:12 -0600 [thread overview]
Message-ID: <20220620174220.22179-3-imp@bsdimp.com> (raw)
In-Reply-To: <20220620174220.22179-1-imp@bsdimp.com>
Signed-off-by: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Jung-uk Kim <jkim@FreeBSD.org>
Signed-off-by: Warner Losh <imp@bsdimp.com>
---
bsd-user/bsd-file.h | 75 +++++++++++++++++++++++++++++++++++
bsd-user/freebsd/os-syscall.c | 16 ++++++++
2 files changed, 91 insertions(+)
diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h
index 4545df3a056..e5133268546 100644
--- a/bsd-user/bsd-file.h
+++ b/bsd-user/bsd-file.h
@@ -601,4 +601,79 @@ static abi_long do_bsd_nmount(abi_long arg1, abi_long count,
return ret;
}
+/* symlink(2) */
+static abi_long do_bsd_symlink(abi_long arg1, abi_long arg2)
+{
+ abi_long ret;
+ void *p1, *p2;
+
+ LOCK_PATH2(p1, arg1, p2, arg2);
+ ret = get_errno(symlink(p1, p2)); /* XXX path(p1), path(p2) */
+ UNLOCK_PATH2(p1, arg1, p2, arg2);
+
+ return ret;
+}
+
+/* symlinkat(2) */
+static abi_long do_bsd_symlinkat(abi_long arg1, abi_long arg2,
+ abi_long arg3)
+{
+ abi_long ret;
+ void *p1, *p2;
+
+ LOCK_PATH2(p1, arg1, p2, arg3);
+ ret = get_errno(symlinkat(p1, arg2, p2)); /* XXX path(p1), path(p2) */
+ UNLOCK_PATH2(p1, arg1, p2, arg3);
+
+ return ret;
+}
+
+/* readlink(2) */
+static abi_long do_bsd_readlink(CPUArchState *env, abi_long arg1,
+ abi_long arg2, abi_long arg3)
+{
+ abi_long ret;
+ void *p1, *p2;
+
+ LOCK_PATH(p1, arg1);
+ p2 = lock_user(VERIFY_WRITE, arg2, arg3, 0);
+ if (p2 == NULL) {
+ UNLOCK_PATH(p1, arg1);
+ return -TARGET_EFAULT;
+ }
+#ifdef __FreeBSD__
+ if (strcmp(p1, "/proc/curproc/file") == 0) {
+ CPUState *cpu = env_cpu(env);
+ TaskState *ts = (TaskState *)cpu->opaque;
+ strncpy(p2, ts->bprm->fullpath, arg3);
+ ret = MIN((abi_long)strlen(ts->bprm->fullpath), arg3);
+ } else
+#endif
+ ret = get_errno(readlink(path(p1), p2, arg3));
+ unlock_user(p2, arg2, ret);
+ UNLOCK_PATH(p1, arg1);
+
+ return ret;
+}
+
+/* readlinkat(2) */
+static abi_long do_bsd_readlinkat(abi_long arg1, abi_long arg2,
+ abi_long arg3, abi_long arg4)
+{
+ abi_long ret;
+ void *p1, *p2;
+
+ LOCK_PATH(p1, arg2);
+ p2 = lock_user(VERIFY_WRITE, arg3, arg4, 0);
+ if (p2 == NULL) {
+ UNLOCK_PATH(p1, arg2);
+ return -TARGET_EFAULT;
+ }
+ ret = get_errno(readlinkat(arg1, p1, p2, arg4));
+ unlock_user(p2, arg3, ret);
+ UNLOCK_PATH(p1, arg2);
+
+ return ret;
+}
+
#endif /* BSD_FILE_H */
diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
index bd4dfa6ddc7..80ec9dd4954 100644
--- a/bsd-user/freebsd/os-syscall.c
+++ b/bsd-user/freebsd/os-syscall.c
@@ -386,6 +386,22 @@ static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1,
ret = do_bsd_nmount(arg1, arg2, arg3);
break;
+ case TARGET_FREEBSD_NR_symlink: /* symlink(2) */
+ ret = do_bsd_symlink(arg1, arg2);
+ break;
+
+ case TARGET_FREEBSD_NR_symlinkat: /* symlinkat(2) */
+ ret = do_bsd_symlinkat(arg1, arg2, arg3);
+ break;
+
+ case TARGET_FREEBSD_NR_readlink: /* readlink(2) */
+ ret = do_bsd_readlink(cpu_env, arg1, arg2, arg3);
+ break;
+
+ case TARGET_FREEBSD_NR_readlinkat: /* readlinkat(2) */
+ ret = do_bsd_readlinkat(arg1, arg2, arg3, arg4);
+ break;
+
default:
qemu_log_mask(LOG_UNIMP, "Unsupported syscall: %d\n", num);
ret = -TARGET_ENOSYS;
--
2.33.1
next prev parent reply other threads:[~2022-06-20 17:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 17:42 [PATCH 00/10] bsd-user: More file-related system calls Warner Losh
2022-06-20 17:42 ` [PATCH 01/10] bsd-user: Implement mount, umount and nmount Warner Losh
2022-06-20 18:19 ` Richard Henderson
2022-06-20 17:42 ` Warner Losh [this message]
2022-06-20 18:28 ` [PATCH 02/10] bsd-user: Implement symlink, symlinkat, readlink and readlinkat Richard Henderson
2022-06-20 20:17 ` Warner Losh
2022-06-20 17:42 ` [PATCH 03/10] bsd-user: implement chmod, fchmod, lchmod and fchmodat Warner Losh
2022-06-20 18:37 ` Richard Henderson
2022-06-20 17:42 ` [PATCH 04/10] bsd-user: Implement freebsd11_mknod, freebsd11_mknodat and mknodat Warner Losh
2022-06-20 19:13 ` Richard Henderson
2022-06-20 20:32 ` Warner Losh
2022-06-20 17:42 ` [PATCH 05/10] bsd-user: Implement chown, fchown, lchown and fchownat Warner Losh
2022-06-20 19:18 ` Richard Henderson
2022-06-20 17:42 ` [PATCH 06/10] bsd-user: Implement chflags, lchflags and fchflags Warner Losh
2022-06-20 19:19 ` Richard Henderson
2022-06-20 17:42 ` [PATCH 07/10] bsd-user: Implement chroot and flock Warner Losh
2022-06-20 19:21 ` Richard Henderson
2022-06-20 17:42 ` [PATCH 08/10] bsd-user: Implement mkfifo and mkfifoat Warner Losh
2022-06-20 19:21 ` Richard Henderson
2022-06-20 17:42 ` [PATCH 09/10] bsd-user: Implement pathconf, lpathconf and fpathconf Warner Losh
2022-06-20 19:23 ` Richard Henderson
2022-06-20 17:42 ` [PATCH 10/10] bsd-user: Implement undelete Warner Losh
2022-06-20 19:23 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620174220.22179-3-imp@bsdimp.com \
--to=imp@bsdimp.com \
--cc=jkim@FreeBSD.org \
--cc=kevans@freebsd.org \
--cc=qemu-devel@nongnu.org \
--cc=sson@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).