* [PATCH] iotests/297: Have mypy ignore unused ignores
@ 2022-06-21 9:25 Hanna Reitz
2022-06-21 15:53 ` John Snow
0 siblings, 1 reply; 2+ messages in thread
From: Hanna Reitz @ 2022-06-21 9:25 UTC (permalink / raw)
To: qemu-block; +Cc: qemu-devel, Hanna Reitz, John Snow, Kevin Wolf
e7874a50ff3f5b20fb46f36958ad ("python: update for mypy 0.950") has added
`warn_unused_ignores = False` to python/setup.cfg, to be able to keep
compatibility with both pre- and post-0.950 mypy versions.
The iotests' mypy.ini needs the same, or 297 will fail (on both pre- and
post-0.950 mypy, as far as I can tell; just for different `ignore`
lines).
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---
tests/qemu-iotests/mypy.ini | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/mypy.ini b/tests/qemu-iotests/mypy.ini
index 4c0339f558..d66ffc2e3c 100644
--- a/tests/qemu-iotests/mypy.ini
+++ b/tests/qemu-iotests/mypy.ini
@@ -9,4 +9,4 @@ no_implicit_optional = True
scripts_are_modules = True
warn_redundant_casts = True
warn_unused_configs = True
-warn_unused_ignores = True
+warn_unused_ignores = False
--
2.35.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iotests/297: Have mypy ignore unused ignores
2022-06-21 9:25 [PATCH] iotests/297: Have mypy ignore unused ignores Hanna Reitz
@ 2022-06-21 15:53 ` John Snow
0 siblings, 0 replies; 2+ messages in thread
From: John Snow @ 2022-06-21 15:53 UTC (permalink / raw)
To: Hanna Reitz; +Cc: Qemu-block, qemu-devel, Kevin Wolf
[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]
On Tue, Jun 21, 2022, 5:25 AM Hanna Reitz <hreitz@redhat.com> wrote:
> e7874a50ff3f5b20fb46f36958ad ("python: update for mypy 0.950") has added
> `warn_unused_ignores = False` to python/setup.cfg, to be able to keep
> compatibility with both pre- and post-0.950 mypy versions.
>
> The iotests' mypy.ini needs the same, or 297 will fail (on both pre- and
> post-0.950 mypy, as far as I can tell; just for different `ignore`
> lines).
>
> Signed-off-by: Hanna Reitz <hreitz@redhat.com>
> ---
> tests/qemu-iotests/mypy.ini | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/mypy.ini b/tests/qemu-iotests/mypy.ini
> index 4c0339f558..d66ffc2e3c 100644
> --- a/tests/qemu-iotests/mypy.ini
> +++ b/tests/qemu-iotests/mypy.ini
> @@ -9,4 +9,4 @@ no_implicit_optional = True
> scripts_are_modules = True
> warn_redundant_casts = True
> warn_unused_configs = True
> -warn_unused_ignores = True
> +warn_unused_ignores = False
> --
> 2.35.3
>
I'm away for the week, but:
Acked-By: John Snow <jsnow@redhat.com>
🙂
>
[-- Attachment #2: Type: text/html, Size: 1856 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-21 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-21 9:25 [PATCH] iotests/297: Have mypy ignore unused ignores Hanna Reitz
2022-06-21 15:53 ` John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).