From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Juan Quintela" <quintela@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Yanan Wang" <wangyanan55@huawei.com>
Subject: [PATCH 3/5] migration: Simplify ram_find_and_save_block()
Date: Tue, 21 Jun 2022 16:05:05 +0200 [thread overview]
Message-ID: <20220621140507.1246-4-quintela@redhat.com> (raw)
In-Reply-To: <20220621140507.1246-1-quintela@redhat.com>
We will need later that find_dirty_block() return errors, so
simplify the loop.
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/ram.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 35816a3a0a..1d4ff3185b 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2256,7 +2256,6 @@ static int ram_find_and_save_block(RAMState *rs)
{
PageSearchStatus pss;
int pages = 0;
- bool again, found;
/* No dirty page as there is zero RAM */
if (!ram_bytes_total()) {
@@ -2272,18 +2271,17 @@ static int ram_find_and_save_block(RAMState *rs)
}
do {
- again = true;
- found = get_queued_page(rs, &pss);
-
- if (!found) {
+ if (!get_queued_page(rs, &pss)) {
/* priority queue empty, so just search for something dirty */
- found = find_dirty_block(rs, &pss, &again);
+ bool again = true;
+ if (!find_dirty_block(rs, &pss, &again)) {
+ if (!again) {
+ break;
+ }
+ }
}
-
- if (found) {
- pages = ram_save_host_page(rs, &pss);
- }
- } while (!pages && again);
+ pages = ram_save_host_page(rs, &pss);
+ } while (!pages);
rs->last_seen_block = pss.block;
rs->last_page = pss.page;
--
2.34.1
next prev parent reply other threads:[~2022-06-21 14:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 14:05 [PATCH 0/5] Eliminate multifd flush Juan Quintela
2022-06-21 14:05 ` [PATCH 1/5] multifd: Create property multifd-sync-each-iteration Juan Quintela
2022-06-30 14:34 ` Dr. David Alan Gilbert
2022-07-04 16:07 ` Juan Quintela
2022-07-05 12:19 ` Dr. David Alan Gilbert
2022-06-21 14:05 ` [PATCH 2/5] multifd: Put around all sync calls tests for each iteration Juan Quintela
2022-07-05 12:20 ` Dr. David Alan Gilbert
2022-06-21 14:05 ` Juan Quintela [this message]
2022-07-05 12:51 ` [PATCH 3/5] migration: Simplify ram_find_and_save_block() Dr. David Alan Gilbert
2022-06-21 14:05 ` [PATCH 4/5] migration: Make find_dirty_block() return a single parameter Juan Quintela
2022-07-05 12:54 ` Dr. David Alan Gilbert
2022-07-26 16:23 ` Juan Quintela
2022-07-28 9:07 ` Dr. David Alan Gilbert
2022-06-21 14:05 ` [PATCH 5/5] multifd: Only sync once each full round of memory Juan Quintela
2022-07-01 2:29 ` Leonardo Brás
2022-07-04 16:18 ` Juan Quintela
2022-07-05 13:56 ` Dr. David Alan Gilbert
2022-07-05 14:34 ` Daniel P. Berrangé
2022-07-05 15:13 ` Juan Quintela
2022-07-05 15:11 ` Juan Quintela
2022-07-05 16:52 ` Daniel P. Berrangé
2022-07-05 17:13 ` Dr. David Alan Gilbert
2022-07-05 17:16 ` Daniel P. Berrangé
2022-07-05 17:20 ` Dr. David Alan Gilbert
2022-07-28 8:25 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621140507.1246-4-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=leobras@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).