From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hailiang Zhang" <zhanghailiang@xfusion.com>,
"Eric Blake" <eblake@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
qemu-block@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: [PULL 14/25] migration: convert savevm to use QIOChannelBlock for VMState
Date: Wed, 22 Jun 2022 02:25:36 +0200 [thread overview]
Message-ID: <20220622002547.64784-15-quintela@redhat.com> (raw)
In-Reply-To: <20220622002547.64784-1-quintela@redhat.com>
From: Daniel P. Berrangé <berrange@redhat.com>
With this change, all QEMUFile usage is backed by QIOChannel at
last.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/savevm.c | 42 ++++--------------------------------------
1 file changed, 4 insertions(+), 38 deletions(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 75d05f1a84..24a50376dc 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -35,6 +35,7 @@
#include "migration/misc.h"
#include "migration/register.h"
#include "migration/global_state.h"
+#include "migration/channel-block.h"
#include "ram.h"
#include "qemu-file-channel.h"
#include "qemu-file.h"
@@ -130,48 +131,13 @@ static struct mig_cmd_args {
/***********************************************************/
/* savevm/loadvm support */
-static ssize_t block_writev_buffer(void *opaque, struct iovec *iov, int iovcnt,
- int64_t pos, Error **errp)
-{
- int ret;
- QEMUIOVector qiov;
-
- qemu_iovec_init_external(&qiov, iov, iovcnt);
- ret = bdrv_writev_vmstate(opaque, &qiov, pos);
- if (ret < 0) {
- return ret;
- }
-
- return qiov.size;
-}
-
-static ssize_t block_get_buffer(void *opaque, uint8_t *buf, int64_t pos,
- size_t size, Error **errp)
-{
- return bdrv_load_vmstate(opaque, buf, pos, size);
-}
-
-static int bdrv_fclose(void *opaque, Error **errp)
-{
- return bdrv_flush(opaque);
-}
-
-static const QEMUFileOps bdrv_read_ops = {
- .get_buffer = block_get_buffer,
- .close = bdrv_fclose
-};
-
-static const QEMUFileOps bdrv_write_ops = {
- .writev_buffer = block_writev_buffer,
- .close = bdrv_fclose
-};
-
static QEMUFile *qemu_fopen_bdrv(BlockDriverState *bs, int is_writable)
{
if (is_writable) {
- return qemu_fopen_ops(bs, &bdrv_write_ops, false);
+ return qemu_fopen_channel_output(QIO_CHANNEL(qio_channel_block_new(bs)));
+ } else {
+ return qemu_fopen_channel_input(QIO_CHANNEL(qio_channel_block_new(bs)));
}
- return qemu_fopen_ops(bs, &bdrv_read_ops, false);
}
--
2.35.3
next prev parent reply other threads:[~2022-06-22 0:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 0:25 [PULL 00/25] Migration 20220621 patches Juan Quintela
2022-06-22 0:25 ` [PULL 01/25] migration: Remove RDMA_UNREGISTRATION_EXAMPLE Juan Quintela
2022-06-22 0:25 ` [PULL 02/25] QIOChannelSocket: Introduce assert and reduce ifdefs to improve readability Juan Quintela
2022-06-22 0:25 ` [PULL 03/25] QIOChannelSocket: Fix zero-copy send so socket flush works Juan Quintela
2022-06-22 0:25 ` [PULL 04/25] migration: Change zero_copy_send from migration parameter to migration capability Juan Quintela
2022-06-22 0:25 ` [PULL 05/25] io: add a QIOChannelNull equivalent to /dev/null Juan Quintela
2022-06-22 0:25 ` [PULL 06/25] migration: switch to use QIOChannelNull for dummy channel Juan Quintela
2022-06-22 0:25 ` [PULL 07/25] migration: remove unreachble RDMA code in save_hook impl Juan Quintela
2022-06-22 0:25 ` [PULL 08/25] migration: rename rate limiting fields in QEMUFile Juan Quintela
2022-06-22 0:25 ` [PULL 09/25] migration: rename 'pos' field in QEMUFile to 'bytes_processed' Juan Quintela
2022-06-22 0:25 ` [PULL 10/25] migration: rename qemu_ftell to qemu_file_total_transferred Juan Quintela
2022-06-22 0:25 ` [PULL 11/25] migration: rename qemu_update_position to qemu_file_credit_transfer Juan Quintela
2022-06-22 0:25 ` [PULL 12/25] migration: rename qemu_file_update_transfer to qemu_file_acct_rate_limit Juan Quintela
2022-06-22 0:25 ` [PULL 13/25] migration: introduce a QIOChannel impl for BlockDriverState VMState Juan Quintela
2022-06-22 0:25 ` Juan Quintela [this message]
2022-06-22 0:25 ` [PULL 15/25] migration: stop passing 'opaque' parameter to QEMUFile hooks Juan Quintela
2022-06-22 0:25 ` [PULL 16/25] migration: hardcode assumption that QEMUFile is backed with QIOChannel Juan Quintela
2022-06-22 0:25 ` [PULL 17/25] migration: introduce new constructors for QEMUFile Juan Quintela
2022-06-22 0:25 ` [PULL 18/25] migration: remove unused QEMUFileGetFD typedef / qemu_get_fd method Juan Quintela
2022-06-22 0:25 ` [PULL 19/25] migration: remove the QEMUFileOps 'shut_down' callback Juan Quintela
2022-06-22 0:25 ` [PULL 20/25] migration: remove the QEMUFileOps 'set_blocking' callback Juan Quintela
2022-06-22 0:25 ` [PULL 21/25] migration: remove the QEMUFileOps 'close' callback Juan Quintela
2022-06-22 0:25 ` [PULL 22/25] migration: remove the QEMUFileOps 'get_buffer' callback Juan Quintela
2022-06-22 0:25 ` [PULL 23/25] migration: remove the QEMUFileOps 'writev_buffer' callback Juan Quintela
2022-06-22 0:25 ` [PULL 24/25] migration: remove the QEMUFileOps 'get_return_path' callback Juan Quintela
2022-06-22 0:25 ` [PULL 25/25] migration: remove the QEMUFileOps abstraction Juan Quintela
2022-06-22 2:14 ` [PULL 00/25] Migration 20220621 patches Richard Henderson
2022-06-22 15:19 ` Dr. David Alan Gilbert
-- strict thread matches above, loose matches on Subject: below --
2022-06-23 16:53 [PULL 00/25] migration queue Dr. David Alan Gilbert (git)
2022-06-23 16:53 ` [PULL 14/25] migration: convert savevm to use QIOChannelBlock for VMState Dr. David Alan Gilbert (git)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622002547.64784-15-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).