qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Stefano Brivio" <sbrivio@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>
Subject: [RFC PATCH v4 05/11] net: stream: Don't ignore EINVAL on netdev socket connection
Date: Thu, 23 Jun 2022 17:53:11 +0200	[thread overview]
Message-ID: <20220623155317.675932-6-lvivier@redhat.com> (raw)
In-Reply-To: <20220623155317.675932-1-lvivier@redhat.com>

From: Stefano Brivio <sbrivio@redhat.com>

Other errors are treated as failure by net_stream_client_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
[lvivier: applied to net/stream.c]
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
 net/stream.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/stream.c b/net/stream.c
index 0d012ed8f785..d991fe3ac2b9 100644
--- a/net/stream.c
+++ b/net/stream.c
@@ -366,8 +366,7 @@ static int net_stream_client_init(NetClientState *peer,
                 if (errno == EINTR || errno == EWOULDBLOCK) {
                     /* continue */
                 } else if (errno == EINPROGRESS ||
-                           errno == EALREADY ||
-                           errno == EINVAL) {
+                           errno == EALREADY) {
                     break;
                 } else {
                     error_setg_errno(errp, errno, "can't connect socket");
-- 
2.36.1



  parent reply	other threads:[~2022-06-23 15:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-23 15:53 [RFC PATCH v4 00/11] qapi: net: add unix socket type support to netdev backend Laurent Vivier
2022-06-23 15:53 ` [RFC PATCH v4 01/11] net: introduce convert_host_port() Laurent Vivier
2022-06-23 15:53 ` [RFC PATCH v4 02/11] net: remove the @errp argument of net_client_inits() Laurent Vivier
2022-06-23 15:53 ` [RFC PATCH v4 03/11] qapi: net: introduce a way to bypass qemu_opts_parse_noisily() Laurent Vivier
2022-06-24  8:45   ` Markus Armbruster
2022-06-23 15:53 ` [RFC PATCH v4 04/11] qapi: net: add stream and dgram netdevs Laurent Vivier
2022-06-24  9:41   ` Markus Armbruster
2022-06-27 14:36     ` Laurent Vivier
2022-06-29 11:13       ` Markus Armbruster
2022-06-24  9:53   ` Markus Armbruster
2022-06-23 15:53 ` Laurent Vivier [this message]
2022-06-23 15:53 ` [RFC PATCH v4 06/11] net: stream: add unix socket Laurent Vivier
2022-06-23 15:53 ` [RFC PATCH v4 07/11] net: dgram: make dgram_dst generic Laurent Vivier
2022-06-23 15:53 ` [RFC PATCH v4 08/11] net: dgram: move mcast specific code from net_socket_fd_init_dgram() Laurent Vivier
2022-06-23 15:53 ` [RFC PATCH v4 09/11] net: dgram: add unix socket Laurent Vivier
2022-06-23 15:53 ` [RFC PATCH v4 10/11] qemu-sockets: introduce socket_uri() Laurent Vivier
2022-06-29 11:26   ` Markus Armbruster
2022-07-01  9:36     ` Laurent Vivier
2022-07-04  5:08       ` Markus Armbruster
2022-06-23 15:53 ` [RFC PATCH v4 11/11] net: stream: move to QIO Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220623155317.675932-6-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).