From: Eric Blake <eblake@redhat.com>
To: Alberto Faria <afaria@redhat.com>
Cc: qemu-devel@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Ari Sundholm" <ari@tuxera.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Denis V. Lunev" <den@openvz.org>, "Fam Zheng" <fam@euphon.net>,
"Jeff Cody" <codyprime@gmail.com>,
qemu-block@nongnu.org,
"Vladimir Sementsov-Ogievskiy" <v.sementsov-og@mail.ru>,
"Hanna Reitz" <hreitz@redhat.com>, "Stefan Weil" <sw@weilnetz.de>
Subject: Re: [PATCH v5 06/10] block: Make 'bytes' param of bdrv_co_{pread,pwrite,preadv,pwritev}() an int64_t
Date: Thu, 23 Jun 2022 16:26:33 -0500 [thread overview]
Message-ID: <20220623212633.e76bqsvdhg4qhza4@redhat.com> (raw)
In-Reply-To: <20220609152744.3891847-7-afaria@redhat.com>
On Thu, Jun 09, 2022 at 04:27:40PM +0100, Alberto Faria wrote:
> For consistency with other I/O functions, and in preparation to
> implement bdrv_{pread,pwrite}() using generated_co_wrapper.
>
> unsigned int fits in int64_t, so all callers remain correct.
>
> bdrv_check_request32() is called further down the stack and causes -EIO
> to be returned if 'bytes' is negative or greater than
> BDRV_REQUEST_MAX_BYTES, which in turns never exceeds SIZE_MAX.
>
> Signed-off-by: Alberto Faria <afaria@redhat.com>
> ---
> block/coroutines.h | 4 ++--
> include/block/block_int-io.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2022-06-23 21:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 15:27 [PATCH v5 00/10] Implement bdrv_{pread, pwrite, pwrite_sync, pwrite_zeroes}() using generated_co_wrapper Alberto Faria
2022-06-09 15:27 ` [PATCH v5 01/10] block: Add a 'flags' param to bdrv_{pread, pwrite, pwrite_sync}() Alberto Faria
2022-07-04 11:48 ` [PATCH v5 01/10] block: Add a 'flags' param to bdrv_{pread,pwrite,pwrite_sync}() Hanna Reitz
2022-06-09 15:27 ` [PATCH v5 02/10] block: Change bdrv_{pread, pwrite, pwrite_sync}() param order Alberto Faria
2022-07-04 11:48 ` Hanna Reitz
2022-06-09 15:27 ` [PATCH v5 03/10] block: Make bdrv_{pread, pwrite}() return 0 on success Alberto Faria
2022-07-04 11:48 ` [PATCH v5 03/10] block: Make bdrv_{pread,pwrite}() " Hanna Reitz
2022-06-09 15:27 ` [PATCH v5 04/10] crypto: Make block callbacks " Alberto Faria
2022-07-04 11:48 ` Hanna Reitz
2022-06-09 15:27 ` [PATCH v5 05/10] block: Make bdrv_co_pwrite() take a const buffer Alberto Faria
2022-07-04 11:49 ` Hanna Reitz
2022-06-09 15:27 ` [PATCH v5 06/10] block: Make 'bytes' param of bdrv_co_{pread, pwrite, preadv, pwritev}() an int64_t Alberto Faria
2022-06-23 21:26 ` Eric Blake [this message]
2022-07-04 11:47 ` [PATCH v5 06/10] block: Make 'bytes' param of bdrv_co_{pread,pwrite,preadv,pwritev}() " Hanna Reitz
2022-06-09 15:27 ` [PATCH v5 07/10] block: Implement bdrv_{pread, pwrite, pwrite_zeroes}() using generated_co_wrapper Alberto Faria
2022-06-23 21:47 ` [PATCH v5 07/10] block: Implement bdrv_{pread,pwrite,pwrite_zeroes}() " Eric Blake
2022-07-03 22:27 ` [PATCH v5 07/10] block: Implement bdrv_{pread, pwrite, pwrite_zeroes}() " Alberto Faria
2022-07-04 12:06 ` [PATCH v5 07/10] block: Implement bdrv_{pread,pwrite,pwrite_zeroes}() " Hanna Reitz
2022-06-09 15:27 ` [PATCH v5 08/10] block: Add bdrv_co_pwrite_sync() Alberto Faria
2022-07-04 12:14 ` Hanna Reitz
2022-06-09 15:27 ` [PATCH v5 09/10] block: Use bdrv_co_pwrite_sync() when caller is coroutine_fn Alberto Faria
2022-07-04 12:16 ` Hanna Reitz
2022-06-09 15:27 ` [PATCH v5 10/10] block/qcow2: Use bdrv_pwrite_sync() in qcow2_mark_dirty() Alberto Faria
2022-07-04 12:18 ` Hanna Reitz
2022-06-23 20:20 ` [PATCH v5 00/10] Implement bdrv_{pread, pwrite, pwrite_sync, pwrite_zeroes}() using generated_co_wrapper Alberto Faria
2022-07-02 14:11 ` Paolo Bonzini
2022-07-04 12:27 ` [PATCH v5 00/10] Implement bdrv_{pread,pwrite,pwrite_sync,pwrite_zeroes}() " Hanna Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623212633.e76bqsvdhg4qhza4@redhat.com \
--to=eblake@redhat.com \
--cc=afaria@redhat.com \
--cc=ari@tuxera.com \
--cc=berrange@redhat.com \
--cc=codyprime@gmail.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
--cc=v.sementsov-og@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).