* [PATCH] virtio-iommu: Fix migration regression
@ 2022-06-24 9:37 Zhenzhong Duan
2022-06-27 16:31 ` Eric Auger
0 siblings, 1 reply; 2+ messages in thread
From: Zhenzhong Duan @ 2022-06-24 9:37 UTC (permalink / raw)
To: qemu-devel; +Cc: eric.auger, mst, jean-philippe
We also need to switch to the right address space on dest side
after loading the device status. DMA to wrong address space is
destructive.
Fixes: 3facd774962fd ("virtio-iommu: Add bypass mode support to assigned device")
Suggested-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
hw/virtio/virtio-iommu.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
index 08b227e828f8..281152d338f4 100644
--- a/hw/virtio/virtio-iommu.c
+++ b/hw/virtio/virtio-iommu.c
@@ -1322,6 +1322,14 @@ static int iommu_post_load(void *opaque, int version_id)
VirtIOIOMMU *s = opaque;
g_tree_foreach(s->domains, reconstruct_endpoints, s);
+
+ /*
+ * Memory regions are dynamically turned on/off depending on
+ * 'config.bypass' and attached domain type if there is. After
+ * migration, we need to make sure the memory regions are
+ * still correct.
+ */
+ virtio_iommu_switch_address_space_all(s);
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] virtio-iommu: Fix migration regression
2022-06-24 9:37 [PATCH] virtio-iommu: Fix migration regression Zhenzhong Duan
@ 2022-06-27 16:31 ` Eric Auger
0 siblings, 0 replies; 2+ messages in thread
From: Eric Auger @ 2022-06-27 16:31 UTC (permalink / raw)
To: Zhenzhong Duan, qemu-devel; +Cc: mst, jean-philippe
Hi,
On 6/24/22 11:37, Zhenzhong Duan wrote:
> We also need to switch to the right address space on dest side
> after loading the device status. DMA to wrong address space is
> destructive.
>
> Fixes: 3facd774962fd ("virtio-iommu: Add bypass mode support to assigned device")
> Suggested-by: Eric Auger <eric.auger@redhat.com>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Eric
> ---
> hw/virtio/virtio-iommu.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
> index 08b227e828f8..281152d338f4 100644
> --- a/hw/virtio/virtio-iommu.c
> +++ b/hw/virtio/virtio-iommu.c
> @@ -1322,6 +1322,14 @@ static int iommu_post_load(void *opaque, int version_id)
> VirtIOIOMMU *s = opaque;
>
> g_tree_foreach(s->domains, reconstruct_endpoints, s);
> +
> + /*
> + * Memory regions are dynamically turned on/off depending on
> + * 'config.bypass' and attached domain type if there is. After
> + * migration, we need to make sure the memory regions are
> + * still correct.
> + */
> + virtio_iommu_switch_address_space_all(s);
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-27 16:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-24 9:37 [PATCH] virtio-iommu: Fix migration regression Zhenzhong Duan
2022-06-27 16:31 ` Eric Auger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).