From: Shaobo Song <shnusongshaobo@gmail.com>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, Shaobo Song <shnusongshaobo@gmail.com>
Subject: [PATCH] tcg: Fix returned type in alloc_code_gen_buffer_splitwx_memfd()
Date: Fri, 24 Jun 2022 23:02:17 +0800 [thread overview]
Message-ID: <20220624150216.3627-1-shnusongshaobo@gmail.com> (raw)
This fixes a bug in POSIX-compliant environments. Since we had allocated
a buffer named 'tcg-jit' with read-write access protections we need a int
type to combine these access flags and return it, whereas we had inexplicably
return a bool type. It may cause an unnecessary protection change in
tcg_region_init().
Signed-off-by: Shaobo Song <shnusongshaobo@gmail.com>
---
tcg/region.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/region.c b/tcg/region.c
index 71ea81d671..88d6bb273f 100644
--- a/tcg/region.c
+++ b/tcg/region.c
@@ -548,7 +548,7 @@ static int alloc_code_gen_buffer_anon(size_t size, int prot,
#ifdef CONFIG_POSIX
#include "qemu/memfd.h"
-static bool alloc_code_gen_buffer_splitwx_memfd(size_t size, Error **errp)
+static int alloc_code_gen_buffer_splitwx_memfd(size_t size, Error **errp)
{
void *buf_rw = NULL, *buf_rx = MAP_FAILED;
int fd = -1;
--
2.25.1
next reply other threads:[~2022-06-24 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 15:02 Shaobo Song [this message]
2022-06-25 16:32 ` [PATCH] tcg: Fix returned type in alloc_code_gen_buffer_splitwx_memfd() Alex Bennée
2022-06-26 10:49 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624150216.3627-1-shnusongshaobo@gmail.com \
--to=shnusongshaobo@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).