qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [PULL v2 07/20] block/export: Fix incorrect length passed to vu_queue_push()
Date: Fri, 24 Jun 2022 17:40:50 +0200	[thread overview]
Message-ID: <20220624154103.185902-8-kwolf@redhat.com> (raw)
In-Reply-To: <20220624154103.185902-1-kwolf@redhat.com>

From: Xie Yongji <xieyongji@bytedance.com>

Now the req->size is set to the correct value only
when handling VIRTIO_BLK_T_GET_ID request. This patch
fixes it.

Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Message-Id: <20220523084611.91-3-xieyongji@bytedance.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/export/vhost-user-blk-server.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c
index b2e458ade3..19c6ee51d3 100644
--- a/block/export/vhost-user-blk-server.c
+++ b/block/export/vhost-user-blk-server.c
@@ -60,8 +60,7 @@ static void vu_blk_req_complete(VuBlkReq *req)
 {
     VuDev *vu_dev = &req->server->vu_dev;
 
-    /* IO size with 1 extra status byte */
-    vu_queue_push(vu_dev, req->vq, &req->elem, req->size + 1);
+    vu_queue_push(vu_dev, req->vq, &req->elem, req->size);
     vu_queue_notify(vu_dev, req->vq);
 
     free(req);
@@ -207,6 +206,7 @@ static void coroutine_fn vu_blk_virtio_process_req(void *opaque)
         goto err;
     }
 
+    req->size = iov_size(in_iov, in_num);
     /* We always touch the last byte, so just see how big in_iov is.  */
     req->in = (void *)in_iov[in_num - 1].iov_base
               + in_iov[in_num - 1].iov_len
@@ -267,7 +267,6 @@ static void coroutine_fn vu_blk_virtio_process_req(void *opaque)
                           VIRTIO_BLK_ID_BYTES);
         snprintf(elem->in_sg[0].iov_base, size, "%s", "vhost_user_blk");
         req->in->status = VIRTIO_BLK_S_OK;
-        req->size = elem->in_sg[0].iov_len;
         break;
     }
     case VIRTIO_BLK_T_DISCARD:
-- 
2.35.3



  parent reply	other threads:[~2022-06-24 15:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24 15:40 [PULL v2 00/20] Block layer patches Kevin Wolf
2022-06-24 15:40 ` [PULL v2 01/20] block: drop unused bdrv_co_drain() API Kevin Wolf
2022-06-24 15:40 ` [PULL v2 02/20] block: get rid of blk->guest_block_size Kevin Wolf
2022-06-24 15:40 ` [PULL v2 03/20] block: block_dirty_bitmap_merge(): fix error path Kevin Wolf
2022-06-24 15:40 ` [PULL v2 04/20] block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap Kevin Wolf
2022-06-24 15:40 ` [PULL v2 05/20] block: simplify handling of try to merge different sized bitmaps Kevin Wolf
2022-06-24 15:40 ` [PULL v2 06/20] block: Support passing NULL ops to blk_set_dev_ops() Kevin Wolf
2022-06-24 15:40 ` Kevin Wolf [this message]
2022-06-24 15:40 ` [PULL v2 08/20] block/export: Abstract out the logic of virtio-blk I/O process Kevin Wolf
2022-06-24 15:40 ` [PULL v2 09/20] linux-headers: Add vduse.h Kevin Wolf
2022-06-24 15:40 ` [PULL v2 10/20] libvduse: Add VDUSE (vDPA Device in Userspace) library Kevin Wolf
2022-06-27  4:45   ` Markus Armbruster
2022-06-27  8:34     ` Yongji Xie
2022-06-24 15:40 ` [PULL v2 11/20] vduse-blk: Implement vduse-blk export Kevin Wolf
2022-06-24 15:40 ` [PULL v2 12/20] vduse-blk: Add vduse-blk resize support Kevin Wolf
2022-06-24 15:40 ` [PULL v2 13/20] libvduse: Add support for reconnecting Kevin Wolf
2022-06-24 15:40 ` [PULL v2 14/20] qsd: document vduse-blk exports Kevin Wolf
2022-06-24 15:40 ` [PULL v2 15/20] block/rbd: report a better error when namespace does not exist Kevin Wolf
2022-06-24 15:40 ` [PULL v2 16/20] block/gluster: correctly set max_pdiscard Kevin Wolf
2022-06-24 15:41 ` [PULL v2 17/20] aio_wait_kick: add missing memory barrier Kevin Wolf
2022-06-24 15:41 ` [PULL v2 18/20] nbd: Drop dead code spotted by Coverity Kevin Wolf
2022-06-24 15:41 ` [PULL v2 19/20] vduse-blk: Add serial option Kevin Wolf
2022-06-24 15:41 ` [PULL v2 20/20] vduse-blk: Add name option Kevin Wolf
2022-06-24 20:38 ` [PULL v2 00/20] Block layer patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220624154103.185902-8-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).