From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55A2DC433EF for ; Fri, 24 Jun 2022 15:07:39 +0000 (UTC) Received: from localhost ([::1]:48920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4kuI-0006nB-Dj for qemu-devel@archiver.kernel.org; Fri, 24 Jun 2022 11:07:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60178) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4krc-0002a3-37 for qemu-devel@nongnu.org; Fri, 24 Jun 2022 11:04:52 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:2639) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4krZ-0002di-Nf for qemu-devel@nongnu.org; Fri, 24 Jun 2022 11:04:51 -0400 Received: from fraeml739-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LV0l26y7tz67yRq; Fri, 24 Jun 2022 23:04:14 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml739-chm.china.huawei.com (10.206.15.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 24 Jun 2022 17:04:46 +0200 Received: from localhost (10.81.207.131) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 24 Jun 2022 16:04:45 +0100 Date: Fri, 24 Jun 2022 16:04:42 +0100 To: Brice Goglin CC: QEMU Developers , Liu Jingqi , Eduardo Habkost , "Marcel Apfelbaum" , Philippe =?ISO-8859-1?Q?Mathieu-D?= =?ISO-8859-1?Q?aud=E9?= , Yanan Wang , Igor Mammedov Subject: Re: [PATCH 0/4] hmat acpi: Don't require initiator value in -numa Message-ID: <20220624160442.00002af2@Huawei.com> In-Reply-To: References: Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.81.207.131] X-ClientProxiedBy: lhreml735-chm.china.huawei.com (10.201.108.86) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Jonathan Cameron From: Jonathan Cameron via On Thu, 23 Jun 2022 16:56:58 +0200 Brice Goglin wrote: > Brice Goglin (4): > hmat acpi: Don't require initiator value in -numa > tests: acpi: add and whitelist *.hmat-noinitiator expected blobs > tests: acpi: q35: add test for hmat nodes without initiators > tests: acpi: q35: update expected blobs *.hmat-noinitiators] Hi Brice, Given I reviewed on your github prior to you sending this and you've addressed the few minor things I raised. Reviewed-by: Jonathan Cameron Nice to tidy this up. Jonathan > > hw/core/machine.c | 4 +- > tests/data/acpi/q35/APIC.acpihmat-noinitiator | Bin 0 -> 144 bytes > tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 0 -> 8553 bytes > tests/data/acpi/q35/FACP.acpihmat-noinitiator | Bin 0 -> 244 bytes > tests/data/acpi/q35/HMAT.acpihmat-noinitiator | Bin 0 -> 288 bytes > tests/data/acpi/q35/SRAT.acpihmat-noinitiator | Bin 0 -> 312 bytes > tests/qtest/bios-tables-test.c | 45 ++++++++++++++++++ > 7 files changed, 46 insertions(+), 3 deletions(-) > create mode 100644 tests/data/acpi/q35/APIC.acpihmat-noinitiator > create mode 100644 tests/data/acpi/q35/DSDT.acpihmat-noinitiator > create mode 100644 tests/data/acpi/q35/FACP.acpihmat-noinitiator > create mode 100644 tests/data/acpi/q35/HMAT.acpihmat-noinitiator > create mode 100644 tests/data/acpi/q35/SRAT.acpihmat-noinitiator >