From: Sam Li <faithilikerun@gmail.com>
To: qemu-devel@nongnu.org
Cc: hare@suse.de, Hanna Reitz <hreitz@redhat.com>,
dmitry.fomichev@wdc.com, Kevin Wolf <kwolf@redhat.com>,
Fam Zheng <fam@euphon.net>, Stefan Hajnoczi <stefanha@redhat.com>,
damien.lemoal@opensource.wdc.com, qemu-block@nongnu.org,
Sam Li <faithilikerun@gmail.com>
Subject: [RFC v3 3/5] file-posix: introduce get_sysfs_long_val for zoned device information.
Date: Mon, 27 Jun 2022 08:19:15 +0800 [thread overview]
Message-ID: <20220627001917.9417-4-faithilikerun@gmail.com> (raw)
In-Reply-To: <20220627001917.9417-1-faithilikerun@gmail.com>
Use sysfs attribute files to get the zoned device information in case
that ioctl() commands of zone management interface won't work. It can
return long type of value like chunk_sectors, zoned_append_max_bytes,
max_open_zones, max_active_zones.
---
block/file-posix.c | 37 +++++++++++++++++++++++++------------
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 1b8b0d351f..73c2cdfbca 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1216,15 +1216,19 @@ static int hdev_get_max_hw_transfer(int fd, struct stat *st)
#endif
}
-static int hdev_get_max_segments(int fd, struct stat *st)
-{
+/*
+ * Get zoned device information (chunk_sectors, zoned_append_max_bytes,
+ * max_open_zones, max_active_zones) through sysfs attribute files.
+ */
+static long get_sysfs_long_val(int fd, struct stat *st,
+ const char *attribute) {
#ifdef CONFIG_LINUX
char buf[32];
const char *end;
char *sysfspath = NULL;
int ret;
int sysfd = -1;
- long max_segments;
+ long val;
if (S_ISCHR(st->st_mode)) {
if (ioctl(fd, SG_GET_SG_TABLESIZE, &ret) == 0) {
@@ -1237,8 +1241,9 @@ static int hdev_get_max_segments(int fd, struct stat *st)
return -ENOTSUP;
}
- sysfspath = g_strdup_printf("/sys/dev/block/%u:%u/queue/max_segments",
- major(st->st_rdev), minor(st->st_rdev));
+ sysfspath = g_strdup_printf("/sys/dev/block/%u:%u/queue/%s",
+ major(st->st_rdev), minor(st->st_rdev),
+ attribute);
sysfd = open(sysfspath, O_RDONLY);
if (sysfd == -1) {
ret = -errno;
@@ -1256,9 +1261,9 @@ static int hdev_get_max_segments(int fd, struct stat *st)
}
buf[ret] = 0;
/* The file is ended with '\n', pass 'end' to accept that. */
- ret = qemu_strtol(buf, &end, 10, &max_segments);
+ ret = qemu_strtol(buf, &end, 10, &val);
if (ret == 0 && end && *end == '\n') {
- ret = max_segments;
+ ret = val;
}
out:
@@ -1272,6 +1277,15 @@ out:
#endif
}
+static int hdev_get_max_segments(int fd, struct stat *st) {
+ int ret;
+ ret = get_sysfs_long_val(fd, st, "max_segments");
+ if (ret < 0) {
+ return -1;
+ }
+ return ret;
+}
+
static void raw_refresh_limits(BlockDriverState *bs, Error **errp)
{
BDRVRawState *s = bs->opaque;
@@ -1872,6 +1886,7 @@ static int handle_aiocb_zone_report(void *opaque) {
static int handle_aiocb_zone_mgmt(void *opaque) {
RawPosixAIOData *aiocb = opaque;
+ BlockDriverState *s = aiocb->bs;
int fd = aiocb->aio_fildes;
int64_t offset = aiocb->aio_offset;
int64_t len = aiocb->aio_nbytes;
@@ -1884,11 +1899,9 @@ static int handle_aiocb_zone_mgmt(void *opaque) {
int64_t zone_size_mask;
int ret;
- ret = ioctl(fd, BLKGETZONESZ, &zone_size);
- if (ret) {
- return -1;
- }
-
+ g_autofree struct stat *file = g_new(struct stat, 1);
+ stat(s->filename, file);
+ zone_size = get_sysfs_long_val(fd, file, "chunk_sectors");
zone_size_mask = zone_size - 1;
if (offset & zone_size_mask) {
error_report("offset is not the start of a zone");
--
2.35.3
next prev parent reply other threads:[~2022-06-27 0:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 0:19 [RFC v3 0/5] *** Add support for zoned device *** Sam Li
2022-06-27 0:19 ` [RFC v3 1/5] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls Sam Li
2022-06-27 7:21 ` Hannes Reinecke
2022-06-27 7:45 ` Sam Li
2022-06-27 14:15 ` Stefan Hajnoczi
2022-06-28 8:05 ` Sam Li
2022-06-28 9:05 ` Damien Le Moal
2022-06-28 10:23 ` Sam Li
2022-06-29 1:43 ` Damien Le Moal
2022-06-29 1:50 ` Sam Li
2022-06-29 2:32 ` Damien Le Moal
2022-06-29 2:35 ` Sam Li
2022-06-27 0:19 ` [RFC v3 2/5] qemu-io: add zoned block device operations Sam Li
2022-06-27 7:30 ` Hannes Reinecke
2022-06-27 8:31 ` Sam Li
2022-06-28 7:56 ` Stefan Hajnoczi
2022-06-28 9:02 ` Sam Li
2022-06-28 9:11 ` Damien Le Moal
2022-06-28 10:27 ` Sam Li
2022-06-27 0:19 ` Sam Li [this message]
2022-06-27 7:31 ` [RFC v3 3/5] file-posix: introduce get_sysfs_long_val for zoned device information Hannes Reinecke
2022-06-27 8:32 ` Sam Li
2022-06-28 8:09 ` Stefan Hajnoczi
2022-06-28 9:18 ` Sam Li
2022-06-27 0:19 ` [RFC v3 4/5] file-posix: introduce get_sysfs_str_val for device zoned model Sam Li
2022-06-27 7:41 ` Hannes Reinecke
2022-06-27 8:44 ` Sam Li
2022-06-27 0:19 ` [RFC v3 5/5] qemu-iotests: add zone operation tests Sam Li
2022-06-27 7:42 ` Hannes Reinecke
2022-06-28 8:19 ` Stefan Hajnoczi
2022-06-28 9:34 ` Sam Li
2022-06-30 10:11 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627001917.9417-4-faithilikerun@gmail.com \
--to=faithilikerun@gmail.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dmitry.fomichev@wdc.com \
--cc=fam@euphon.net \
--cc=hare@suse.de \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).