From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, mst@redhat.com, raphael.norwitz@nutanix.com,
stefanha@redhat.com, qemu-devel@nongnu.org
Subject: [PATCH 0/3] libvhost-user: NEED_REPLY behaviour fixes
Date: Mon, 27 Jun 2022 15:44:57 +0200 [thread overview]
Message-ID: <20220627134500.94842-1-kwolf@redhat.com> (raw)
Command handlers shouldn't send replies themselves, but just prepare the
message and let vu_dispatch() send it. Otherwise, vu_dispatch() will add
a second reply as an ACK when NEED_REPLY was requested.
QEMU's vhost-user devices are not affected by these bugs because they
don't set NEED_REPLY for the commands that get it wrong. libblkio does
run into it, though.
Kevin Wolf (3):
docs/vhost-user: Fix mismerge
libvhost-user: Fix VHOST_USER_GET_MAX_MEM_SLOTS reply
libvhost-user: Fix VHOST_USER_ADD_MEM_REG reply
docs/interop/vhost-user.rst | 16 ----------------
subprojects/libvhost-user/libvhost-user.c | 19 +++----------------
2 files changed, 3 insertions(+), 32 deletions(-)
--
2.35.3
next reply other threads:[~2022-06-27 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 13:44 Kevin Wolf [this message]
2022-06-27 13:44 ` [PATCH 1/3] docs/vhost-user: Fix mismerge Kevin Wolf
2022-06-27 13:49 ` Peter Maydell
2022-06-27 13:44 ` [PATCH 2/3] libvhost-user: Fix VHOST_USER_GET_MAX_MEM_SLOTS reply Kevin Wolf
2022-06-27 13:45 ` [PATCH 3/3] libvhost-user: Fix VHOST_USER_ADD_MEM_REG reply Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627134500.94842-1-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).