From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC28CC433EF for ; Mon, 27 Jun 2022 13:48:12 +0000 (UTC) Received: from localhost ([::1]:60836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5p62-000607-S6 for qemu-devel@archiver.kernel.org; Mon, 27 Jun 2022 09:48:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5p3B-0003Tn-G1 for qemu-devel@nongnu.org; Mon, 27 Jun 2022 09:45:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:35614) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5p38-0004G4-1i for qemu-devel@nongnu.org; Mon, 27 Jun 2022 09:45:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656337508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ftYg2QLCiDWBAfX+CCgwwi9LghUoWiVwGytngOREGos=; b=ZZRbiHiD+tATM1KdJ5FLKe4yWyzETxL15xZOD2s/S8o+YU3jPQjRKfFWhayFOoSYSWG+up 0ofwkVvQ1256gu2YTShbk1FUT/LHZ942pML2UiR74k168U5DFdXwIErF7uk9GQ1J2H5Zql lsmnQh7tN3sy6cCkR7G8HlEcQivuPXM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-261-yAyyG6VYPu6gPGdf-T5kzQ-1; Mon, 27 Jun 2022 09:45:07 -0400 X-MC-Unique: yAyyG6VYPu6gPGdf-T5kzQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D031D80029D; Mon, 27 Jun 2022 13:45:06 +0000 (UTC) Received: from merkur.fritz.box (unknown [10.39.194.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id C7F469D54; Mon, 27 Jun 2022 13:45:05 +0000 (UTC) From: Kevin Wolf To: qemu-block@nongnu.org Cc: kwolf@redhat.com, mst@redhat.com, raphael.norwitz@nutanix.com, stefanha@redhat.com, qemu-devel@nongnu.org Subject: [PATCH 0/3] libvhost-user: NEED_REPLY behaviour fixes Date: Mon, 27 Jun 2022 15:44:57 +0200 Message-Id: <20220627134500.94842-1-kwolf@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Command handlers shouldn't send replies themselves, but just prepare the message and let vu_dispatch() send it. Otherwise, vu_dispatch() will add a second reply as an ACK when NEED_REPLY was requested. QEMU's vhost-user devices are not affected by these bugs because they don't set NEED_REPLY for the commands that get it wrong. libblkio does run into it, though. Kevin Wolf (3): docs/vhost-user: Fix mismerge libvhost-user: Fix VHOST_USER_GET_MAX_MEM_SLOTS reply libvhost-user: Fix VHOST_USER_ADD_MEM_REG reply docs/interop/vhost-user.rst | 16 ---------------- subprojects/libvhost-user/libvhost-user.c | 19 +++---------------- 2 files changed, 3 insertions(+), 32 deletions(-) -- 2.35.3