From: "Felix xq Queißner" <xq@random-projects.net>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com, thuth@redhat.com,
"Felix \"xq\" Queißner" <xq@random-projects.net>
Subject: [PATCH] gtk: Add show_tabs=on|off command line option.
Date: Mon, 27 Jun 2022 18:44:05 +0200 [thread overview]
Message-ID: <20220627164404.12137-1-xq@random-projects.net> (raw)
The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM.
Signed-off-by: Felix "xq" Queißner <xq@random-projects.net>
---
qapi/ui.json | 5 ++++-
qemu-options.hx | 2 +-
ui/gtk.c | 4 ++++
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/qapi/ui.json b/qapi/ui.json
index 413371d5e8..049e7957a9 100644
--- a/qapi/ui.json
+++ b/qapi/ui.json
@@ -1195,12 +1195,15 @@
# assuming the guest will resize the display to match
# the window size then. Otherwise it defaults to "off".
# Since 3.1
+# @show-tabs: Displays the tab items by default.
+# Since 7.1
#
# Since: 2.12
##
{ 'struct' : 'DisplayGTK',
'data' : { '*grab-on-hover' : 'bool',
- '*zoom-to-fit' : 'bool' } }
+ '*zoom-to-fit' : 'bool',
+ '*show-tabs' : 'bool' } }
##
# @DisplayEGLHeadless:
diff --git a/qemu-options.hx b/qemu-options.hx
index 377d22fbd8..2b279afff7 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1937,7 +1937,7 @@ DEF("display", HAS_ARG, QEMU_OPTION_display,
" [,window-close=on|off]\n"
#endif
#if defined(CONFIG_GTK)
- "-display gtk[,full-screen=on|off][,gl=on|off][,grab-on-hover=on|off]\n"
+ "-display gtk[,full-screen=on|off][,gl=on|off][,grab-on-hover=on|off][,show-tabs=on|off]\n"
" [,show-cursor=on|off][,window-close=on|off]\n"
#endif
#if defined(CONFIG_VNC)
diff --git a/ui/gtk.c b/ui/gtk.c
index 2a791dd2aa..1467b8c7d7 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -2390,6 +2390,10 @@ static void gtk_display_init(DisplayState *ds, DisplayOptions *opts)
opts->u.gtk.grab_on_hover) {
gtk_menu_item_activate(GTK_MENU_ITEM(s->grab_on_hover_item));
}
+ if (opts->u.gtk.has_show_tabs &&
+ opts->u.gtk.show_tabs) {
+ gtk_menu_item_activate(GTK_MENU_ITEM(s->show_tabs_item));
+ }
gd_clipboard_init(s);
}
--
2.36.1
next reply other threads:[~2022-06-27 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 16:44 Felix xq Queißner [this message]
2022-06-30 14:09 ` [PATCH] gtk: Add show_tabs=on|off command line option Hanna Reitz
2022-06-30 14:13 ` Hanna Reitz
2022-06-30 14:53 ` Markus Armbruster
2022-07-01 10:00 ` Gerd Hoffmann
2022-07-01 9:14 ` Zhang, Chen
2022-07-01 10:01 ` kraxel
2022-07-12 7:35 ` Felix Queißner
2022-07-12 10:11 ` Hanna Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627164404.12137-1-xq@random-projects.net \
--to=xq@random-projects.net \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).