From: Peter Delevoryas <pdel@fb.com>
Cc: <pdel@fb.com>, <zhdaniel@fb.com>, <clg@kaod.org>,
<qemu-devel@nongnu.org>, <qemu-arm@nongnu.org>,
<komlodi@google.com>, <titusr@google.com>, <andrew@aj.id.au>,
<joel@jms.id.au>
Subject: [PATCH 00/14] aspeed: Add I2C new register DMA slave mode support
Date: Mon, 27 Jun 2022 12:54:52 -0700 [thread overview]
Message-ID: <20220627195506.403715-1-pdel@fb.com> (raw)
Hey everyone,
I'm sending a big patch series for this, but only the last commit is really
intended to be accepted right now. I'm just including the rest of them
because it depends on them for testing.
Klaus's changes include the multi-master stuff in hw/i2c/core.c, and the old
register mode slave mode support.
My series of patches includes a bunch of changes to eliminate most (if not
all) of the I2C errors reported by the fb OpenBIC firmware for fby35
CraterLake Bridge Interconnect (BIC) (shortname: oby35-cl) upon startup.
In particular, I needed to add the IC_DEVICE_ID to the isl voltage regulator
implementation, which required a fix to the pmbus implementation when
switching pages. We weren't resetting the buffer state when switching
pages there.
I also added a placeholder implementation of the PECI controller, that does
almost nothing, but doesn't produce errors.
I added the fby35-cpld, which oby35-cl queries using master-mode TX and RX
commands.
And finally, I added an "intel-me" device (Intel Management Engine) that
attempts to respond to the first IPMB message sent by the BIC. I used this
to test the final patch, which I actually want to merge, the I2C new
register DMA slave mode support.
All the patches except the last one can be ignored for now if you want,
again, I just included them for testing purposes.
The final patch is pretty rough, but I wanted to start the review instead of
waiting too long. I expect the interrupt handling part will be
the main blocker.
Thanks,
Peter
Klaus Jensen (3):
hw/i2c: support multiple masters
hw/i2c: add asynchronous send
hw/i2c/aspeed: add slave device in old register mode
Peter Delevoryas (11):
aspeed: i2c: Fix DMA len write-enable bit handling
aspeed: i2c: Fix R_I2CD_FUN_CTRL reference
aspeed: i2c: Fix MASTER_EN missing error message
aspeed: Add PECI controller
hw/misc: Add fby35-cpld
pmbus: Reset out buf after switching pages
pmbus: Add read-only IC_DEVICE_ID support
aspeed: Add oby35-cl machine
hw/misc: Add intel-me
aspeed: Add intel-me on i2c6 instead of BMC
aspeed: Add I2C new register DMA slave mode support
hw/arm/aspeed.c | 42 ++++++
hw/arm/aspeed_ast10x0.c | 11 ++
hw/arm/pxa2xx.c | 2 +
hw/display/sii9022.c | 2 +
hw/display/ssd0303.c | 2 +
hw/i2c/aspeed_i2c.c | 234 +++++++++++++++++++++++++++----
hw/i2c/core.c | 70 ++++++++-
hw/i2c/pmbus_device.c | 6 +
hw/i2c/smbus_slave.c | 4 +
hw/i2c/trace-events | 2 +
hw/misc/aspeed_peci.c | 225 +++++++++++++++++++++++++++++
hw/misc/fby35_cpld.c | 137 ++++++++++++++++++
hw/misc/intel_me.c | 176 +++++++++++++++++++++++
hw/misc/meson.build | 5 +-
hw/nvram/eeprom_at24c.c | 2 +
hw/sensor/isl_pmbus_vr.c | 30 ++++
hw/sensor/lsm303dlhc_mag.c | 2 +
include/hw/arm/aspeed_soc.h | 3 +
include/hw/i2c/aspeed_i2c.h | 11 ++
include/hw/i2c/i2c.h | 30 ++++
include/hw/i2c/pmbus_device.h | 1 +
include/hw/misc/aspeed_peci.h | 34 +++++
include/hw/sensor/isl_pmbus_vr.h | 1 +
23 files changed, 1002 insertions(+), 30 deletions(-)
create mode 100644 hw/misc/aspeed_peci.c
create mode 100644 hw/misc/fby35_cpld.c
create mode 100644 hw/misc/intel_me.c
create mode 100644 include/hw/misc/aspeed_peci.h
--
2.30.2
next reply other threads:[~2022-06-27 19:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 19:54 Peter Delevoryas [this message]
2022-06-27 19:54 ` [PATCH 01/14] hw/i2c: support multiple masters Peter Delevoryas
2022-06-27 19:54 ` [PATCH 02/14] hw/i2c: add asynchronous send Peter Delevoryas
2022-06-27 19:54 ` [PATCH 03/14] hw/i2c/aspeed: add slave device in old register mode Peter Delevoryas
2022-06-27 19:54 ` [PATCH 04/14] aspeed: i2c: Fix DMA len write-enable bit handling Peter Delevoryas
2022-06-28 7:01 ` Cédric Le Goater
2022-06-28 7:05 ` Peter Delevoryas
2022-06-27 19:54 ` [PATCH 05/14] aspeed: i2c: Fix R_I2CD_FUN_CTRL reference Peter Delevoryas
2022-06-28 7:01 ` Cédric Le Goater
2022-06-28 7:05 ` Peter Delevoryas
2022-06-27 19:54 ` [PATCH 07/14] aspeed: Add PECI controller Peter Delevoryas
2022-06-28 6:47 ` Cédric Le Goater
2022-06-28 6:58 ` Peter Delevoryas
2022-06-27 19:55 ` [PATCH 08/14] hw/misc: Add fby35-cpld Peter Delevoryas
2022-06-28 6:50 ` Cédric Le Goater
2022-06-28 7:00 ` Peter Delevoryas
2022-06-27 19:55 ` [PATCH 09/14] pmbus: Reset out buf after switching pages Peter Delevoryas
2022-06-28 6:51 ` Cédric Le Goater
2022-06-28 7:04 ` Peter Delevoryas
2022-06-27 19:55 ` [PATCH 10/14] pmbus: Add read-only IC_DEVICE_ID support Peter Delevoryas
2022-06-27 19:55 ` [PATCH 11/14] aspeed: Add oby35-cl machine Peter Delevoryas
2022-06-27 20:04 ` [PATCH 00/14] aspeed: Add I2C new register DMA slave mode support Peter Delevoryas
2022-06-27 22:27 ` [PATCH 12/14] hw/misc: Add intel-me Peter Delevoryas
2022-06-27 22:27 ` [PATCH 13/14] aspeed: Add intel-me on i2c6 instead of BMC Peter Delevoryas
2022-06-27 22:27 ` [PATCH 14/14] aspeed: Add I2C new register DMA slave mode support Peter Delevoryas
2022-06-28 7:02 ` Cédric Le Goater
2022-06-28 7:06 ` Peter Delevoryas
2022-06-28 6:58 ` [PATCH 12/14] hw/misc: Add intel-me Cédric Le Goater
2022-06-28 7:17 ` Peter Delevoryas
2022-06-28 7:05 ` [PATCH 00/14] aspeed: Add I2C new register DMA slave mode support Cédric Le Goater
2022-06-28 7:16 ` Peter Delevoryas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627195506.403715-1-pdel@fb.com \
--to=pdel@fb.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=komlodi@google.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=titusr@google.com \
--cc=zhdaniel@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).