qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: f4bug@amsat.org, alex.bennee@linaro.org, jiaxun.yang@flygoat.com,
	aleksandar.rikalo@syrmia.com
Subject: [PATCH v5 6/8] semihosting: Remove qemu_semihosting_log_out
Date: Tue, 28 Jun 2022 16:46:59 +0530	[thread overview]
Message-ID: <20220628111701.677216-7-richard.henderson@linaro.org> (raw)
In-Reply-To: <20220628111701.677216-1-richard.henderson@linaro.org>

The function is no longer used.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 include/semihosting/console.h | 13 -------------
 semihosting/console.c         |  9 ---------
 2 files changed, 22 deletions(-)

diff --git a/include/semihosting/console.h b/include/semihosting/console.h
index 61b0cb3a94..bd78e5f03f 100644
--- a/include/semihosting/console.h
+++ b/include/semihosting/console.h
@@ -40,19 +40,6 @@ int qemu_semihosting_console_read(CPUState *cs, void *buf, int len);
  */
 int qemu_semihosting_console_write(void *buf, int len);
 
-/**
- * qemu_semihosting_log_out:
- * @s: pointer to string
- * @len: length of string
- *
- * Send a string to the debug output. Unlike console_out these strings
- * can't be sent to a remote gdb instance as they don't exist in guest
- * memory.
- *
- * Returns: number of bytes written
- */
-int qemu_semihosting_log_out(const char *s, int len);
-
 /*
  * qemu_semihosting_console_block_until_ready:
  * @cs: CPUState
diff --git a/semihosting/console.c b/semihosting/console.c
index cda7cf1905..5b1ec0a1c3 100644
--- a/semihosting/console.c
+++ b/semihosting/console.c
@@ -38,15 +38,6 @@ typedef struct SemihostingConsole {
 
 static SemihostingConsole console;
 
-int qemu_semihosting_log_out(const char *s, int len)
-{
-    if (console.chr) {
-        return qemu_chr_write_all(console.chr, (uint8_t *) s, len);
-    } else {
-        return write(STDERR_FILENO, s, len);
-    }
-}
-
 #define FIFO_SIZE   1024
 
 static int console_can_read(void *opaque)
-- 
2.34.1



  parent reply	other threads:[~2022-06-28 11:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-28 11:16 [PATCH v5 0/8] target/mips: semihosting cleanup Richard Henderson
2022-06-28 11:16 ` [PATCH v5 1/8] target/mips: Create report_fault for semihosting Richard Henderson
2022-07-12 20:23   ` Philippe Mathieu-Daudé via
2022-06-28 11:16 ` [PATCH v5 2/8] target/mips: Drop link syscall from semihosting Richard Henderson
2022-07-12 20:19   ` Philippe Mathieu-Daudé via
2022-06-28 11:16 ` [PATCH v5 3/8] target/mips: Use semihosting/syscalls.h Richard Henderson
2022-07-12 20:21   ` Philippe Mathieu-Daudé via
2022-07-12 20:25   ` Philippe Mathieu-Daudé via
2022-06-28 11:16 ` [PATCH v5 4/8] target/mips: Avoid qemu_semihosting_log_out for UHI_plog Richard Henderson
2022-07-12 20:25   ` Philippe Mathieu-Daudé via
2022-06-28 11:16 ` [PATCH v5 5/8] target/mips: Use error_report for UHI_assert Richard Henderson
2022-07-12 20:22   ` Philippe Mathieu-Daudé via
2022-06-28 11:16 ` Richard Henderson [this message]
2022-06-28 11:17 ` [PATCH v5 7/8] target/mips: Simplify UHI_argnlen and UHI_argn Richard Henderson
2022-07-12 20:22   ` Philippe Mathieu-Daudé via
2022-06-28 11:17 ` [PATCH v5 8/8] target/mips: Remove GET_TARGET_STRING and FREE_TARGET_STRING Richard Henderson
2022-07-12 20:25 ` [PATCH v5 0/8] target/mips: semihosting cleanup Philippe Mathieu-Daudé via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220628111701.677216-7-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).