From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Thomas Huth <thuth@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
Zhang Chen <chen.zhang@intel.com>,
Laurent Vivier <laurent@vivier.eu>
Subject: [PULL 08/11] common-user: Only compile the common user code if have_user is set
Date: Wed, 29 Jun 2022 11:08:46 +0200 [thread overview]
Message-ID: <20220629090849.1350227-9-laurent@vivier.eu> (raw)
In-Reply-To: <20220629090849.1350227-1-laurent@vivier.eu>
From: Thomas Huth <thuth@redhat.com>
There is no need to waste cycles here if we only compile the system
binaries or tools. Additionally, this change is even a hard requirement
for building the tools on systems that do not have an entry in the
common-user/host/ folder (since common-user/meson.build is trying
to add such a path via the include_directories() command).
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Message-Id: <20220622140328.383961-1-thuth@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
common-user/meson.build | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/common-user/meson.build b/common-user/meson.build
index 26212dda5c7a..ac9de5b9e3f5 100644
--- a/common-user/meson.build
+++ b/common-user/meson.build
@@ -1,3 +1,7 @@
+if not have_user
+ subdir_done()
+endif
+
common_user_inc += include_directories('host/' / host_arch)
user_ss.add(files(
--
2.36.1
next prev parent reply other threads:[~2022-06-29 9:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 9:08 [PULL 00/11] Trivial branch for 7.1 patches Laurent Vivier
2022-06-29 9:08 ` [PULL 01/11] vga: avoid crash if no default vga card Laurent Vivier
2022-06-29 9:08 ` [PULL 02/11] qom/object: Remove circular include dependency Laurent Vivier
2022-06-29 9:08 ` [PULL 03/11] util: Return void on iova_tree_remove Laurent Vivier
2022-06-29 9:08 ` [PULL 04/11] Trivial: 3 char repeat typos Laurent Vivier
2022-06-29 9:08 ` [PULL 05/11] trivial typos: namesapce Laurent Vivier
2022-06-29 9:08 ` [PULL 06/11] MAINTAINERS: Add softmmu/runstate.c to "Main loop" Laurent Vivier
2022-06-29 9:08 ` [PULL 07/11] hw/pci-host/i440fx: Remove unused parameter from i440fx_init() Laurent Vivier
2022-06-29 9:08 ` Laurent Vivier [this message]
2022-06-29 9:08 ` [PULL 09/11] hw/ide/atapi.c: Correct typos (CD-CDROM -> CD-ROM) Laurent Vivier
2022-06-29 9:08 ` [PULL 10/11] hw/i386/xen/xen-hvm: Allow for stubbing xen_set_pci_link_route() Laurent Vivier
2022-06-29 9:08 ` [PULL 11/11] hw/i386/xen/xen-hvm: Inline xen_piix_pci_write_config_client() and remove it Laurent Vivier
2022-06-30 0:53 ` [PULL 00/11] Trivial branch for 7.1 patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629090849.1350227-9-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=chen.zhang@intel.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).