From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Bin Meng" <bmeng.cn@gmail.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 2/3] gitlab: tweak comments in edk2/opensbi jobs
Date: Wed, 29 Jun 2022 18:06:37 +0100 [thread overview]
Message-ID: <20220629170638.520630-3-berrange@redhat.com> (raw)
In-Reply-To: <20220629170638.520630-1-berrange@redhat.com>
Get rid of comments stating the obvious and re-arrange remaining
comments. The opensbi split of rules for file matches is also
merged into one rule.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
.gitlab-ci.d/edk2.yml | 14 ++++++++------
.gitlab-ci.d/opensbi.yml | 15 ++++++++-------
2 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/.gitlab-ci.d/edk2.yml b/.gitlab-ci.d/edk2.yml
index fbe763a282..905e02440f 100644
--- a/.gitlab-ci.d/edk2.yml
+++ b/.gitlab-ci.d/edk2.yml
@@ -1,17 +1,19 @@
# All jobs needing docker-edk2 must use the same rules it uses.
.edk2_job_rules:
- rules: # Only run this job when ...
+ rules:
+ # Run if any files affecting the build output are touched
- changes:
- # this file is modified
- .gitlab-ci.d/edk2.yml
- # or the Dockerfile is modified
- .gitlab-ci.d/edk2/Dockerfile
- # or roms/edk2/ is modified (submodule updated)
- roms/edk2/*
when: on_success
- - if: '$CI_COMMIT_REF_NAME =~ /^edk2/' # or the branch/tag starts with 'edk2'
+
+ # Run if the branch/tag starts with 'edk2'
+ - if: '$CI_COMMIT_REF_NAME =~ /^edk2/'
when: on_success
- - if: '$CI_COMMIT_MESSAGE =~ /edk2/i' # or last commit description contains 'EDK2'
+
+ # Run if last commit msg contains 'EDK2' (case insensitive)
+ - if: '$CI_COMMIT_MESSAGE =~ /edk2/i'
when: on_success
docker-edk2:
diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml
index 0745ccdf10..753a003f93 100644
--- a/.gitlab-ci.d/opensbi.yml
+++ b/.gitlab-ci.d/opensbi.yml
@@ -1,18 +1,19 @@
# All jobs needing docker-opensbi must use the same rules it uses.
.opensbi_job_rules:
- rules: # Only run this job when ...
+ rules:
+ # Run if any files affecting the build output are touched
- changes:
- # this file is modified
- .gitlab-ci.d/opensbi.yml
- # or the Dockerfile is modified
- .gitlab-ci.d/opensbi/Dockerfile
- when: on_success
- - changes: # or roms/opensbi/ is modified (submodule updated)
- roms/opensbi/*
when: on_success
- - if: '$CI_COMMIT_REF_NAME =~ /^opensbi/' # or the branch/tag starts with 'opensbi'
+
+ # Run if the branch/tag starts with 'opensbi'
+ - if: '$CI_COMMIT_REF_NAME =~ /^opensbi/'
when: on_success
- - if: '$CI_COMMIT_MESSAGE =~ /opensbi/i' # or last commit description contains 'OpenSBI'
+
+ # Run if the last commit msg contains 'OpenSBI' (case insensitive)
+ - if: '$CI_COMMIT_MESSAGE =~ /opensbi/i'
when: on_success
docker-opensbi:
--
2.36.1
next prev parent reply other threads:[~2022-06-29 17:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 17:06 [PATCH 0/3] gitlab: stopp edk2/opensbi jobs running in forks by default Daniel P. Berrangé
2022-06-29 17:06 ` [PATCH 1/3] gitlab: normalize indentation in edk2/opensbi rules Daniel P. Berrangé
2022-07-01 1:40 ` Richard Henderson
2022-06-29 17:06 ` Daniel P. Berrangé [this message]
2022-07-01 1:42 ` [PATCH 2/3] gitlab: tweak comments in edk2/opensbi jobs Richard Henderson
2022-06-29 17:06 ` [PATCH 3/3] gitlab: honour QEMU_CI variable " Daniel P. Berrangé
2022-07-01 1:43 ` Richard Henderson
2022-07-01 8:56 ` Daniel P. Berrangé
2022-07-04 14:21 ` [PATCH 0/3] gitlab: stopp edk2/opensbi jobs running in forks by default Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629170638.520630-3-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=bmeng.cn@gmail.com \
--cc=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).