From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, clg@kaod.org,
Daniel Henrique Barboza <danielhb413@gmail.com>
Subject: [PATCH 9/9] spapr.c: handle clock freq read errors in spapr_dt_cpu()
Date: Thu, 30 Jun 2022 16:42:49 -0300 [thread overview]
Message-ID: <20220630194249.886747-10-danielhb413@gmail.com> (raw)
In-Reply-To: <20220630194249.886747-1-danielhb413@gmail.com>
Let's put the default spapr clock value in a SPAPR_CLOCK_FREQ for better
readability.
After that, make 'cpufreq' default to SPAPR_CLOCK_FREQ if
kvmppc_get_clockfreq() fails to read the clock from the DT.
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
hw/ppc/spapr.c | 12 +++++++++++-
include/hw/ppc/spapr.h | 1 +
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index f66e3cbe38..80189c78be 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -654,7 +654,7 @@ static void spapr_dt_cpu(CPUState *cs, void *fdt, int offset,
0xffffffff, 0xffffffff};
uint32_t tbfreq = kvm_enabled() ? kvmppc_get_tbfreq()
: SPAPR_TIMEBASE_FREQ;
- uint32_t cpufreq = kvm_enabled() ? kvmppc_get_clockfreq(NULL) : 1000000000;
+ uint32_t cpufreq = SPAPR_CLOCK_FREQ;
uint32_t page_sizes_prop[64];
size_t page_sizes_prop_size;
unsigned int smp_threads = ms->smp.threads;
@@ -699,6 +699,16 @@ static void spapr_dt_cpu(CPUState *cs, void *fdt, int offset,
}
_FDT((fdt_setprop_cell(fdt, offset, "timebase-frequency", tbfreq)));
+
+ if (kvm_enabled()) {
+ Error *local_err = NULL;
+
+ cpufreq = kvmppc_get_clockfreq(&local_err);
+ if (local_err) {
+ cpufreq = SPAPR_CLOCK_FREQ;
+ }
+ }
+
_FDT((fdt_setprop_cell(fdt, offset, "clock-frequency", cpufreq)));
_FDT((fdt_setprop_cell(fdt, offset, "slb-size", cpu->hash64_opts->slb_size)));
_FDT((fdt_setprop_cell(fdt, offset, "ibm,slb-size", cpu->hash64_opts->slb_size)));
diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
index 072dda2c72..ed579635ca 100644
--- a/include/hw/ppc/spapr.h
+++ b/include/hw/ppc/spapr.h
@@ -26,6 +26,7 @@ typedef struct SpaprPendingHpt SpaprPendingHpt;
#define SPAPR_ENTRY_POINT 0x100
#define SPAPR_TIMEBASE_FREQ 512000000ULL
+#define SPAPR_CLOCK_FREQ 1000000000ULL
#define TYPE_SPAPR_RTC "spapr-rtc"
--
2.36.1
prev parent reply other threads:[~2022-06-30 19:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 19:42 [PATCH 0/9] cleanup error handling in kvmppc_read_int_cpu_dt() Daniel Henrique Barboza
2022-06-30 19:42 ` [PATCH 1/9] target/ppc/kvm.c: do not return -1 on uint64_t return Daniel Henrique Barboza
2022-06-30 19:42 ` [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt() Daniel Henrique Barboza
2022-07-02 6:24 ` Cédric Le Goater
2022-07-02 13:34 ` Daniel Henrique Barboza
2022-07-04 17:34 ` Cédric Le Goater
2022-07-04 23:19 ` Daniel Henrique Barboza
2022-07-05 6:51 ` Mark Cave-Ayland
2022-07-05 6:57 ` Cédric Le Goater
2022-07-06 7:45 ` Cédric Le Goater
2022-07-11 7:37 ` Mark Cave-Ayland
2022-07-11 7:42 ` Cédric Le Goater
2022-07-12 12:11 ` Mark Cave-Ayland
2022-07-12 14:54 ` BALATON Zoltan
2022-07-13 20:30 ` Mark Cave-Ayland
2022-07-11 12:05 ` BALATON Zoltan
2022-07-05 9:39 ` Daniel Henrique Barboza
2022-07-05 9:44 ` Mark Cave-Ayland
2022-07-05 9:51 ` Daniel Henrique Barboza
2022-07-05 9:44 ` Cédric Le Goater
2022-06-30 19:42 ` [PATCH 3/9] target/ppc: Add error reporting when opening file fails Daniel Henrique Barboza
2022-07-02 6:24 ` Cédric Le Goater
2022-06-30 19:42 ` [PATCH 4/9] target/ppc: use g_autofree in kvmppc_read_int_cpu_dt() Daniel Henrique Barboza
2022-07-02 6:20 ` Cédric Le Goater
2022-07-06 17:10 ` Daniel Henrique Barboza
2022-06-30 19:42 ` [PATCH 5/9] target/ppc: use Error pointer in kvmppc_get_clockfreq() Daniel Henrique Barboza
2022-07-02 6:22 ` Cédric Le Goater
2022-06-30 19:42 ` [PATCH 6/9] ppc440_bamboo.c: handle clock freq read error in load_device_tree Daniel Henrique Barboza
2022-07-02 6:23 ` Cédric Le Goater
2022-06-30 19:42 ` [PATCH 7/9] sam460ex.c: use CPU_FREQ if unable to read DT clock Daniel Henrique Barboza
2022-06-30 19:42 ` [PATCH 8/9] e500.c: use PLATFORM_CLK_FREQ_HZ if unable to read clock freq from DT Daniel Henrique Barboza
2022-06-30 19:42 ` Daniel Henrique Barboza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630194249.886747-10-danielhb413@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).