From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: <linuxarm@huawei.com>, <qemu-devel@nongnu.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
"Ben Widawsky" <bwidawsk@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH 2/3] hw/i386/pc: Always place CXL Memory Regions after device_memory
Date: Fri, 1 Jul 2022 14:22:59 +0100 [thread overview]
Message-ID: <20220701132300.2264-3-Jonathan.Cameron@huawei.com> (raw)
In-Reply-To: <20220701132300.2264-1-Jonathan.Cameron@huawei.com>
Previously broken_reserved_end was taken into account, but Igor Mammedov
identified that this could lead to a clash between potential RAM being
mapped in the region and CXL usage. Hence always add the size of the
device_memory memory region. This only affects the case where the
broken_reserved_end flag was set.
Fixes: 6e4e3ae936e6 ("hw/cxl/component: Implement host bridge MMIO (8.2.5, table 142)")
Reported-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
hw/i386/pc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 774cb2bf07..8d68295fda 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -922,10 +922,8 @@ void pc_memory_init(PCMachineState *pcms,
hwaddr cxl_size = MiB;
if (pcmc->has_reserved_memory && machine->device_memory->base) {
- cxl_base = machine->device_memory->base;
- if (!pcmc->broken_reserved_end) {
- cxl_base += memory_region_size(&machine->device_memory->mr);
- }
+ cxl_base = machine->device_memory->base
+ + memory_region_size(&machine->device_memory->mr);
} else if (pcms->sgx_epc.size != 0) {
cxl_base = sgx_epc_above_4g_end(&pcms->sgx_epc);
} else {
--
2.32.0
next prev parent reply other threads:[~2022-07-01 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 13:22 [PATCH 0/3] hw/cxl, hw/machine, hw/i386: Misc minor fixes / cleanup Jonathan Cameron via
2022-07-01 13:22 ` [PATCH 1/3] hw/machine: Clear out left over CXL related pointer from move of state handling to machines Jonathan Cameron via
2022-07-01 13:22 ` Jonathan Cameron via [this message]
2022-07-01 13:23 ` [PATCH 3/3] hw/cxl: Fix size of constant in interleave granularity function Jonathan Cameron via
2022-07-11 12:42 ` [PATCH 0/3] hw/cxl, hw/machine, hw/i386: Misc minor fixes / cleanup Igor Mammedov
2022-07-19 14:09 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701132300.2264-3-Jonathan.Cameron@huawei.com \
--to=qemu-devel@nongnu.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=bwidawsk@kernel.org \
--cc=imammedo@redhat.com \
--cc=linuxarm@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=shameerali.kolothum.thodi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).