* [PATCH] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER
@ 2022-07-05 8:36 Richard Henderson
2022-07-05 8:44 ` gaosong
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Richard Henderson @ 2022-07-05 8:36 UTC (permalink / raw)
To: qemu-devel; +Cc: Song Gao
There is nothing in this environment variable that cannot
be done better with -d flags. There is nothing special
about TCI that warrants this hack.
Moreover, it does not compile -- remove it.
Reported-by: Song Gao <gaosong@loongson.cn>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/tci/tcg-target.h | 5 -----
tcg/tci/tcg-target.c.inc | 7 -------
2 files changed, 12 deletions(-)
diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h
index 033e613f24..ceb36c4f7a 100644
--- a/tcg/tci/tcg-target.h
+++ b/tcg/tci/tcg-target.h
@@ -53,11 +53,6 @@
# error Unknown pointer size for tci target
#endif
-#ifdef CONFIG_DEBUG_TCG
-/* Enable debug output. */
-#define CONFIG_DEBUG_TCG_INTERPRETER
-#endif
-
/* Optional instructions. */
#define TCG_TARGET_HAS_bswap16_i32 1
diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc
index 98337c567a..f3d7441e06 100644
--- a/tcg/tci/tcg-target.c.inc
+++ b/tcg/tci/tcg-target.c.inc
@@ -823,13 +823,6 @@ static void tcg_out_nop_fill(tcg_insn_unit *p, int count)
static void tcg_target_init(TCGContext *s)
{
-#if defined(CONFIG_DEBUG_TCG_INTERPRETER)
- const char *envval = getenv("DEBUG_TCG");
- if (envval) {
- qemu_set_log(strtol(envval, NULL, 0));
- }
-#endif
-
/* The current code uses uint8_t for tcg operations. */
tcg_debug_assert(tcg_op_defs_max <= UINT8_MAX);
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER
2022-07-05 8:36 [PATCH] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER Richard Henderson
@ 2022-07-05 8:44 ` gaosong
2022-07-05 10:37 ` Alex Bennée
2022-07-06 21:01 ` Philippe Mathieu-Daudé via
2 siblings, 0 replies; 5+ messages in thread
From: gaosong @ 2022-07-05 8:44 UTC (permalink / raw)
To: Richard Henderson, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]
On 2022/7/5 下午4:36, Richard Henderson wrote:
> There is nothing in this environment variable that cannot
> be done better with -d flags. There is nothing special
> about TCI that warrants this hack.
>
> Moreover, it does not compile -- remove it.
>
> Reported-by: Song Gao <gaosong@loongson.cn>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
Reviewed-by: Song Gao <gaosong@loongson.cn>
> tcg/tci/tcg-target.h | 5 -----
> tcg/tci/tcg-target.c.inc | 7 -------
> 2 files changed, 12 deletions(-)
>
> diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h
> index 033e613f24..ceb36c4f7a 100644
> --- a/tcg/tci/tcg-target.h
> +++ b/tcg/tci/tcg-target.h
> @@ -53,11 +53,6 @@
> # error Unknown pointer size for tci target
> #endif
>
> -#ifdef CONFIG_DEBUG_TCG
> -/* Enable debug output. */
> -#define CONFIG_DEBUG_TCG_INTERPRETER
> -#endif
> -
> /* Optional instructions. */
>
> #define TCG_TARGET_HAS_bswap16_i32 1
> diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc
> index 98337c567a..f3d7441e06 100644
> --- a/tcg/tci/tcg-target.c.inc
> +++ b/tcg/tci/tcg-target.c.inc
> @@ -823,13 +823,6 @@ static void tcg_out_nop_fill(tcg_insn_unit *p, int count)
>
> static void tcg_target_init(TCGContext *s)
> {
> -#if defined(CONFIG_DEBUG_TCG_INTERPRETER)
> - const char *envval = getenv("DEBUG_TCG");
> - if (envval) {
> - qemu_set_log(strtol(envval, NULL, 0));
> - }
> -#endif
> -
> /* The current code uses uint8_t for tcg operations. */
> tcg_debug_assert(tcg_op_defs_max <= UINT8_MAX);
>
[-- Attachment #2: Type: text/html, Size: 2716 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER
2022-07-05 8:36 [PATCH] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER Richard Henderson
2022-07-05 8:44 ` gaosong
@ 2022-07-05 10:37 ` Alex Bennée
2022-07-06 21:01 ` Philippe Mathieu-Daudé via
2 siblings, 0 replies; 5+ messages in thread
From: Alex Bennée @ 2022-07-05 10:37 UTC (permalink / raw)
To: Richard Henderson; +Cc: Song Gao, qemu-devel
Richard Henderson <richard.henderson@linaro.org> writes:
> There is nothing in this environment variable that cannot
> be done better with -d flags. There is nothing special
> about TCI that warrants this hack.
>
> Moreover, it does not compile -- remove it.
>
> Reported-by: Song Gao <gaosong@loongson.cn>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER
2022-07-05 10:59 [PULL 0/6] loongarch64 patch queue Richard Henderson
@ 2022-07-05 10:59 ` Richard Henderson
0 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2022-07-05 10:59 UTC (permalink / raw)
To: qemu-devel; +Cc: Song Gao
There is nothing in this environment variable that cannot
be done better with -d flags. There is nothing special
about TCI that warrants this hack.
Moreover, it does not compile -- remove it.
Reported-by: Song Gao <gaosong@loongson.cn>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/tci/tcg-target.h | 5 -----
tcg/tci/tcg-target.c.inc | 7 -------
2 files changed, 12 deletions(-)
diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h
index 033e613f24..ceb36c4f7a 100644
--- a/tcg/tci/tcg-target.h
+++ b/tcg/tci/tcg-target.h
@@ -53,11 +53,6 @@
# error Unknown pointer size for tci target
#endif
-#ifdef CONFIG_DEBUG_TCG
-/* Enable debug output. */
-#define CONFIG_DEBUG_TCG_INTERPRETER
-#endif
-
/* Optional instructions. */
#define TCG_TARGET_HAS_bswap16_i32 1
diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc
index 98337c567a..f3d7441e06 100644
--- a/tcg/tci/tcg-target.c.inc
+++ b/tcg/tci/tcg-target.c.inc
@@ -823,13 +823,6 @@ static void tcg_out_nop_fill(tcg_insn_unit *p, int count)
static void tcg_target_init(TCGContext *s)
{
-#if defined(CONFIG_DEBUG_TCG_INTERPRETER)
- const char *envval = getenv("DEBUG_TCG");
- if (envval) {
- qemu_set_log(strtol(envval, NULL, 0));
- }
-#endif
-
/* The current code uses uint8_t for tcg operations. */
tcg_debug_assert(tcg_op_defs_max <= UINT8_MAX);
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER
2022-07-05 8:36 [PATCH] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER Richard Henderson
2022-07-05 8:44 ` gaosong
2022-07-05 10:37 ` Alex Bennée
@ 2022-07-06 21:01 ` Philippe Mathieu-Daudé via
2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-07-06 21:01 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: Song Gao
On 5/7/22 10:36, Richard Henderson wrote:
> There is nothing in this environment variable that cannot
> be done better with -d flags. There is nothing special
> about TCI that warrants this hack.
>
> Moreover, it does not compile -- remove it.
>
> Reported-by: Song Gao <gaosong@loongson.cn>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/tci/tcg-target.h | 5 -----
> tcg/tci/tcg-target.c.inc | 7 -------
> 2 files changed, 12 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-06 22:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-05 8:36 [PATCH] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER Richard Henderson
2022-07-05 8:44 ` gaosong
2022-07-05 10:37 ` Alex Bennée
2022-07-06 21:01 ` Philippe Mathieu-Daudé via
-- strict thread matches above, loose matches on Subject: below --
2022-07-05 10:59 [PULL 0/6] loongarch64 patch queue Richard Henderson
2022-07-05 10:59 ` [PATCH] tcg/tci: Remove CONFIG_DEBUG_TCG_INTERPRETER Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).