qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>
Subject: [PULL 01/14] tests: fix test-cutils leaks
Date: Tue,  5 Jul 2022 12:38:03 +0200	[thread overview]
Message-ID: <20220705103816.608166-2-thuth@redhat.com> (raw)
In-Reply-To: <20220705103816.608166-1-thuth@redhat.com>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Reported by ASAN.

Fixes commit cfb34489 ("cutils: add functions for IEC and SI prefixes").

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20220621083420.66365-1-marcandre.lureau@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/unit/test-cutils.c | 42 ++++++++++++++++++++++++++++++++--------
 1 file changed, 34 insertions(+), 8 deletions(-)

diff --git a/tests/unit/test-cutils.c b/tests/unit/test-cutils.c
index f5b780f012..86caddcf64 100644
--- a/tests/unit/test-cutils.c
+++ b/tests/unit/test-cutils.c
@@ -2452,18 +2452,44 @@ static void test_qemu_strtosz_metric(void)
 
 static void test_freq_to_str(void)
 {
-    g_assert_cmpstr(freq_to_str(999), ==, "999 Hz");
-    g_assert_cmpstr(freq_to_str(1000), ==, "1 KHz");
-    g_assert_cmpstr(freq_to_str(1010), ==, "1.01 KHz");
+    char *str;
+
+    str = freq_to_str(999);
+    g_assert_cmpstr(str, ==, "999 Hz");
+    g_free(str);
+
+    str = freq_to_str(1000);
+    g_assert_cmpstr(str, ==, "1 KHz");
+    g_free(str);
+
+    str = freq_to_str(1010);
+    g_assert_cmpstr(str, ==, "1.01 KHz");
+    g_free(str);
 }
 
 static void test_size_to_str(void)
 {
-    g_assert_cmpstr(size_to_str(0), ==, "0 B");
-    g_assert_cmpstr(size_to_str(1), ==, "1 B");
-    g_assert_cmpstr(size_to_str(1016), ==, "0.992 KiB");
-    g_assert_cmpstr(size_to_str(1024), ==, "1 KiB");
-    g_assert_cmpstr(size_to_str(512ull << 20), ==, "512 MiB");
+    char *str;
+
+    str = size_to_str(0);
+    g_assert_cmpstr(str, ==, "0 B");
+    g_free(str);
+
+    str = size_to_str(1);
+    g_assert_cmpstr(str, ==, "1 B");
+    g_free(str);
+
+    str = size_to_str(1016);
+    g_assert_cmpstr(str, ==, "0.992 KiB");
+    g_free(str);
+
+    str = size_to_str(1024);
+    g_assert_cmpstr(str, ==, "1 KiB");
+    g_free(str);
+
+    str = size_to_str(512ull << 20);
+    g_assert_cmpstr(str, ==, "512 MiB");
+    g_free(str);
 }
 
 static void test_iec_binary_prefix(void)
-- 
2.31.1



  reply	other threads:[~2022-07-05 10:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 10:38 [PULL 00/14] Testing and misc patches Thomas Huth
2022-07-05 10:38 ` Thomas Huth [this message]
2022-07-05 10:38 ` [PULL 02/14] tests/fp: Do not build softfloat3 tests if TCG is disabled Thomas Huth
2022-07-05 10:38 ` [PULL 03/14] gitlab: normalize indentation in edk2/opensbi rules Thomas Huth
2022-07-05 10:38 ` [PULL 04/14] gitlab: tweak comments in edk2/opensbi jobs Thomas Huth
2022-07-05 10:38 ` [PULL 05/14] gitlab: honour QEMU_CI variable " Thomas Huth
2022-07-05 10:38 ` [PULL 06/14] gitlab-ci: Extend timeout for ubuntu-20.04-s390x-all to 75m Thomas Huth
2022-07-05 10:38 ` [PULL 07/14] tests: wait max 120 seconds for migration test status changes Thomas Huth
2022-07-05 10:38 ` [PULL 08/14] tests: wait for migration completion before looking for STOP event Thomas Huth
2022-07-05 10:38 ` [PULL 09/14] tests: increase migration test converge downtime to 30 seconds Thomas Huth
2022-07-05 10:38 ` [PULL 10/14] tests: use consistent bandwidth/downtime limits in migration tests Thomas Huth
2022-07-05 10:38 ` [PULL 11/14] disas: Remove libvixl disassembler Thomas Huth
2022-07-05 10:38 ` [PULL 12/14] po: add ukrainian translation Thomas Huth
2022-07-05 10:38 ` [PULL 13/14] meson.build: Require a recent version of libpng Thomas Huth
2022-07-05 10:38 ` [PULL 14/14] include/qemu/host-utils: Remove unused code in the *_overflow wrappers Thomas Huth
2022-07-05 16:43 ` [PULL 00/14] Testing and misc patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220705103816.608166-2-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).