qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alberto Faria <afaria@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Beniamino Galvani" <b.galvani@gmail.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Vladimir Sementsov-Ogievskiy" <v.sementsov-og@mail.ru>,
	"Eric Blake" <eblake@redhat.com>,
	"Niek Linnenbank" <nieklinnenbank@gmail.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	qemu-ppc@nongnu.org, "Fam Zheng" <fam@euphon.net>,
	"Jeff Cody" <codyprime@gmail.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Joel Stanley" <joel@jms.id.au>,
	"Bin Meng" <bin.meng@windriver.com>,
	"Emanuele Giuseppe Esposito" <eesposit@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	qemu-riscv@nongnu.org, "Greg Kurz" <groug@kaod.org>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Hanna Reitz" <hreitz@redhat.com>,
	qemu-block@nongnu.org, "Denis V. Lunev" <den@openvz.org>,
	qemu-arm@nongnu.org, "Alberto Faria" <afaria@redhat.com>
Subject: [PATCH v2 00/18] Make block-backend-io.h API more consistent
Date: Tue,  5 Jul 2022 17:15:08 +0100	[thread overview]
Message-ID: <20220705161527.1054072-1-afaria@redhat.com> (raw)

Adjust existing pairs of non-coroutine and coroutine functions to share
the same calling convention, and add non-coroutine/coroutine
counterparts where they don't exist.

Also make the non-coroutine versions generated_co_wrappers.

This series sits on top of "[PATCH v5 00/10] Implement
bdrv_{pread,pwrite,pwrite_sync,pwrite_zeroes}() using
generated_co_wrapper":

    https://lore.kernel.org/qemu-devel/20220609152744.3891847-1-afaria@redhat.com/

Based-on: <20220609152744.3891847-1-afaria@redhat.com>

v2:
  - Avoid using variables named 'len' or similar to hold return values
    from blk_{pread,pwrite}(), as they don't return a length anymore.
  - Drop variables in_ret and out_ret in qemu-img.c:img_dd().
  - Initialize buf in test_sync_op_blk_pwritev_part().
  - Keep blk_co_copy_range() in the "I/O API functions" section of
    include/sysemu/block-backend-io.h.

Alberto Faria (18):
  block: Make blk_{pread,pwrite}() return 0 on success
  block: Add a 'flags' param to blk_pread()
  block: Change blk_{pread,pwrite}() param order
  block: Make 'bytes' param of blk_{pread,pwrite}() an int64_t
  block: Make blk_co_pwrite() take a const buffer
  block: Implement blk_{pread,pwrite}() using generated_co_wrapper
  block: Add blk_{preadv,pwritev}()
  block: Add blk_[co_]preadv_part()
  block: Export blk_pwritev_part() in block-backend-io.h
  block: Change blk_pwrite_compressed() param order
  block: Add blk_co_pwrite_compressed()
  block: Implement blk_pwrite_zeroes() using generated_co_wrapper
  block: Implement blk_pdiscard() using generated_co_wrapper
  block: Implement blk_flush() using generated_co_wrapper
  block: Add blk_co_ioctl()
  block: Add blk_co_truncate()
  block: Reorganize some declarations in block-backend-io.h
  block: Remove remaining unused symbols in coroutines.h

 block.c                           |  10 +-
 block/block-backend.c             | 150 ++++++++++++------------------
 block/commit.c                    |   4 +-
 block/coroutines.h                |  44 ---------
 block/crypto.c                    |   2 +-
 block/export/fuse.c               |   4 +-
 block/meson.build                 |   1 +
 block/parallels.c                 |   2 +-
 block/qcow.c                      |  14 +--
 block/qcow2.c                     |   4 +-
 block/qed.c                       |   8 +-
 block/vdi.c                       |   4 +-
 block/vhdx.c                      |  20 ++--
 block/vmdk.c                      |  10 +-
 block/vpc.c                       |  12 +--
 hw/arm/allwinner-h3.c             |   2 +-
 hw/arm/aspeed.c                   |   2 +-
 hw/block/block.c                  |   2 +-
 hw/block/fdc.c                    |  20 ++--
 hw/block/hd-geometry.c            |   2 +-
 hw/block/m25p80.c                 |   2 +-
 hw/block/nand.c                   |  47 +++++-----
 hw/block/onenand.c                |  32 +++----
 hw/block/pflash_cfi01.c           |   4 +-
 hw/block/pflash_cfi02.c           |   4 +-
 hw/ide/atapi.c                    |   4 +-
 hw/misc/mac_via.c                 |   6 +-
 hw/misc/sifive_u_otp.c            |  14 +--
 hw/nvram/eeprom_at24c.c           |   8 +-
 hw/nvram/spapr_nvram.c            |  16 ++--
 hw/nvram/xlnx-bbram.c             |   4 +-
 hw/nvram/xlnx-efuse.c             |   4 +-
 hw/ppc/pnv_pnor.c                 |   6 +-
 hw/sd/sd.c                        |   4 +-
 include/sysemu/block-backend-io.h |  97 +++++++++++--------
 migration/block.c                 |   8 +-
 nbd/server.c                      |   8 +-
 qemu-img.c                        |  41 ++++----
 qemu-io-cmds.c                    |  20 ++--
 tests/unit/test-block-iothread.c  | 141 ++++++++++++++++++++++++++--
 40 files changed, 431 insertions(+), 356 deletions(-)

-- 
2.36.1



             reply	other threads:[~2022-07-05 16:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 16:15 Alberto Faria [this message]
2022-07-05 16:15 ` [PATCH v2 01/18] block: Make blk_{pread, pwrite}() return 0 on success Alberto Faria
2022-07-06  8:37   ` [PATCH v2 01/18] block: Make blk_{pread,pwrite}() " Hanna Reitz
2022-07-05 16:15 ` [PATCH v2 02/18] block: Add a 'flags' param to blk_pread() Alberto Faria
2022-07-05 16:15 ` [PATCH v2 03/18] block: Change blk_{pread,pwrite}() param order Alberto Faria
2022-07-05 16:15 ` [PATCH v2 04/18] block: Make 'bytes' param of blk_{pread, pwrite}() an int64_t Alberto Faria
2022-07-05 16:15 ` [PATCH v2 05/18] block: Make blk_co_pwrite() take a const buffer Alberto Faria
2022-07-05 16:15 ` [PATCH v2 06/18] block: Implement blk_{pread, pwrite}() using generated_co_wrapper Alberto Faria
2022-07-05 16:15 ` [PATCH v2 07/18] block: Add blk_{preadv,pwritev}() Alberto Faria
2022-07-05 16:15 ` [PATCH v2 08/18] block: Add blk_[co_]preadv_part() Alberto Faria
2022-07-05 16:15 ` [PATCH v2 09/18] block: Export blk_pwritev_part() in block-backend-io.h Alberto Faria
2022-07-05 16:15 ` [PATCH v2 10/18] block: Change blk_pwrite_compressed() param order Alberto Faria
2022-07-05 16:15 ` [PATCH v2 11/18] block: Add blk_co_pwrite_compressed() Alberto Faria
2022-07-05 16:15 ` [PATCH v2 12/18] block: Implement blk_pwrite_zeroes() using generated_co_wrapper Alberto Faria
2022-07-05 16:15 ` [PATCH v2 13/18] block: Implement blk_pdiscard() " Alberto Faria
2022-07-05 16:15 ` [PATCH v2 14/18] block: Implement blk_flush() " Alberto Faria
2022-07-05 16:15 ` [PATCH v2 15/18] block: Add blk_co_ioctl() Alberto Faria
2022-07-05 16:15 ` [PATCH v2 16/18] block: Add blk_co_truncate() Alberto Faria
2022-07-05 16:15 ` [PATCH v2 17/18] block: Reorganize some declarations in block-backend-io.h Alberto Faria
2022-07-06  9:25   ` Hanna Reitz
2022-07-05 16:15 ` [PATCH v2 18/18] block: Remove remaining unused symbols in coroutines.h Alberto Faria
2022-07-06  9:45 ` [PATCH v2 00/18] Make block-backend-io.h API more consistent Hanna Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220705161527.1054072-1-afaria@redhat.com \
    --to=afaria@redhat.com \
    --cc=alistair@alistair23.me \
    --cc=andrew@aj.id.au \
    --cc=b.galvani@gmail.com \
    --cc=bin.meng@windriver.com \
    --cc=clg@kaod.org \
    --cc=codyprime@gmail.com \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=den@openvz.org \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=eesposit@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=groug@kaod.org \
    --cc=hreitz@redhat.com \
    --cc=joel@jms.id.au \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=nieklinnenbank@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    --cc=v.sementsov-og@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).