From: Greg Kurz <groug@kaod.org>
To: Thomas Huth <thuth@redhat.com>
Cc: "Cédric Le Goater" <clg@kaod.org>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
qemu-devel@nongnu.org,
"David Gibson" <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org
Subject: Re: [PATCH] target/ppc/cpu-models: Remove the "default" CPU alias
Date: Tue, 5 Jul 2022 17:47:09 +0200 [thread overview]
Message-ID: <20220705174709.0c584bf0@bahia> (raw)
In-Reply-To: <20220705151030.662140-1-thuth@redhat.com>
On Tue, 5 Jul 2022 17:10:30 +0200
Thomas Huth <thuth@redhat.com> wrote:
> QEMU emulates a *lot* of PowerPC-based machines - having a CPU
> that is named "default" and cannot be used with most of those
> machines sounds just wrong. Thus let's remove this old and confusing
> alias now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
Good riddance !
Reviewed-by: Greg Kurz <groug@kaod.org>
> target/ppc/cpu-models.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c
> index 976be5e0d1..2667440f73 100644
> --- a/target/ppc/cpu-models.c
> +++ b/target/ppc/cpu-models.c
> @@ -918,6 +918,6 @@ PowerPCCPUAlias ppc_cpu_aliases[] = {
> #endif
> { "ppc32", "604" },
> { "ppc", "604" },
> - { "default", "604" },
> +
> { NULL, NULL }
> };
next prev parent reply other threads:[~2022-07-05 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 15:10 [PATCH] target/ppc/cpu-models: Remove the "default" CPU alias Thomas Huth
2022-07-05 15:47 ` Greg Kurz [this message]
2022-07-05 15:48 ` Cédric Le Goater
2022-07-05 15:53 ` Peter Maydell
2022-07-06 6:31 ` Thomas Huth
2022-07-06 13:40 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705174709.0c584bf0@bahia \
--to=groug@kaod.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).