From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EC3BC43334 for ; Tue, 5 Jul 2022 15:49:35 +0000 (UTC) Received: from localhost ([::1]:49886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8knu-0006zi-3Z for qemu-devel@archiver.kernel.org; Tue, 05 Jul 2022 11:49:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8km2-0004Be-1A for qemu-devel@nongnu.org; Tue, 05 Jul 2022 11:47:38 -0400 Received: from us-smtp-delivery-44.mimecast.com ([205.139.111.44]:24081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8km0-00010j-JQ for qemu-devel@nongnu.org; Tue, 05 Jul 2022 11:47:37 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-530-LGmAI1_rOHesgANyIZgdOQ-1; Tue, 05 Jul 2022 11:47:12 -0400 X-MC-Unique: LGmAI1_rOHesgANyIZgdOQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92545803524; Tue, 5 Jul 2022 15:47:11 +0000 (UTC) Received: from bahia (unknown [10.39.194.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6E2AC9D7F; Tue, 5 Jul 2022 15:47:10 +0000 (UTC) Date: Tue, 5 Jul 2022 17:47:09 +0200 From: Greg Kurz To: Thomas Huth Cc: =?UTF-8?B?Q8OpZHJpYw==?= Le Goater , Daniel Henrique Barboza , qemu-devel@nongnu.org, David Gibson , qemu-ppc@nongnu.org Subject: Re: [PATCH] target/ppc/cpu-models: Remove the "default" CPU alias Message-ID: <20220705174709.0c584bf0@bahia> In-Reply-To: <20220705151030.662140-1-thuth@redhat.com> References: <20220705151030.662140-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Received-SPF: softfail client-ip=205.139.111.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 5 Jul 2022 17:10:30 +0200 Thomas Huth wrote: > QEMU emulates a *lot* of PowerPC-based machines - having a CPU > that is named "default" and cannot be used with most of those > machines sounds just wrong. Thus let's remove this old and confusing > alias now. > > Signed-off-by: Thomas Huth > --- Good riddance ! Reviewed-by: Greg Kurz > target/ppc/cpu-models.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c > index 976be5e0d1..2667440f73 100644 > --- a/target/ppc/cpu-models.c > +++ b/target/ppc/cpu-models.c > @@ -918,6 +918,6 @@ PowerPCCPUAlias ppc_cpu_aliases[] = { > #endif > { "ppc32", "604" }, > { "ppc", "604" }, > - { "default", "604" }, > + > { NULL, NULL } > };