qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org
Subject: [PATCH v5 23/45] target/arm: Implement SME ADDHA, ADDVA
Date: Wed,  6 Jul 2022 13:53:49 +0530	[thread overview]
Message-ID: <20220706082411.1664825-24-richard.henderson@linaro.org> (raw)
In-Reply-To: <20220706082411.1664825-1-richard.henderson@linaro.org>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
v4: Drop restrict.
---
 target/arm/helper-sme.h    |  5 +++
 target/arm/sme.decode      | 11 +++++
 target/arm/sme_helper.c    | 90 ++++++++++++++++++++++++++++++++++++++
 target/arm/translate-sme.c | 31 +++++++++++++
 4 files changed, 137 insertions(+)

diff --git a/target/arm/helper-sme.h b/target/arm/helper-sme.h
index 95f6e88bdd..753e9e624c 100644
--- a/target/arm/helper-sme.h
+++ b/target/arm/helper-sme.h
@@ -115,3 +115,8 @@ DEF_HELPER_FLAGS_5(sme_st1q_be_h_mte, TCG_CALL_NO_WG, void, env, ptr, ptr, tl, i
 DEF_HELPER_FLAGS_5(sme_st1q_le_h_mte, TCG_CALL_NO_WG, void, env, ptr, ptr, tl, i32)
 DEF_HELPER_FLAGS_5(sme_st1q_be_v_mte, TCG_CALL_NO_WG, void, env, ptr, ptr, tl, i32)
 DEF_HELPER_FLAGS_5(sme_st1q_le_v_mte, TCG_CALL_NO_WG, void, env, ptr, ptr, tl, i32)
+
+DEF_HELPER_FLAGS_5(sme_addha_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_5(sme_addva_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_5(sme_addha_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32)
+DEF_HELPER_FLAGS_5(sme_addva_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32)
diff --git a/target/arm/sme.decode b/target/arm/sme.decode
index f1ebd857a5..8cb6c4053c 100644
--- a/target/arm/sme.decode
+++ b/target/arm/sme.decode
@@ -53,3 +53,14 @@ LDST1           1110000 111     st:1 rm:5 v:1 .. pg:3 rn:5 0 za_imm:4  \
 
 LDR             1110000 100 0 000000 .. 000 ..... 0 ....        @ldstr
 STR             1110000 100 1 000000 .. 000 ..... 0 ....        @ldstr
+
+### SME Add Vector to Array
+
+&adda           zad zn pm pn
+@adda_32        ........ .. ..... . pm:3 pn:3 zn:5 ... zad:2    &adda
+@adda_64        ........ .. ..... . pm:3 pn:3 zn:5 ..  zad:3    &adda
+
+ADDHA_s         11000000 10 01000 0 ... ... ..... 000 ..        @adda_32
+ADDVA_s         11000000 10 01000 1 ... ... ..... 000 ..        @adda_32
+ADDHA_d         11000000 11 01000 0 ... ... ..... 00 ...        @adda_64
+ADDVA_d         11000000 11 01000 1 ... ... ..... 00 ...        @adda_64
diff --git a/target/arm/sme_helper.c b/target/arm/sme_helper.c
index e8895143c1..10b7c1ad68 100644
--- a/target/arm/sme_helper.c
+++ b/target/arm/sme_helper.c
@@ -828,3 +828,93 @@ DO_ST(q, _be, MO_128)
 DO_ST(q, _le, MO_128)
 
 #undef DO_ST
+
+void HELPER(sme_addha_s)(void *vzda, void *vzn, void *vpn,
+                         void *vpm, uint32_t desc)
+{
+    intptr_t row, col, oprsz = simd_oprsz(desc) / 4;
+    uint64_t *pn = vpn, *pm = vpm;
+    uint32_t *zda = vzda, *zn = vzn;
+
+    for (row = 0; row < oprsz; ) {
+        uint64_t pa = pn[row >> 4];
+        do {
+            if (pa & 1) {
+                for (col = 0; col < oprsz; ) {
+                    uint64_t pb = pm[col >> 4];
+                    do {
+                        if (pb & 1) {
+                            zda[tile_vslice_index(row) + col] += zn[col];
+                        }
+                        pb >>= 4;
+                    } while (++col & 15);
+                }
+            }
+            pa >>= 4;
+        } while (++row & 15);
+    }
+}
+
+void HELPER(sme_addha_d)(void *vzda, void *vzn, void *vpn,
+                         void *vpm, uint32_t desc)
+{
+    intptr_t row, col, oprsz = simd_oprsz(desc) / 8;
+    uint8_t *pn = vpn, *pm = vpm;
+    uint64_t *zda = vzda, *zn = vzn;
+
+    for (row = 0; row < oprsz; ++row) {
+        if (pn[H1(row)] & 1) {
+            for (col = 0; col < oprsz; ++col) {
+                if (pm[H1(col)] & 1) {
+                    zda[tile_vslice_index(row) + col] += zn[col];
+                }
+            }
+        }
+    }
+}
+
+void HELPER(sme_addva_s)(void *vzda, void *vzn, void *vpn,
+                         void *vpm, uint32_t desc)
+{
+    intptr_t row, col, oprsz = simd_oprsz(desc) / 4;
+    uint64_t *pn = vpn, *pm = vpm;
+    uint32_t *zda = vzda, *zn = vzn;
+
+    for (row = 0; row < oprsz; ) {
+        uint64_t pa = pn[row >> 4];
+        do {
+            if (pa & 1) {
+                uint32_t zn_row = zn[row];
+                for (col = 0; col < oprsz; ) {
+                    uint64_t pb = pm[col >> 4];
+                    do {
+                        if (pb & 1) {
+                            zda[tile_vslice_index(row) + col] += zn_row;
+                        }
+                        pb >>= 4;
+                    } while (++col & 15);
+                }
+            }
+            pa >>= 4;
+        } while (++row & 15);
+    }
+}
+
+void HELPER(sme_addva_d)(void *vzda, void *vzn, void *vpn,
+                         void *vpm, uint32_t desc)
+{
+    intptr_t row, col, oprsz = simd_oprsz(desc) / 8;
+    uint8_t *pn = vpn, *pm = vpm;
+    uint64_t *zda = vzda, *zn = vzn;
+
+    for (row = 0; row < oprsz; ++row) {
+        if (pn[H1(row)] & 1) {
+            uint64_t zn_row = zn[row];
+            for (col = 0; col < oprsz; ++col) {
+                if (pm[H1(col)] & 1) {
+                    zda[tile_vslice_index(row) + col] += zn_row;
+                }
+            }
+        }
+    }
+}
diff --git a/target/arm/translate-sme.c b/target/arm/translate-sme.c
index 35c2644812..d3b9cdd5c4 100644
--- a/target/arm/translate-sme.c
+++ b/target/arm/translate-sme.c
@@ -267,3 +267,34 @@ static bool do_ldst_r(DisasContext *s, arg_ldstr *a, GenLdStR *fn)
 
 TRANS_FEAT(LDR, aa64_sme, do_ldst_r, a, gen_sve_ldr)
 TRANS_FEAT(STR, aa64_sme, do_ldst_r, a, gen_sve_str)
+
+static bool do_adda(DisasContext *s, arg_adda *a, MemOp esz,
+                    gen_helper_gvec_4 *fn)
+{
+    int svl = streaming_vec_reg_size(s);
+    uint32_t desc = simd_desc(svl, svl, 0);
+    TCGv_ptr za, zn, pn, pm;
+
+    if (!sme_smza_enabled_check(s)) {
+        return true;
+    }
+
+    /* Sum XZR+zad to find ZAd. */
+    za = get_tile_rowcol(s, esz, 31, a->zad, false);
+    zn = vec_full_reg_ptr(s, a->zn);
+    pn = pred_full_reg_ptr(s, a->pn);
+    pm = pred_full_reg_ptr(s, a->pm);
+
+    fn(za, zn, pn, pm, tcg_constant_i32(desc));
+
+    tcg_temp_free_ptr(za);
+    tcg_temp_free_ptr(zn);
+    tcg_temp_free_ptr(pn);
+    tcg_temp_free_ptr(pm);
+    return true;
+}
+
+TRANS_FEAT(ADDHA_s, aa64_sme, do_adda, a, MO_32, gen_helper_sme_addha_s)
+TRANS_FEAT(ADDVA_s, aa64_sme, do_adda, a, MO_32, gen_helper_sme_addva_s)
+TRANS_FEAT(ADDHA_d, aa64_sme_i16i64, do_adda, a, MO_64, gen_helper_sme_addha_d)
+TRANS_FEAT(ADDVA_d, aa64_sme_i16i64, do_adda, a, MO_64, gen_helper_sme_addva_d)
-- 
2.34.1



  parent reply	other threads:[~2022-07-06  9:16 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06  8:23 [PATCH v5 00/45] target/arm: Scalable Matrix Extension Richard Henderson
2022-07-06  8:23 ` [PATCH v5 01/45] target/arm: Handle SME in aarch64_cpu_dump_state Richard Henderson
2022-07-06  8:23 ` [PATCH v5 02/45] target/arm: Add infrastructure for disas_sme Richard Henderson
2022-07-06  8:23 ` [PATCH v5 03/45] target/arm: Trap non-streaming usage when Streaming SVE is active Richard Henderson
2022-07-06 16:14   ` Peter Maydell
2022-07-06  8:23 ` [PATCH v5 04/45] target/arm: Mark ADR as non-streaming Richard Henderson
2022-07-06  8:23 ` [PATCH v5 05/45] target/arm: Mark RDFFR, WRFFR, SETFFR " Richard Henderson
2022-07-06  8:23 ` [PATCH v5 06/45] target/arm: Mark BDEP, BEXT, BGRP, COMPACT, FEXPA, FTSSEL " Richard Henderson
2022-07-06  8:23 ` [PATCH v5 07/45] target/arm: Mark PMULL, FMMLA " Richard Henderson
2022-07-06 16:13   ` Peter Maydell
2022-07-06  8:23 ` [PATCH v5 08/45] target/arm: Mark FTSMUL, FTMAD, FADDA " Richard Henderson
2022-07-06  8:23 ` [PATCH v5 09/45] target/arm: Mark SMMLA, UMMLA, USMMLA " Richard Henderson
2022-07-06  8:23 ` [PATCH v5 10/45] target/arm: Mark string/histo/crypto " Richard Henderson
2022-07-06  8:23 ` [PATCH v5 11/45] target/arm: Mark gather/scatter load/store " Richard Henderson
2022-07-06  8:23 ` [PATCH v5 12/45] target/arm: Mark gather prefetch " Richard Henderson
2022-07-06  8:23 ` [PATCH v5 13/45] target/arm: Mark LDFF1 and LDNF1 " Richard Henderson
2022-07-06  8:23 ` [PATCH v5 14/45] target/arm: Mark LD1RO " Richard Henderson
2022-07-06  8:23 ` [PATCH v5 15/45] target/arm: Add SME enablement checks Richard Henderson
2022-07-06  8:23 ` [PATCH v5 16/45] target/arm: Handle SME in sve_access_check Richard Henderson
2022-07-06  8:23 ` [PATCH v5 17/45] target/arm: Implement SME RDSVL, ADDSVL, ADDSPL Richard Henderson
2022-07-06  8:23 ` [PATCH v5 18/45] target/arm: Implement SME ZERO Richard Henderson
2022-07-06  8:23 ` [PATCH v5 19/45] target/arm: Implement SME MOVA Richard Henderson
2022-07-06 16:47   ` Peter Maydell
2022-07-07  0:56     ` Richard Henderson
2022-07-06  8:23 ` [PATCH v5 20/45] target/arm: Implement SME LD1, ST1 Richard Henderson
2022-07-06 16:50   ` Peter Maydell
2022-07-06  8:23 ` [PATCH v5 21/45] target/arm: Export unpredicated ld/st from translate-sve.c Richard Henderson
2022-07-06  8:23 ` [PATCH v5 22/45] target/arm: Implement SME LDR, STR Richard Henderson
2022-07-06  8:23 ` Richard Henderson [this message]
2022-07-06 16:53   ` [PATCH v5 23/45] target/arm: Implement SME ADDHA, ADDVA Peter Maydell
2022-07-06  8:23 ` [PATCH v5 24/45] target/arm: Implement FMOPA, FMOPS (non-widening) Richard Henderson
2022-07-07  9:26   ` Peter Maydell
2022-07-06  8:23 ` [PATCH v5 25/45] target/arm: Implement BFMOPA, BFMOPS Richard Henderson
2022-07-07  9:42   ` Peter Maydell
2022-07-08 14:42     ` Richard Henderson
2022-07-06  8:23 ` [PATCH v5 26/45] target/arm: Implement FMOPA, FMOPS (widening) Richard Henderson
2022-07-07  9:50   ` Peter Maydell
2022-07-06  8:23 ` [PATCH v5 27/45] target/arm: Implement SME integer outer product Richard Henderson
2022-07-06  8:23 ` [PATCH v5 28/45] target/arm: Implement PSEL Richard Henderson
2022-07-06  8:23 ` [PATCH v5 29/45] target/arm: Implement REVD Richard Henderson
2022-07-06  8:23 ` [PATCH v5 30/45] target/arm: Implement SCLAMP, UCLAMP Richard Henderson
2022-07-06  8:23 ` [PATCH v5 31/45] target/arm: Reset streaming sve state on exception boundaries Richard Henderson
2022-07-06  8:23 ` [PATCH v5 32/45] target/arm: Enable SME for -cpu max Richard Henderson
2022-07-06  8:23 ` [PATCH v5 33/45] linux-user/aarch64: Clear tpidr2_el0 if CLONE_SETTLS Richard Henderson
2022-07-06  8:24 ` [PATCH v5 34/45] linux-user/aarch64: Reset PSTATE.SM on syscalls Richard Henderson
2022-07-06  8:24 ` [PATCH v5 35/45] linux-user/aarch64: Add SM bit to SVE signal context Richard Henderson
2022-07-06 16:54   ` Peter Maydell
2022-07-06  8:24 ` [PATCH v5 36/45] linux-user/aarch64: Tidy target_restore_sigframe error return Richard Henderson
2022-07-06  8:24 ` [PATCH v5 37/45] linux-user/aarch64: Do not allow duplicate or short sve records Richard Henderson
2022-07-06 16:55   ` Peter Maydell
2022-07-06  8:24 ` [PATCH v5 38/45] linux-user/aarch64: Verify extra record lock succeeded Richard Henderson
2022-07-06  8:24 ` [PATCH v5 39/45] linux-user/aarch64: Move sve record checks into restore Richard Henderson
2022-07-06  8:24 ` [PATCH v5 40/45] linux-user/aarch64: Implement SME signal handling Richard Henderson
2022-07-06  8:24 ` [PATCH v5 41/45] linux-user: Rename sve prctls Richard Henderson
2022-07-06  8:24 ` [PATCH v5 42/45] linux-user/aarch64: Implement PR_SME_GET_VL, PR_SME_SET_VL Richard Henderson
2022-07-06  8:24 ` [PATCH v5 43/45] target/arm: Only set ZEN in reset if SVE present Richard Henderson
2022-07-06  8:24 ` [PATCH v5 44/45] target/arm: Enable SME for user-only Richard Henderson
2022-07-06  8:24 ` [PATCH v5 45/45] linux-user/aarch64: Add SME related hwcap entries Richard Henderson
2022-07-07  9:52 ` [PATCH v5 00/45] target/arm: Scalable Matrix Extension Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220706082411.1664825-24-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).