From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: [PATCH v5 04/45] target/arm: Mark ADR as non-streaming
Date: Wed, 6 Jul 2022 13:53:30 +0530 [thread overview]
Message-ID: <20220706082411.1664825-5-richard.henderson@linaro.org> (raw)
In-Reply-To: <20220706082411.1664825-1-richard.henderson@linaro.org>
Mark ADR as a non-streaming instruction, which should trap
if full a64 support is not enabled in streaming mode.
Removing entries from sme-fa64.decode is an easy way to see
what remains to be done.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/translate.h | 7 +++++++
target/arm/sme-fa64.decode | 1 -
target/arm/translate-sve.c | 8 ++++----
3 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/target/arm/translate.h b/target/arm/translate.h
index cbc907c751..e2e619dab2 100644
--- a/target/arm/translate.h
+++ b/target/arm/translate.h
@@ -566,4 +566,11 @@ uint64_t asimd_imm_const(uint32_t imm, int cmode, int op);
static bool trans_##NAME(DisasContext *s, arg_##NAME *a) \
{ return dc_isar_feature(FEAT, s) && FUNC(s, __VA_ARGS__); }
+#define TRANS_FEAT_NONSTREAMING(NAME, FEAT, FUNC, ...) \
+ static bool trans_##NAME(DisasContext *s, arg_##NAME *a) \
+ { \
+ s->is_nonstreaming = true; \
+ return dc_isar_feature(FEAT, s) && FUNC(s, __VA_ARGS__); \
+ }
+
#endif /* TARGET_ARM_TRANSLATE_H */
diff --git a/target/arm/sme-fa64.decode b/target/arm/sme-fa64.decode
index 3d90837fc7..73c71abc46 100644
--- a/target/arm/sme-fa64.decode
+++ b/target/arm/sme-fa64.decode
@@ -59,7 +59,6 @@ FAIL 0001 1110 0111 1110 0000 00-- ---- ---- # FJCVTZS
# --11 1100 --1- ---- ---- ---- ---- --10 # Load/store FP register (register offset)
# --11 1101 ---- ---- ---- ---- ---- ---- # Load/store FP register (scaled imm)
-FAIL 0000 0100 --1- ---- 1010 ---- ---- ---- # ADR
FAIL 0000 0100 --1- ---- 1011 -0-- ---- ---- # FTSSEL, FEXPA
FAIL 0000 0101 --10 0001 100- ---- ---- ---- # COMPACT
FAIL 0010 0101 --01 100- 1111 000- ---0 ---- # RDFFR, RDFFRS
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index 62b5f3040c..5d1db0d3ff 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -1320,10 +1320,10 @@ static bool do_adr(DisasContext *s, arg_rrri *a, gen_helper_gvec_3 *fn)
return gen_gvec_ool_zzz(s, fn, a->rd, a->rn, a->rm, a->imm);
}
-TRANS_FEAT(ADR_p32, aa64_sve, do_adr, a, gen_helper_sve_adr_p32)
-TRANS_FEAT(ADR_p64, aa64_sve, do_adr, a, gen_helper_sve_adr_p64)
-TRANS_FEAT(ADR_s32, aa64_sve, do_adr, a, gen_helper_sve_adr_s32)
-TRANS_FEAT(ADR_u32, aa64_sve, do_adr, a, gen_helper_sve_adr_u32)
+TRANS_FEAT_NONSTREAMING(ADR_p32, aa64_sve, do_adr, a, gen_helper_sve_adr_p32)
+TRANS_FEAT_NONSTREAMING(ADR_p64, aa64_sve, do_adr, a, gen_helper_sve_adr_p64)
+TRANS_FEAT_NONSTREAMING(ADR_s32, aa64_sve, do_adr, a, gen_helper_sve_adr_s32)
+TRANS_FEAT_NONSTREAMING(ADR_u32, aa64_sve, do_adr, a, gen_helper_sve_adr_u32)
/*
*** SVE Integer Misc - Unpredicated Group
--
2.34.1
next prev parent reply other threads:[~2022-07-06 8:53 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 8:23 [PATCH v5 00/45] target/arm: Scalable Matrix Extension Richard Henderson
2022-07-06 8:23 ` [PATCH v5 01/45] target/arm: Handle SME in aarch64_cpu_dump_state Richard Henderson
2022-07-06 8:23 ` [PATCH v5 02/45] target/arm: Add infrastructure for disas_sme Richard Henderson
2022-07-06 8:23 ` [PATCH v5 03/45] target/arm: Trap non-streaming usage when Streaming SVE is active Richard Henderson
2022-07-06 16:14 ` Peter Maydell
2022-07-06 8:23 ` Richard Henderson [this message]
2022-07-06 8:23 ` [PATCH v5 05/45] target/arm: Mark RDFFR, WRFFR, SETFFR as non-streaming Richard Henderson
2022-07-06 8:23 ` [PATCH v5 06/45] target/arm: Mark BDEP, BEXT, BGRP, COMPACT, FEXPA, FTSSEL " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 07/45] target/arm: Mark PMULL, FMMLA " Richard Henderson
2022-07-06 16:13 ` Peter Maydell
2022-07-06 8:23 ` [PATCH v5 08/45] target/arm: Mark FTSMUL, FTMAD, FADDA " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 09/45] target/arm: Mark SMMLA, UMMLA, USMMLA " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 10/45] target/arm: Mark string/histo/crypto " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 11/45] target/arm: Mark gather/scatter load/store " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 12/45] target/arm: Mark gather prefetch " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 13/45] target/arm: Mark LDFF1 and LDNF1 " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 14/45] target/arm: Mark LD1RO " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 15/45] target/arm: Add SME enablement checks Richard Henderson
2022-07-06 8:23 ` [PATCH v5 16/45] target/arm: Handle SME in sve_access_check Richard Henderson
2022-07-06 8:23 ` [PATCH v5 17/45] target/arm: Implement SME RDSVL, ADDSVL, ADDSPL Richard Henderson
2022-07-06 8:23 ` [PATCH v5 18/45] target/arm: Implement SME ZERO Richard Henderson
2022-07-06 8:23 ` [PATCH v5 19/45] target/arm: Implement SME MOVA Richard Henderson
2022-07-06 16:47 ` Peter Maydell
2022-07-07 0:56 ` Richard Henderson
2022-07-06 8:23 ` [PATCH v5 20/45] target/arm: Implement SME LD1, ST1 Richard Henderson
2022-07-06 16:50 ` Peter Maydell
2022-07-06 8:23 ` [PATCH v5 21/45] target/arm: Export unpredicated ld/st from translate-sve.c Richard Henderson
2022-07-06 8:23 ` [PATCH v5 22/45] target/arm: Implement SME LDR, STR Richard Henderson
2022-07-06 8:23 ` [PATCH v5 23/45] target/arm: Implement SME ADDHA, ADDVA Richard Henderson
2022-07-06 16:53 ` Peter Maydell
2022-07-06 8:23 ` [PATCH v5 24/45] target/arm: Implement FMOPA, FMOPS (non-widening) Richard Henderson
2022-07-07 9:26 ` Peter Maydell
2022-07-06 8:23 ` [PATCH v5 25/45] target/arm: Implement BFMOPA, BFMOPS Richard Henderson
2022-07-07 9:42 ` Peter Maydell
2022-07-08 14:42 ` Richard Henderson
2022-07-06 8:23 ` [PATCH v5 26/45] target/arm: Implement FMOPA, FMOPS (widening) Richard Henderson
2022-07-07 9:50 ` Peter Maydell
2022-07-06 8:23 ` [PATCH v5 27/45] target/arm: Implement SME integer outer product Richard Henderson
2022-07-06 8:23 ` [PATCH v5 28/45] target/arm: Implement PSEL Richard Henderson
2022-07-06 8:23 ` [PATCH v5 29/45] target/arm: Implement REVD Richard Henderson
2022-07-06 8:23 ` [PATCH v5 30/45] target/arm: Implement SCLAMP, UCLAMP Richard Henderson
2022-07-06 8:23 ` [PATCH v5 31/45] target/arm: Reset streaming sve state on exception boundaries Richard Henderson
2022-07-06 8:23 ` [PATCH v5 32/45] target/arm: Enable SME for -cpu max Richard Henderson
2022-07-06 8:23 ` [PATCH v5 33/45] linux-user/aarch64: Clear tpidr2_el0 if CLONE_SETTLS Richard Henderson
2022-07-06 8:24 ` [PATCH v5 34/45] linux-user/aarch64: Reset PSTATE.SM on syscalls Richard Henderson
2022-07-06 8:24 ` [PATCH v5 35/45] linux-user/aarch64: Add SM bit to SVE signal context Richard Henderson
2022-07-06 16:54 ` Peter Maydell
2022-07-06 8:24 ` [PATCH v5 36/45] linux-user/aarch64: Tidy target_restore_sigframe error return Richard Henderson
2022-07-06 8:24 ` [PATCH v5 37/45] linux-user/aarch64: Do not allow duplicate or short sve records Richard Henderson
2022-07-06 16:55 ` Peter Maydell
2022-07-06 8:24 ` [PATCH v5 38/45] linux-user/aarch64: Verify extra record lock succeeded Richard Henderson
2022-07-06 8:24 ` [PATCH v5 39/45] linux-user/aarch64: Move sve record checks into restore Richard Henderson
2022-07-06 8:24 ` [PATCH v5 40/45] linux-user/aarch64: Implement SME signal handling Richard Henderson
2022-07-06 8:24 ` [PATCH v5 41/45] linux-user: Rename sve prctls Richard Henderson
2022-07-06 8:24 ` [PATCH v5 42/45] linux-user/aarch64: Implement PR_SME_GET_VL, PR_SME_SET_VL Richard Henderson
2022-07-06 8:24 ` [PATCH v5 43/45] target/arm: Only set ZEN in reset if SVE present Richard Henderson
2022-07-06 8:24 ` [PATCH v5 44/45] target/arm: Enable SME for user-only Richard Henderson
2022-07-06 8:24 ` [PATCH v5 45/45] linux-user/aarch64: Add SME related hwcap entries Richard Henderson
2022-07-07 9:52 ` [PATCH v5 00/45] target/arm: Scalable Matrix Extension Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706082411.1664825-5-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).