From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: [PATCH v5 08/45] target/arm: Mark FTSMUL, FTMAD, FADDA as non-streaming
Date: Wed, 6 Jul 2022 13:53:34 +0530 [thread overview]
Message-ID: <20220706082411.1664825-9-richard.henderson@linaro.org> (raw)
In-Reply-To: <20220706082411.1664825-1-richard.henderson@linaro.org>
Mark these as a non-streaming instructions, which should trap
if full a64 support is not enabled in streaming mode.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/sme-fa64.decode | 3 ---
target/arm/translate-sve.c | 15 +++++++++++----
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/target/arm/sme-fa64.decode b/target/arm/sme-fa64.decode
index 4ff2df82e5..b5eaa2d0fa 100644
--- a/target/arm/sme-fa64.decode
+++ b/target/arm/sme-fa64.decode
@@ -59,9 +59,6 @@ FAIL 0001 1110 0111 1110 0000 00-- ---- ---- # FJCVTZS
# --11 1100 --1- ---- ---- ---- ---- --10 # Load/store FP register (register offset)
# --11 1101 ---- ---- ---- ---- ---- ---- # Load/store FP register (scaled imm)
-FAIL 0110 0101 --0- ---- 0000 11-- ---- ---- # FTSMUL
-FAIL 0110 0101 --01 0--- 100- ---- ---- ---- # FTMAD
-FAIL 0110 0101 --01 1--- 001- ---- ---- ---- # FADDA
FAIL 0100 0101 --0- ---- 1001 10-- ---- ---- # SMMLA, UMMLA, USMMLA
FAIL 0100 0101 --1- ---- 1--- ---- ---- ---- # SVE2 string/histo/crypto instructions
FAIL 1000 010- -00- ---- 10-- ---- ---- ---- # SVE2 32-bit gather NT load (vector+scalar)
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index 4ff2102fc8..d5aad53923 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -3861,9 +3861,9 @@ static gen_helper_gvec_3_ptr * const ftmad_fns[4] = {
NULL, gen_helper_sve_ftmad_h,
gen_helper_sve_ftmad_s, gen_helper_sve_ftmad_d,
};
-TRANS_FEAT(FTMAD, aa64_sve, gen_gvec_fpst_zzz,
- ftmad_fns[a->esz], a->rd, a->rn, a->rm, a->imm,
- a->esz == MO_16 ? FPST_FPCR_F16 : FPST_FPCR)
+TRANS_FEAT_NONSTREAMING(FTMAD, aa64_sve, gen_gvec_fpst_zzz,
+ ftmad_fns[a->esz], a->rd, a->rn, a->rm, a->imm,
+ a->esz == MO_16 ? FPST_FPCR_F16 : FPST_FPCR)
/*
*** SVE Floating Point Accumulating Reduction Group
@@ -3886,6 +3886,7 @@ static bool trans_FADDA(DisasContext *s, arg_rprr_esz *a)
if (a->esz == 0 || !dc_isar_feature(aa64_sve, s)) {
return false;
}
+ s->is_nonstreaming = true;
if (!sve_access_check(s)) {
return true;
}
@@ -3923,12 +3924,18 @@ static bool trans_FADDA(DisasContext *s, arg_rprr_esz *a)
DO_FP3(FADD_zzz, fadd)
DO_FP3(FSUB_zzz, fsub)
DO_FP3(FMUL_zzz, fmul)
-DO_FP3(FTSMUL, ftsmul)
DO_FP3(FRECPS, recps)
DO_FP3(FRSQRTS, rsqrts)
#undef DO_FP3
+static gen_helper_gvec_3_ptr * const ftsmul_fns[4] = {
+ NULL, gen_helper_gvec_ftsmul_h,
+ gen_helper_gvec_ftsmul_s, gen_helper_gvec_ftsmul_d
+};
+TRANS_FEAT_NONSTREAMING(FTSMUL, aa64_sve, gen_gvec_fpst_arg_zzz,
+ ftsmul_fns[a->esz], a, 0)
+
/*
*** SVE Floating Point Arithmetic - Predicated Group
*/
--
2.34.1
next prev parent reply other threads:[~2022-07-06 8:51 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 8:23 [PATCH v5 00/45] target/arm: Scalable Matrix Extension Richard Henderson
2022-07-06 8:23 ` [PATCH v5 01/45] target/arm: Handle SME in aarch64_cpu_dump_state Richard Henderson
2022-07-06 8:23 ` [PATCH v5 02/45] target/arm: Add infrastructure for disas_sme Richard Henderson
2022-07-06 8:23 ` [PATCH v5 03/45] target/arm: Trap non-streaming usage when Streaming SVE is active Richard Henderson
2022-07-06 16:14 ` Peter Maydell
2022-07-06 8:23 ` [PATCH v5 04/45] target/arm: Mark ADR as non-streaming Richard Henderson
2022-07-06 8:23 ` [PATCH v5 05/45] target/arm: Mark RDFFR, WRFFR, SETFFR " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 06/45] target/arm: Mark BDEP, BEXT, BGRP, COMPACT, FEXPA, FTSSEL " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 07/45] target/arm: Mark PMULL, FMMLA " Richard Henderson
2022-07-06 16:13 ` Peter Maydell
2022-07-06 8:23 ` Richard Henderson [this message]
2022-07-06 8:23 ` [PATCH v5 09/45] target/arm: Mark SMMLA, UMMLA, USMMLA " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 10/45] target/arm: Mark string/histo/crypto " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 11/45] target/arm: Mark gather/scatter load/store " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 12/45] target/arm: Mark gather prefetch " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 13/45] target/arm: Mark LDFF1 and LDNF1 " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 14/45] target/arm: Mark LD1RO " Richard Henderson
2022-07-06 8:23 ` [PATCH v5 15/45] target/arm: Add SME enablement checks Richard Henderson
2022-07-06 8:23 ` [PATCH v5 16/45] target/arm: Handle SME in sve_access_check Richard Henderson
2022-07-06 8:23 ` [PATCH v5 17/45] target/arm: Implement SME RDSVL, ADDSVL, ADDSPL Richard Henderson
2022-07-06 8:23 ` [PATCH v5 18/45] target/arm: Implement SME ZERO Richard Henderson
2022-07-06 8:23 ` [PATCH v5 19/45] target/arm: Implement SME MOVA Richard Henderson
2022-07-06 16:47 ` Peter Maydell
2022-07-07 0:56 ` Richard Henderson
2022-07-06 8:23 ` [PATCH v5 20/45] target/arm: Implement SME LD1, ST1 Richard Henderson
2022-07-06 16:50 ` Peter Maydell
2022-07-06 8:23 ` [PATCH v5 21/45] target/arm: Export unpredicated ld/st from translate-sve.c Richard Henderson
2022-07-06 8:23 ` [PATCH v5 22/45] target/arm: Implement SME LDR, STR Richard Henderson
2022-07-06 8:23 ` [PATCH v5 23/45] target/arm: Implement SME ADDHA, ADDVA Richard Henderson
2022-07-06 16:53 ` Peter Maydell
2022-07-06 8:23 ` [PATCH v5 24/45] target/arm: Implement FMOPA, FMOPS (non-widening) Richard Henderson
2022-07-07 9:26 ` Peter Maydell
2022-07-06 8:23 ` [PATCH v5 25/45] target/arm: Implement BFMOPA, BFMOPS Richard Henderson
2022-07-07 9:42 ` Peter Maydell
2022-07-08 14:42 ` Richard Henderson
2022-07-06 8:23 ` [PATCH v5 26/45] target/arm: Implement FMOPA, FMOPS (widening) Richard Henderson
2022-07-07 9:50 ` Peter Maydell
2022-07-06 8:23 ` [PATCH v5 27/45] target/arm: Implement SME integer outer product Richard Henderson
2022-07-06 8:23 ` [PATCH v5 28/45] target/arm: Implement PSEL Richard Henderson
2022-07-06 8:23 ` [PATCH v5 29/45] target/arm: Implement REVD Richard Henderson
2022-07-06 8:23 ` [PATCH v5 30/45] target/arm: Implement SCLAMP, UCLAMP Richard Henderson
2022-07-06 8:23 ` [PATCH v5 31/45] target/arm: Reset streaming sve state on exception boundaries Richard Henderson
2022-07-06 8:23 ` [PATCH v5 32/45] target/arm: Enable SME for -cpu max Richard Henderson
2022-07-06 8:23 ` [PATCH v5 33/45] linux-user/aarch64: Clear tpidr2_el0 if CLONE_SETTLS Richard Henderson
2022-07-06 8:24 ` [PATCH v5 34/45] linux-user/aarch64: Reset PSTATE.SM on syscalls Richard Henderson
2022-07-06 8:24 ` [PATCH v5 35/45] linux-user/aarch64: Add SM bit to SVE signal context Richard Henderson
2022-07-06 16:54 ` Peter Maydell
2022-07-06 8:24 ` [PATCH v5 36/45] linux-user/aarch64: Tidy target_restore_sigframe error return Richard Henderson
2022-07-06 8:24 ` [PATCH v5 37/45] linux-user/aarch64: Do not allow duplicate or short sve records Richard Henderson
2022-07-06 16:55 ` Peter Maydell
2022-07-06 8:24 ` [PATCH v5 38/45] linux-user/aarch64: Verify extra record lock succeeded Richard Henderson
2022-07-06 8:24 ` [PATCH v5 39/45] linux-user/aarch64: Move sve record checks into restore Richard Henderson
2022-07-06 8:24 ` [PATCH v5 40/45] linux-user/aarch64: Implement SME signal handling Richard Henderson
2022-07-06 8:24 ` [PATCH v5 41/45] linux-user: Rename sve prctls Richard Henderson
2022-07-06 8:24 ` [PATCH v5 42/45] linux-user/aarch64: Implement PR_SME_GET_VL, PR_SME_SET_VL Richard Henderson
2022-07-06 8:24 ` [PATCH v5 43/45] target/arm: Only set ZEN in reset if SVE present Richard Henderson
2022-07-06 8:24 ` [PATCH v5 44/45] target/arm: Enable SME for user-only Richard Henderson
2022-07-06 8:24 ` [PATCH v5 45/45] linux-user/aarch64: Add SME related hwcap entries Richard Henderson
2022-07-07 9:52 ` [PATCH v5 00/45] target/arm: Scalable Matrix Extension Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706082411.1664825-9-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).