qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Liuxiangdong <liuxiangdong5@huawei.com>,
	Markus Armbruster <armbru@redhat.com>,
	Harpreet Singh Anand <hanand@xilinx.com>,
	Eric Blake <eblake@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	Parav Pandit <parav@mellanox.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Gautam Dawar <gdawar@xilinx.com>, Eli Cohen <eli@mellanox.com>,
	"Gonglei (Arei)" <arei.gonglei@huawei.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>,
	"Michael S. Tsirkin" <mst@redhat.com>, Cindy Lu <lulu@redhat.com>,
	Jason Wang <jasowang@redhat.com>
Subject: [RFC PATCH v9 04/23] vhost: Get vring base from vq, not svq
Date: Wed,  6 Jul 2022 20:39:49 +0200	[thread overview]
Message-ID: <20220706184008.1649478-5-eperezma@redhat.com> (raw)
In-Reply-To: <20220706184008.1649478-1-eperezma@redhat.com>

The used idx used to match with this, but it will not match from the
moment we introduce svq_inject. Rewind all the descriptors not used by
vdpa device and get the vq state properly.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
 include/hw/virtio/virtio.h | 1 +
 hw/virtio/vhost-vdpa.c     | 7 +++----
 hw/virtio/virtio.c         | 5 +++++
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index db1c0ddf6b..4b51ab9d06 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -302,6 +302,7 @@ hwaddr virtio_queue_get_desc_size(VirtIODevice *vdev, int n);
 hwaddr virtio_queue_get_avail_size(VirtIODevice *vdev, int n);
 hwaddr virtio_queue_get_used_size(VirtIODevice *vdev, int n);
 unsigned int virtio_queue_get_last_avail_idx(VirtIODevice *vdev, int n);
+unsigned int virtio_queue_get_in_use(const VirtQueue *vq);
 void virtio_queue_set_last_avail_idx(VirtIODevice *vdev, int n,
                                      unsigned int idx);
 void virtio_queue_restore_last_avail_idx(VirtIODevice *vdev, int n);
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 2ee8009594..de76128030 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -1189,12 +1189,10 @@ static int vhost_vdpa_get_vring_base(struct vhost_dev *dev,
                                        struct vhost_vring_state *ring)
 {
     struct vhost_vdpa *v = dev->opaque;
-    int vdpa_idx = ring->index - dev->vq_index;
     int ret;
 
     if (v->shadow_vqs_enabled) {
-        VhostShadowVirtqueue *svq = g_ptr_array_index(v->shadow_vqs, vdpa_idx);
-
+        const VirtQueue *vq = virtio_get_queue(dev->vdev, ring->index);
         /*
          * Setting base as last used idx, so destination will see as available
          * all the entries that the device did not use, including the in-flight
@@ -1203,7 +1201,8 @@ static int vhost_vdpa_get_vring_base(struct vhost_dev *dev,
          * TODO: This is ok for networking, but other kinds of devices might
          * have problems with these retransmissions.
          */
-        ring->num = svq->last_used_idx;
+        ring->num = virtio_queue_get_last_avail_idx(dev->vdev, ring->index) -
+                    virtio_queue_get_in_use(vq);
         return 0;
     }
 
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 5d607aeaa0..e02656f7a2 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -3420,6 +3420,11 @@ unsigned int virtio_queue_get_last_avail_idx(VirtIODevice *vdev, int n)
     }
 }
 
+unsigned int virtio_queue_get_in_use(const VirtQueue *vq)
+{
+    return vq->inuse;
+}
+
 static void virtio_queue_packed_set_last_avail_idx(VirtIODevice *vdev,
                                                    int n, unsigned int idx)
 {
-- 
2.31.1



  parent reply	other threads:[~2022-07-06 18:44 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06 18:39 [RFC PATCH v9 00/23] Net Control VQ support in SVQ Eugenio Pérez
2022-07-06 18:39 ` [RFC PATCH v9 01/23] vhost: Return earlier if used buffers overrun Eugenio Pérez
2022-07-08  8:52   ` Jason Wang
2022-07-06 18:39 ` [RFC PATCH v9 02/23] vhost: move descriptor translation to vhost_svq_vring_write_descs Eugenio Pérez
2022-07-06 18:39 ` [RFC PATCH v9 03/23] vdpa: delay set_vring_ready after DRIVER_OK Eugenio Pérez
2022-07-08  9:06   ` Jason Wang
2022-07-08  9:56     ` Eugenio Perez Martin
2022-07-08  9:59     ` Eugenio Perez Martin
2022-07-13  5:51   ` Michael S. Tsirkin
2022-07-13  6:18     ` Eugenio Perez Martin
2022-07-06 18:39 ` Eugenio Pérez [this message]
2022-07-08  9:12   ` [RFC PATCH v9 04/23] vhost: Get vring base from vq, not svq Jason Wang
2022-07-08 10:10     ` Eugenio Perez Martin
2022-07-12  7:42       ` Jason Wang
2022-07-12  9:42         ` Eugenio Perez Martin
2022-07-06 18:39 ` [RFC PATCH v9 05/23] vhost: Add ShadowVirtQueueStart operation Eugenio Pérez
2022-07-06 18:39 ` [RFC PATCH v9 06/23] virtio-net: Expose ctrl virtqueue logic Eugenio Pérez
2022-07-06 18:39 ` [RFC PATCH v9 07/23] vhost: add vhost_svq_push_elem Eugenio Pérez
2022-07-06 18:39 ` [RFC PATCH v9 08/23] vhost: Decouple vhost_svq_add_split from VirtQueueElement Eugenio Pérez
2022-07-11  8:00   ` Jason Wang
2022-07-11  8:27     ` Eugenio Perez Martin
2022-07-12  7:43       ` Jason Wang
2022-07-06 18:39 ` [RFC PATCH v9 09/23] vhost: Add SVQElement Eugenio Pérez
2022-07-11  9:00   ` Jason Wang
2022-07-11  9:33     ` Eugenio Perez Martin
2022-07-12  7:49       ` Jason Wang
2022-07-06 18:39 ` [RFC PATCH v9 10/23] vhost: Reorder vhost_svq_last_desc_of_chain Eugenio Pérez
2022-07-06 18:39 ` [RFC PATCH v9 11/23] vhost: Move last chain id to SVQ element Eugenio Pérez
2022-07-11  9:02   ` Jason Wang
2022-07-06 18:39 ` [RFC PATCH v9 12/23] vhost: Add opaque member to SVQElement Eugenio Pérez
2022-07-11  9:05   ` Jason Wang
2022-07-11  9:56     ` Eugenio Perez Martin
2022-07-12  7:53       ` Jason Wang
2022-07-12  8:32         ` Eugenio Perez Martin
2022-07-12  8:43           ` Jason Wang
2022-07-06 18:39 ` [RFC PATCH v9 13/23] vhost: Add vhost_svq_inject Eugenio Pérez
2022-07-11  9:14   ` Jason Wang
2022-07-11  9:43     ` Eugenio Perez Martin
2022-07-12  7:58       ` Jason Wang
2022-07-06 18:39 ` [RFC PATCH v9 14/23] vhost: add vhost_svq_poll Eugenio Pérez
2022-07-11  9:19   ` Jason Wang
2022-07-11 17:52     ` Eugenio Perez Martin
2022-07-06 18:40 ` [RFC PATCH v9 15/23] vhost: Add custom used buffer callback Eugenio Pérez
2022-07-06 18:40 ` [RFC PATCH v9 16/23] vhost: Add svq avail_handler callback Eugenio Pérez
2022-07-06 18:40 ` [RFC PATCH v9 17/23] vhost: add detach SVQ operation Eugenio Pérez
2022-07-06 18:40 ` [RFC PATCH v9 18/23] vdpa: Export vhost_vdpa_dma_map and unmap calls Eugenio Pérez
2022-07-11  9:22   ` Jason Wang
2022-07-06 18:40 ` [RFC PATCH v9 19/23] vdpa: Extract get features part from vhost_vdpa_get_max_queue_pairs Eugenio Pérez
2022-07-12  4:11   ` Jason Wang
2022-07-06 18:40 ` [RFC PATCH v9 20/23] vdpa: Buffer CVQ support on shadow virtqueue Eugenio Pérez
2022-07-12  7:17   ` Jason Wang
2022-07-12  9:47     ` Eugenio Perez Martin
2022-07-14  6:54       ` Eugenio Perez Martin
2022-07-14  7:04         ` Jason Wang
2022-07-14 17:37           ` Eugenio Perez Martin
2022-07-06 18:40 ` [RFC PATCH v9 21/23] vdpa: Add vhost_vdpa_start_control_svq Eugenio Pérez
2022-07-12  7:26   ` Jason Wang
2022-07-17 10:30     ` Eugenio Perez Martin
2022-07-17 11:00       ` Eugenio Perez Martin
2022-07-06 18:40 ` [RFC PATCH v9 22/23] vdpa: Inject virtio-net mac address via CVQ at start Eugenio Pérez
2022-07-06 18:40 ` [RFC PATCH v9 23/23] vdpa: Add x-svq to NetdevVhostVDPAOptions Eugenio Pérez
2022-07-07  6:23   ` Markus Armbruster
2022-07-08 10:53     ` Eugenio Perez Martin
2022-07-08 12:51       ` Markus Armbruster
2022-07-11  7:14         ` Eugenio Perez Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220706184008.1649478-5-eperezma@redhat.com \
    --to=eperezma@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=armbru@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=eblake@redhat.com \
    --cc=eli@mellanox.com \
    --cc=gdawar@xilinx.com \
    --cc=hanand@xilinx.com \
    --cc=jasowang@redhat.com \
    --cc=lingshan.zhu@intel.com \
    --cc=liuxiangdong5@huawei.com \
    --cc=lulu@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@mellanox.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).