From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, clg@kaod.org,
jianchunfu <jianchunfu@cmss.chinamobile.com>,
Daniel Henrique Barboza <danielhb413@gmail.com>
Subject: [PATCH v2 3/5] target/ppc: Add error reporting when opening file fails
Date: Wed, 6 Jul 2022 16:31:38 -0300 [thread overview]
Message-ID: <20220706193140.468009-4-danielhb413@gmail.com> (raw)
In-Reply-To: <20220706193140.468009-1-danielhb413@gmail.com>
From: jianchunfu <jianchunfu@cmss.chinamobile.com>
Add error reporting before return when opening file fails in
kvmppc_read_int_dt().
Signed-off-by: jianchunfu <jianchunfu@cmss.chinamobile.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
[danielhb: use error_setg() instead of fprintf]
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
target/ppc/kvm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
index bc17437097..7611e9ccf6 100644
--- a/target/ppc/kvm.c
+++ b/target/ppc/kvm.c
@@ -1896,7 +1896,7 @@ static int kvmppc_find_cpu_dt(char *buf, int buf_len)
return 0;
}
-static uint64_t kvmppc_read_int_dt(const char *filename)
+static uint64_t kvmppc_read_int_dt(const char *filename, Error **errp)
{
union {
uint32_t v32;
@@ -1907,6 +1907,7 @@ static uint64_t kvmppc_read_int_dt(const char *filename)
f = fopen(filename, "rb");
if (!f) {
+ error_setg(errp, "Error opening %s: %s", filename, strerror(errno));
return 0;
}
@@ -1940,7 +1941,7 @@ static uint64_t kvmppc_read_int_cpu_dt(const char *propname, Error **errp)
}
tmp = g_strdup_printf("%s/%s", buf, propname);
- val = kvmppc_read_int_dt(tmp);
+ val = kvmppc_read_int_dt(tmp, errp);
g_free(tmp);
return val;
--
2.36.1
next prev parent reply other threads:[~2022-07-06 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 19:31 [PATCH v2 0/5] cleanup error handling in kvmppc_read_int_cpu_dt() Daniel Henrique Barboza
2022-07-06 19:31 ` [PATCH v2 1/5] target/ppc/kvm.c: do not return -1 on uint64_t return Daniel Henrique Barboza
2022-07-07 7:03 ` Cédric Le Goater
2022-07-06 19:31 ` [PATCH v2 2/5] target/ppc: add errp to kvmppc_read_int_cpu_dt() Daniel Henrique Barboza
2022-07-06 19:31 ` Daniel Henrique Barboza [this message]
2022-07-06 19:31 ` [PATCH v2 4/5] target/ppc: use g_autofree in kvmppc_read_int_cpu_dt() Daniel Henrique Barboza
2022-07-06 19:31 ` [PATCH v2 5/5] target/ppc: exit(1) on failure in kvmppc_get_clockfreq() Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706193140.468009-4-danielhb413@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=jianchunfu@cmss.chinamobile.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).