From: zhenwei pi <pizhenwei@bytedance.com>
To: michael.roth@amd.com, kkostiuk@redhat.com,
marcandre.lureau@redhat.com, armbru@redhat.com
Cc: qemu-devel@nongnu.org, zhenwei pi <pizhenwei@bytedance.com>
Subject: [PATCH v4 1/2] qapi: Avoid generating C identifier 'linux'
Date: Thu, 7 Jul 2022 08:56:01 +0800 [thread overview]
Message-ID: <20220707005602.696557-2-pizhenwei@bytedance.com> (raw)
In-Reply-To: <20220707005602.696557-1-pizhenwei@bytedance.com>
'linux' is not usable as identifier, because C compilers targeting
Linux predefine it as a macro expanding to 1. Add it to
@polluted_words. 'unix' is already there.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
---
scripts/qapi/common.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py
index 489273574a..737b059e62 100644
--- a/scripts/qapi/common.py
+++ b/scripts/qapi/common.py
@@ -114,7 +114,7 @@ def c_name(name: str, protect: bool = True) -> str:
'and', 'and_eq', 'bitand', 'bitor', 'compl', 'not',
'not_eq', 'or', 'or_eq', 'xor', 'xor_eq'])
# namespace pollution:
- polluted_words = set(['unix', 'errno', 'mips', 'sparc', 'i386'])
+ polluted_words = set(['unix', 'errno', 'mips', 'sparc', 'i386', 'linux'])
name = re.sub(r'[^A-Za-z0-9_]', '_', name)
if protect and (name in (c89_words | c99_words | c11_words | gcc_words
| cpp_words | polluted_words)
--
2.20.1
next prev parent reply other threads:[~2022-07-07 1:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 0:56 [PATCH v4 0/2] qga: add command 'guest-get-cpustats' zhenwei pi
2022-07-07 0:56 ` zhenwei pi [this message]
2022-07-07 6:26 ` [PATCH v4 1/2] qapi: Avoid generating C identifier 'linux' Markus Armbruster
2022-07-07 6:28 ` zhenwei pi
2022-07-07 0:56 ` [PATCH v4 2/2] qga: add command 'guest-get-cpustats' zhenwei pi
2022-07-07 8:00 ` Konstantin Kostiuk
2022-07-12 9:30 ` [PATCH v4 0/2] " Konstantin Kostiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220707005602.696557-2-pizhenwei@bytedance.com \
--to=pizhenwei@bytedance.com \
--cc=armbru@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).