qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, "Hanna Reitz" <hreitz@redhat.com>,
	"Daniel Berrange" <berrange@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Michael Roth" <michael.roth@amd.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
	"John Snow" <jsnow@redhat.com>
Subject: [PATCH v3 01/13] qga: treat get-guest-fsinfo as "best effort"
Date: Thu,  7 Jul 2022 00:02:58 -0400	[thread overview]
Message-ID: <20220707040310.4163682-2-jsnow@redhat.com> (raw)
In-Reply-To: <20220707040310.4163682-1-jsnow@redhat.com>

In some container environments, there may be references to block devices
witnessable from a container through /proc/self/mountinfo that reference
devices we simply don't have access to in the container, and cannot
provide information about.

Instead of failing the entire fsinfo command, return stub information
for these failed lookups.

This allows test-qga to pass under docker tests, which are in turn used
by the CentOS VM tests.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 qga/commands-posix.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 0469dc409d4..950c9d72fe7 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -1207,7 +1207,12 @@ static void build_guest_fsinfo_for_device(char const *devpath,
 
     syspath = realpath(devpath, NULL);
     if (!syspath) {
-        error_setg_errno(errp, errno, "realpath(\"%s\")", devpath);
+        if (errno == ENOENT) {
+            /* This devpath may not exist because of container config, etc. */
+            fs->name = g_path_get_basename(devpath);
+        } else {
+            error_setg_errno(errp, errno, "realpath(\"%s\")", devpath);
+        }
         return;
     }
 
-- 
2.34.3



  reply	other threads:[~2022-07-07  4:11 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07  4:02 [PATCH v3 00/13] Improve reliability of VM tests John Snow
2022-07-07  4:02 ` John Snow [this message]
2022-07-07  8:17   ` [PATCH v3 01/13] qga: treat get-guest-fsinfo as "best effort" Daniel P. Berrangé
2022-07-07  8:40   ` Marc-André Lureau
2022-07-07 15:23     ` John Snow
2022-07-07  4:02 ` [PATCH v3 02/13] tests/vm: use 'cp' instead of 'ln' for temporary vm images John Snow
2022-07-07  8:18   ` Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 03/13] tests/vm: switch CentOS 8 to CentOS 8 Stream John Snow
2022-07-07  8:18   ` Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 04/13] tests/vm: switch centos.aarch64 " John Snow
2022-07-07  8:22   ` Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 05/13] tests/vm: update sha256sum for ubuntu.aarch64 John Snow
2022-07-07  8:23   ` Daniel P. Berrangé
2022-07-07 11:03   ` Richard Henderson
2022-07-07  4:03 ` [PATCH v3 06/13] tests/vm: remove ubuntu.i386 VM test John Snow
2022-07-07  8:23   ` Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 07/13] tests/vm: remove duplicate 'centos' " John Snow
2022-07-07  8:24   ` Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 08/13] tests/vm: add 1GB extra memory per core John Snow
2022-07-07  8:27   ` Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 09/13] tests/vm: upgrade Ubuntu 18.04 VM to 20.04 John Snow
2022-07-07  8:31   ` Daniel P. Berrangé
2022-07-07 11:05   ` Richard Henderson
2022-07-07 15:40     ` John Snow
2022-07-07  4:03 ` [PATCH v3 10/13] tests/vm: Remove docker cross-compile test from CentOS VM John Snow
2022-07-07  8:32   ` Daniel P. Berrangé
2022-07-07 15:48     ` John Snow
2022-07-07 15:52       ` Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 11/13] tests/qemu-iotests: hotfix for 307, 223 output John Snow
2022-07-07  4:03 ` [PATCH v3 12/13] tests/qemu-iotests: skip 108 when FUSE is not loaded John Snow
2022-07-07  4:03 ` [PATCH v3 13/13] iotests: fix copy-before-write for macOS and FreeBSD John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707040310.4163682-2-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).