qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, "Hanna Reitz" <hreitz@redhat.com>,
	"Daniel Berrange" <berrange@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Michael Roth" <michael.roth@amd.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
	"John Snow" <jsnow@redhat.com>
Subject: [PATCH v3 06/13] tests/vm: remove ubuntu.i386 VM test
Date: Thu,  7 Jul 2022 00:03:03 -0400	[thread overview]
Message-ID: <20220707040310.4163682-7-jsnow@redhat.com> (raw)
In-Reply-To: <20220707040310.4163682-1-jsnow@redhat.com>

Ubuntu 18.04 is out of our support window, and Ubuntu 20.04 does not
support i386 anymore. The debian project does, but they do not provide
any cloud images for it, a new expect-style script would have to be
written.

Since we have i386 cross-compiler tests hosted on GitLab CI, we don't
need to support this VM test anymore.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
 tests/vm/Makefile.include |  3 +--
 tests/vm/ubuntu.i386      | 40 ---------------------------------------
 2 files changed, 1 insertion(+), 42 deletions(-)
 delete mode 100755 tests/vm/ubuntu.i386

diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
index 5f5b1fbfe68..a94f0ebf7f1 100644
--- a/tests/vm/Makefile.include
+++ b/tests/vm/Makefile.include
@@ -17,7 +17,7 @@ EFI_AARCH64 = $(wildcard $(BUILD_DIR)/pc-bios/edk2-aarch64-code.fd)
 
 X86_IMAGES := freebsd netbsd openbsd centos fedora haiku.x86_64
 ifneq ($(GENISOIMAGE),)
-X86_IMAGES += ubuntu.i386 centos
+X86_IMAGES += centos
 ifneq ($(EFI_AARCH64),)
 ARM64_IMAGES += ubuntu.aarch64 centos.aarch64
 endif
@@ -48,7 +48,6 @@ vm-help vm-test:
 	@echo "  vm-build-fedora                 - Build QEMU in Fedora VM"
 ifneq ($(GENISOIMAGE),)
 	@echo "  vm-build-centos                 - Build QEMU in CentOS VM, with Docker"
-	@echo "  vm-build-ubuntu.i386            - Build QEMU in ubuntu i386 VM"
 ifneq ($(EFI_AARCH64),)
 	@echo "  vm-build-ubuntu.aarch64         - Build QEMU in ubuntu aarch64 VM"
 	@echo "  vm-build-centos.aarch64         - Build QEMU in CentOS aarch64 VM"
diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386
deleted file mode 100755
index 47681b6f87d..00000000000
--- a/tests/vm/ubuntu.i386
+++ /dev/null
@@ -1,40 +0,0 @@
-#!/usr/bin/env python3
-#
-# Ubuntu i386 image
-#
-# Copyright 2017 Red Hat Inc.
-#
-# Authors:
-#  Fam Zheng <famz@redhat.com>
-#
-# This code is licensed under the GPL version 2 or later.  See
-# the COPYING file in the top-level directory.
-#
-
-import sys
-import basevm
-import ubuntuvm
-
-DEFAULT_CONFIG = {
-    'install_cmds' : "apt-get update,"\
-                     "apt-get build-dep -y qemu,"\
-                     "apt-get install -y libfdt-dev language-pack-en ninja-build",
-}
-
-class UbuntuX86VM(ubuntuvm.UbuntuVM):
-    name = "ubuntu.i386"
-    arch = "i386"
-    image_link="https://cloud-images.ubuntu.com/releases/bionic/"\
-               "release-20191114/ubuntu-18.04-server-cloudimg-i386.img"
-    image_sha256="28969840626d1ea80bb249c08eef1a4533e8904aa51a327b40f37ac4b4ff04ef"
-    BUILD_SCRIPT = """
-        set -e;
-        cd $(mktemp -d);
-        sudo chmod a+r /dev/vdb;
-        tar -xf /dev/vdb;
-        ./configure {configure_opts};
-        make --output-sync {target} -j{jobs} {verbose};
-    """
-
-if __name__ == "__main__":
-    sys.exit(basevm.main(UbuntuX86VM, DEFAULT_CONFIG))
-- 
2.34.3



  parent reply	other threads:[~2022-07-07  4:06 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07  4:02 [PATCH v3 00/13] Improve reliability of VM tests John Snow
2022-07-07  4:02 ` [PATCH v3 01/13] qga: treat get-guest-fsinfo as "best effort" John Snow
2022-07-07  8:17   ` Daniel P. Berrangé
2022-07-07  8:40   ` Marc-André Lureau
2022-07-07 15:23     ` John Snow
2022-07-07  4:02 ` [PATCH v3 02/13] tests/vm: use 'cp' instead of 'ln' for temporary vm images John Snow
2022-07-07  8:18   ` Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 03/13] tests/vm: switch CentOS 8 to CentOS 8 Stream John Snow
2022-07-07  8:18   ` Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 04/13] tests/vm: switch centos.aarch64 " John Snow
2022-07-07  8:22   ` Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 05/13] tests/vm: update sha256sum for ubuntu.aarch64 John Snow
2022-07-07  8:23   ` Daniel P. Berrangé
2022-07-07 11:03   ` Richard Henderson
2022-07-07  4:03 ` John Snow [this message]
2022-07-07  8:23   ` [PATCH v3 06/13] tests/vm: remove ubuntu.i386 VM test Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 07/13] tests/vm: remove duplicate 'centos' " John Snow
2022-07-07  8:24   ` Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 08/13] tests/vm: add 1GB extra memory per core John Snow
2022-07-07  8:27   ` Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 09/13] tests/vm: upgrade Ubuntu 18.04 VM to 20.04 John Snow
2022-07-07  8:31   ` Daniel P. Berrangé
2022-07-07 11:05   ` Richard Henderson
2022-07-07 15:40     ` John Snow
2022-07-07  4:03 ` [PATCH v3 10/13] tests/vm: Remove docker cross-compile test from CentOS VM John Snow
2022-07-07  8:32   ` Daniel P. Berrangé
2022-07-07 15:48     ` John Snow
2022-07-07 15:52       ` Daniel P. Berrangé
2022-07-07  4:03 ` [PATCH v3 11/13] tests/qemu-iotests: hotfix for 307, 223 output John Snow
2022-07-07  4:03 ` [PATCH v3 12/13] tests/qemu-iotests: skip 108 when FUSE is not loaded John Snow
2022-07-07  4:03 ` [PATCH v3 13/13] iotests: fix copy-before-write for macOS and FreeBSD John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707040310.4163682-7-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).