qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-s390x@nongnu.org,
	Janis Schoetterl-Glausch <scgl@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>
Subject: [PULL 01/18] target/s390x/tcg: SPX: check validity of new prefix
Date: Thu,  7 Jul 2022 09:54:09 +0200	[thread overview]
Message-ID: <20220707075426.1163210-2-thuth@redhat.com> (raw)
In-Reply-To: <20220707075426.1163210-1-thuth@redhat.com>

From: Janis Schoetterl-Glausch <scgl@linux.ibm.com>

According to the architecture, SET PREFIX must try to access the new
prefix area and recognize an addressing exception if the area is not
accessible.
For qemu this check prevents a crash in cpu_map_lowcore after an
inaccessible prefix area has been set.

Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220630094340.3646279-1-scgl@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 target/s390x/tcg/misc_helper.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/target/s390x/tcg/misc_helper.c b/target/s390x/tcg/misc_helper.c
index aab9c47747..10dadb002a 100644
--- a/target/s390x/tcg/misc_helper.c
+++ b/target/s390x/tcg/misc_helper.c
@@ -158,6 +158,13 @@ void HELPER(spx)(CPUS390XState *env, uint64_t a1)
     if (prefix == old_prefix) {
         return;
     }
+    /*
+     * Since prefix got aligned to 8k and memory increments are a multiple of
+     * 8k checking the first page is sufficient
+     */
+    if (!mmu_absolute_addr_valid(prefix, true)) {
+        tcg_s390_program_interrupt(env, PGM_ADDRESSING, GETPC());
+    }
 
     env->psa = prefix;
     HELPER_LOG("prefix: %#x\n", prefix);
-- 
2.31.1



  reply	other threads:[~2022-07-07  8:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07  7:54 [PULL 00/18] s390x updates Thomas Huth
2022-07-07  7:54 ` Thomas Huth [this message]
2022-07-07  7:54 ` [PULL 02/18] pc-bios/s390-ccw: Add a proper prototype for main() Thomas Huth
2022-07-07  7:54 ` [PULL 03/18] pc-bios/s390-ccw/virtio: Introduce a macro for the DASD block size Thomas Huth
2022-07-07  7:54 ` [PULL 04/18] pc-bios/s390-ccw/bootmap: Improve the guessing logic in zipl_load_vblk() Thomas Huth
2022-07-07  7:54 ` [PULL 05/18] pc-bios/s390-ccw/virtio-blkdev: Simplify/fix virtio_ipl_disk_is_valid() Thomas Huth
2022-07-07  7:54 ` [PULL 06/18] pc-bios/s390-ccw/virtio-blkdev: Remove virtio_assume_scsi() Thomas Huth
2022-07-07  7:54 ` [PULL 07/18] pc-bios/s390-ccw/virtio: Set missing status bits while initializing Thomas Huth
2022-07-07  7:54 ` [PULL 08/18] pc-bios/s390-ccw/virtio: Read device config after feature negotiation Thomas Huth
2022-07-07  7:54 ` [PULL 09/18] pc-bios/s390-ccw/virtio: Beautify the code for reading virtqueue configuration Thomas Huth
2022-07-07  7:54 ` [PULL 10/18] pc-bios/s390-ccw: Split virtio-scsi code from virtio_blk_setup_device() Thomas Huth
2022-07-07  7:54 ` [PULL 11/18] pc-bios/s390-ccw/virtio-blkdev: Request the right feature bits Thomas Huth
2022-07-07  7:54 ` [PULL 12/18] pc-bios/s390-ccw/virtio: Remove "extern" keyword from prototypes Thomas Huth
2022-07-07  7:54 ` [PULL 13/18] pc-bios/s390-ccw/netboot.mak: Ignore Clang's warnings about GNU extensions Thomas Huth
2022-07-07  7:54 ` [PULL 14/18] pc-bios/s390-ccw: Update the s390-ccw bios binaries with the virtio-blk fixes Thomas Huth
2022-07-07  7:54 ` [PULL 15/18] target/s390x: Remove DISAS_GOTO_TB Thomas Huth
2022-07-07  7:54 ` [PULL 16/18] target/s390x: Remove DISAS_PC_STALE Thomas Huth
2022-07-07  7:54 ` [PULL 17/18] target/s390x: Remove DISAS_PC_STALE_NOCHAIN Thomas Huth
2022-07-07  7:54 ` [PULL 18/18] target/s390x: Exit tb after executing ex_value Thomas Huth
2022-07-08  0:46 ` [PULL 00/18] s390x updates Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707075426.1163210-2-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=scgl@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).