From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-s390x@nongnu.org, Eric Farman <farman@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>
Subject: [PULL 03/18] pc-bios/s390-ccw/virtio: Introduce a macro for the DASD block size
Date: Thu, 7 Jul 2022 09:54:11 +0200 [thread overview]
Message-ID: <20220707075426.1163210-4-thuth@redhat.com> (raw)
In-Reply-To: <20220707075426.1163210-1-thuth@redhat.com>
Use VIRTIO_DASD_DEFAULT_BLOCK_SIZE instead of the magic value 4096.
Message-Id: <20220704111903.62400-3-thuth@redhat.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
pc-bios/s390-ccw/virtio.h | 1 +
pc-bios/s390-ccw/virtio-blkdev.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/virtio.h b/pc-bios/s390-ccw/virtio.h
index 19fceb6495..9e410bde6f 100644
--- a/pc-bios/s390-ccw/virtio.h
+++ b/pc-bios/s390-ccw/virtio.h
@@ -198,6 +198,7 @@ extern int virtio_read_many(ulong sector, void *load_addr, int sec_num);
#define VIRTIO_SECTOR_SIZE 512
#define VIRTIO_ISO_BLOCK_SIZE 2048
#define VIRTIO_SCSI_BLOCK_SIZE 512
+#define VIRTIO_DASD_DEFAULT_BLOCK_SIZE 4096
static inline ulong virtio_sector_adjust(ulong sector)
{
diff --git a/pc-bios/s390-ccw/virtio-blkdev.c b/pc-bios/s390-ccw/virtio-blkdev.c
index 7d35050292..6483307630 100644
--- a/pc-bios/s390-ccw/virtio-blkdev.c
+++ b/pc-bios/s390-ccw/virtio-blkdev.c
@@ -155,7 +155,7 @@ void virtio_assume_eckd(void)
vdev->config.blk.physical_block_exp = 0;
switch (vdev->senseid.cu_model) {
case VIRTIO_ID_BLOCK:
- vdev->config.blk.blk_size = 4096;
+ vdev->config.blk.blk_size = VIRTIO_DASD_DEFAULT_BLOCK_SIZE;
break;
case VIRTIO_ID_SCSI:
vdev->config.blk.blk_size = vdev->scsi_block_size;
--
2.31.1
next prev parent reply other threads:[~2022-07-07 7:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 7:54 [PULL 00/18] s390x updates Thomas Huth
2022-07-07 7:54 ` [PULL 01/18] target/s390x/tcg: SPX: check validity of new prefix Thomas Huth
2022-07-07 7:54 ` [PULL 02/18] pc-bios/s390-ccw: Add a proper prototype for main() Thomas Huth
2022-07-07 7:54 ` Thomas Huth [this message]
2022-07-07 7:54 ` [PULL 04/18] pc-bios/s390-ccw/bootmap: Improve the guessing logic in zipl_load_vblk() Thomas Huth
2022-07-07 7:54 ` [PULL 05/18] pc-bios/s390-ccw/virtio-blkdev: Simplify/fix virtio_ipl_disk_is_valid() Thomas Huth
2022-07-07 7:54 ` [PULL 06/18] pc-bios/s390-ccw/virtio-blkdev: Remove virtio_assume_scsi() Thomas Huth
2022-07-07 7:54 ` [PULL 07/18] pc-bios/s390-ccw/virtio: Set missing status bits while initializing Thomas Huth
2022-07-07 7:54 ` [PULL 08/18] pc-bios/s390-ccw/virtio: Read device config after feature negotiation Thomas Huth
2022-07-07 7:54 ` [PULL 09/18] pc-bios/s390-ccw/virtio: Beautify the code for reading virtqueue configuration Thomas Huth
2022-07-07 7:54 ` [PULL 10/18] pc-bios/s390-ccw: Split virtio-scsi code from virtio_blk_setup_device() Thomas Huth
2022-07-07 7:54 ` [PULL 11/18] pc-bios/s390-ccw/virtio-blkdev: Request the right feature bits Thomas Huth
2022-07-07 7:54 ` [PULL 12/18] pc-bios/s390-ccw/virtio: Remove "extern" keyword from prototypes Thomas Huth
2022-07-07 7:54 ` [PULL 13/18] pc-bios/s390-ccw/netboot.mak: Ignore Clang's warnings about GNU extensions Thomas Huth
2022-07-07 7:54 ` [PULL 14/18] pc-bios/s390-ccw: Update the s390-ccw bios binaries with the virtio-blk fixes Thomas Huth
2022-07-07 7:54 ` [PULL 15/18] target/s390x: Remove DISAS_GOTO_TB Thomas Huth
2022-07-07 7:54 ` [PULL 16/18] target/s390x: Remove DISAS_PC_STALE Thomas Huth
2022-07-07 7:54 ` [PULL 17/18] target/s390x: Remove DISAS_PC_STALE_NOCHAIN Thomas Huth
2022-07-07 7:54 ` [PULL 18/18] target/s390x: Exit tb after executing ex_value Thomas Huth
2022-07-08 0:46 ` [PULL 00/18] s390x updates Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220707075426.1163210-4-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).