* [PATCH] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type
@ 2022-07-11 9:57 Thomas Huth
2022-07-11 20:30 ` John Snow
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2022-07-11 9:57 UTC (permalink / raw)
To: John Snow, qemu-devel; +Cc: Markus Armbruster, qemu-trivial
'returns-whitelist' has been renamed to 'command-returns-exceptions' in
commit b86df3747848 ("qapi: Rename pragma *-whitelist to *-exceptions").
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
python/qemu/qmp/legacy.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py
index 03b5574618..1951754455 100644
--- a/python/qemu/qmp/legacy.py
+++ b/python/qemu/qmp/legacy.py
@@ -50,7 +50,7 @@
# QMPMessage can be outgoing commands or incoming events/returns.
# QMPReturnValue is usually a dict/json object, but due to QAPI's
-# 'returns-whitelist', it can actually be anything.
+# 'command-returns-exceptions', it can actually be anything.
#
# {'return': {}} is a QMPMessage,
# {} is the QMPReturnValue.
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type
2022-07-11 9:57 [PATCH] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type Thomas Huth
@ 2022-07-11 20:30 ` John Snow
2022-07-11 20:31 ` John Snow
2022-07-18 18:41 ` Thomas Huth
0 siblings, 2 replies; 4+ messages in thread
From: John Snow @ 2022-07-11 20:30 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, Markus Armbruster, qemu-trivial
On Mon, Jul 11, 2022 at 5:57 AM Thomas Huth <thuth@redhat.com> wrote:
>
> 'returns-whitelist' has been renamed to 'command-returns-exceptions' in
> commit b86df3747848 ("qapi: Rename pragma *-whitelist to *-exceptions").
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> python/qemu/qmp/legacy.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py
> index 03b5574618..1951754455 100644
> --- a/python/qemu/qmp/legacy.py
> +++ b/python/qemu/qmp/legacy.py
> @@ -50,7 +50,7 @@
>
> # QMPMessage can be outgoing commands or incoming events/returns.
> # QMPReturnValue is usually a dict/json object, but due to QAPI's
> -# 'returns-whitelist', it can actually be anything.
> +# 'command-returns-exceptions', it can actually be anything.
> #
> # {'return': {}} is a QMPMessage,
> # {} is the QMPReturnValue.
> --
> 2.31.1
>
May I cajole you to send a MR to
https://gitlab.com/qemu-project/python-qemu-qmp ?
(Sorry for the duplicated effort while the library isn't 100% split
out of the tree yet.)
In this case, for qemu.git:
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type
2022-07-11 20:30 ` John Snow
@ 2022-07-11 20:31 ` John Snow
2022-07-18 18:41 ` Thomas Huth
1 sibling, 0 replies; 4+ messages in thread
From: John Snow @ 2022-07-11 20:31 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, Markus Armbruster, qemu-trivial
On Mon, Jul 11, 2022 at 4:30 PM John Snow <jsnow@redhat.com> wrote:
>
> On Mon, Jul 11, 2022 at 5:57 AM Thomas Huth <thuth@redhat.com> wrote:
> >
> > 'returns-whitelist' has been renamed to 'command-returns-exceptions' in
> > commit b86df3747848 ("qapi: Rename pragma *-whitelist to *-exceptions").
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> > python/qemu/qmp/legacy.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py
> > index 03b5574618..1951754455 100644
> > --- a/python/qemu/qmp/legacy.py
> > +++ b/python/qemu/qmp/legacy.py
> > @@ -50,7 +50,7 @@
> >
> > # QMPMessage can be outgoing commands or incoming events/returns.
> > # QMPReturnValue is usually a dict/json object, but due to QAPI's
> > -# 'returns-whitelist', it can actually be anything.
> > +# 'command-returns-exceptions', it can actually be anything.
> > #
> > # {'return': {}} is a QMPMessage,
> > # {} is the QMPReturnValue.
> > --
> > 2.31.1
> >
>
> May I cajole you to send a MR to
> https://gitlab.com/qemu-project/python-qemu-qmp ?
>
> (Sorry for the duplicated effort while the library isn't 100% split
> out of the tree yet.)
>
> In this case, for qemu.git:
>
> Reviewed-by: John Snow <jsnow@redhat.com>
Queued.
--js
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type
2022-07-11 20:30 ` John Snow
2022-07-11 20:31 ` John Snow
@ 2022-07-18 18:41 ` Thomas Huth
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2022-07-18 18:41 UTC (permalink / raw)
To: John Snow; +Cc: qemu-devel, Markus Armbruster, qemu-trivial
On 11/07/2022 22.30, John Snow wrote:
> On Mon, Jul 11, 2022 at 5:57 AM Thomas Huth <thuth@redhat.com> wrote:
>>
>> 'returns-whitelist' has been renamed to 'command-returns-exceptions' in
>> commit b86df3747848 ("qapi: Rename pragma *-whitelist to *-exceptions").
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> python/qemu/qmp/legacy.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py
>> index 03b5574618..1951754455 100644
>> --- a/python/qemu/qmp/legacy.py
>> +++ b/python/qemu/qmp/legacy.py
>> @@ -50,7 +50,7 @@
>>
>> # QMPMessage can be outgoing commands or incoming events/returns.
>> # QMPReturnValue is usually a dict/json object, but due to QAPI's
>> -# 'returns-whitelist', it can actually be anything.
>> +# 'command-returns-exceptions', it can actually be anything.
>> #
>> # {'return': {}} is a QMPMessage,
>> # {} is the QMPReturnValue.
>> --
>> 2.31.1
>>
>
> May I cajole you to send a MR to
> https://gitlab.com/qemu-project/python-qemu-qmp ?
Sure, done now:
https://gitlab.com/qemu-project/python-qemu-qmp/-/merge_requests/9
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-18 19:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-11 9:57 [PATCH] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type Thomas Huth
2022-07-11 20:30 ` John Snow
2022-07-11 20:31 ` John Snow
2022-07-18 18:41 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).