From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH 0/3] accel/tcg: Fix unaligned stores to s390x low-address-protected lowcore
Date: Mon, 11 Jul 2022 20:56:37 +0200 [thread overview]
Message-ID: <20220711185640.3558813-1-iii@linux.ibm.com> (raw)
Hi,
I noticed that certain accesses to lowcore incorrectly trigger
protection exceptions. I tracked it down to store_helper_unaligned()
calling tlb_fill() with ranges like [0, 2000).
Patch 1 fixes the issue, patch 2 adds a new MMIO device that enables
writing system tests for s390x, patch 3 adds a system test for this
issue.
Best regards,
Ilya
Ilya Leoshkevich (3):
accel/tcg: Fix unaligned stores to s390x low-address-protected lowcore
hw/misc: Add mmio-debug-exit device
tests/tcg/s390x: Test unaligned accesses to lowcore
accel/tcg/cputlb.c | 8 ++-
hw/misc/Kconfig | 3 +
hw/misc/debugexit_mmio.c | 80 +++++++++++++++++++++++++
hw/misc/meson.build | 1 +
hw/s390x/Kconfig | 1 +
tests/tcg/s390x/Makefile.softmmu-target | 9 +++
tests/tcg/s390x/unaligned-lowcore.S | 24 ++++++++
7 files changed, 123 insertions(+), 3 deletions(-)
create mode 100644 hw/misc/debugexit_mmio.c
create mode 100644 tests/tcg/s390x/Makefile.softmmu-target
create mode 100644 tests/tcg/s390x/unaligned-lowcore.S
--
2.35.3
next reply other threads:[~2022-07-11 19:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 18:56 Ilya Leoshkevich [this message]
2022-07-11 18:56 ` [PATCH 1/3] accel/tcg: Fix unaligned stores to s390x low-address-protected lowcore Ilya Leoshkevich
2022-07-12 5:12 ` Richard Henderson
2022-07-12 7:14 ` David Hildenbrand
2022-07-11 18:56 ` [PATCH 2/3] hw/misc: Add mmio-debug-exit device Ilya Leoshkevich
2022-07-12 5:12 ` Richard Henderson
2022-07-12 9:52 ` Ilya Leoshkevich
2022-07-12 10:08 ` David Hildenbrand
2022-07-12 10:08 ` David Hildenbrand
2022-07-12 10:30 ` Ilya Leoshkevich
2022-07-11 18:56 ` [PATCH 3/3] tests/tcg/s390x: Test unaligned accesses to lowcore Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220711185640.3558813-1-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).