qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Bernhard Beschow" <shentey@gmail.com>
Subject: [PATCH 10/11] hw/isa/piix3: Wire up ACPI interrupt internally
Date: Wed, 13 Jul 2022 10:17:34 +0200	[thread overview]
Message-ID: <20220713081735.112016-11-shentey@gmail.com> (raw)
In-Reply-To: <20220713081735.112016-1-shentey@gmail.com>

Now that PIIX3 has the PIC integrated, the ACPI controller can be wired
up internally.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/i386/pc_piix.c | 1 -
 hw/isa/piix3.c    | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index f843a73d90..19c86b68bd 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -303,7 +303,6 @@ static void pc_init1(MachineState *machine,
     if (piix4_pm) {
         smi_irq = qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0);
 
-        qdev_connect_gpio_out(DEVICE(piix4_pm), 0, x86ms->gsi[9]);
         qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_irq);
         pcms->smbus = I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c"));
         /* TODO: Populate SPD eeprom data.  */
diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c
index fd9c8f853a..56a741c192 100644
--- a/hw/isa/piix3.c
+++ b/hw/isa/piix3.c
@@ -351,6 +351,8 @@ static void pci_piix3_realize(PCIDevice *dev, Error **errp)
         if (!qdev_realize(DEVICE(&d->pm), BUS(pci_bus), errp)) {
             return;
         }
+        qdev_connect_gpio_out(DEVICE(&d->pm), 0,
+                              qdev_get_gpio_in(DEVICE(&d->pic), 9));
     } else {
         object_unparent(OBJECT(&d->pm));
     }
-- 
2.37.1



  parent reply	other threads:[~2022-07-13  8:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13  8:17 [PATCH 00/11] QOM'ify PIIX3 southbridge Bernhard Beschow
2022-07-13  8:17 ` [PATCH 01/11] hw/i386/pc: QOM'ify DMA creation Bernhard Beschow
2022-07-13  8:17 ` [PATCH 02/11] hw/i386/pc_piix: Allow for setting properties before realizing PIIX3 southbridge Bernhard Beschow
2022-07-14 14:59   ` Peter Maydell
2022-07-13  8:17 ` [PATCH 03/11] hw/isa/piix3: QOM'ify USB controller creation Bernhard Beschow
2022-07-14 15:01   ` Peter Maydell
2022-07-13  8:17 ` [PATCH 04/11] hw/isa/piix3: QOM'ify ACPI " Bernhard Beschow
2022-07-13  8:17 ` [PATCH 05/11] hw/i386/pc: QOM'ify RTC creation Bernhard Beschow
2022-07-13  8:17 ` [PATCH 06/11] hw/i386/pc: No need for rtc_state to be an out-parameter Bernhard Beschow
2022-07-14 15:03   ` Peter Maydell
2022-07-13  8:17 ` [PATCH 07/11] hw/intc/i8259: Introduce i8259 proxy "isa-pic" Bernhard Beschow
2022-07-13  8:17 ` [PATCH 08/11] hw/isa/piix3: QOM'ify ISA PIC creation Bernhard Beschow
2022-07-13  8:17 ` [PATCH 09/11] hw/isa/piix3: QOM'ify IDE controller creation Bernhard Beschow
2022-07-13  8:17 ` Bernhard Beschow [this message]
2022-07-13  8:17 ` [PATCH 11/11] hw/isa/piix3: Remove extra ';' outside of functions Bernhard Beschow
2022-07-14 15:06   ` [PATCH 11/11] hw/isa/piix3: Remove extra '; ' " Peter Maydell
2022-07-26 14:53 ` [PATCH 00/11] QOM'ify PIIX3 southbridge Michael S. Tsirkin
2022-07-26 22:23   ` BB

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220713081735.112016-11-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=eduardo@habkost.net \
    --cc=f4bug@amsat.org \
    --cc=hpoussin@reactos.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).