From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
qemu-arm@nongnu.org, "David Hildenbrand" <david@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 3/3] target/arm: display deprecation note in '-cpu help'
Date: Thu, 14 Jul 2022 16:07:35 +0100 [thread overview]
Message-ID: <20220714150735.1835166-4-berrange@redhat.com> (raw)
In-Reply-To: <20220714150735.1835166-1-berrange@redhat.com>
The deprecation notes are currently only displayed at runtime when the
user activates a CPU. The QMP query displays a simple flag for
deprecation, while '-cpu help' displays nothing unless the deprecation
info is duplicated into the 'notes' field.
This changes the code so that deprecation notes are explicitly shown
in '-cpu help', to assist the user in deciding what to use.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
target/arm/helper.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index cfcad97ce0..1a0988d8fc 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -8222,12 +8222,20 @@ static gint arm_cpu_list_compare(gconstpointer a, gconstpointer b)
static void arm_cpu_list_entry(gpointer data, gpointer user_data)
{
ObjectClass *oc = data;
+ CPUClass *cc = CPU_CLASS(oc);
const char *typename;
char *name;
+ g_autofree char *details = NULL;
+
+ if (cc->deprecation_note) {
+ details = g_strdup_printf(" (deprecated: %s)", cc->deprecation_note);
+ } else {
+ details = g_strdup("");
+ }
typename = object_class_get_name(oc);
name = g_strndup(typename, strlen(typename) - strlen("-" TYPE_ARM_CPU));
- qemu_printf(" %s\n", name);
+ qemu_printf(" %s%s\n", name, details);
g_free(name);
}
--
2.36.1
next prev parent reply other threads:[~2022-07-14 15:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 15:07 [PATCH 0/3] target: RFC: display deprecation note for '-cpu help' Daniel P. Berrangé
2022-07-14 15:07 ` [PATCH 1/3] target/i386: display deprecation note in " Daniel P. Berrangé
2022-07-15 8:28 ` Cornelia Huck
2022-07-14 15:07 ` [PATCH 2/3] target/s390x: " Daniel P. Berrangé
2022-07-15 8:33 ` Cornelia Huck
2022-07-14 15:07 ` Daniel P. Berrangé [this message]
2022-07-15 8:37 ` [PATCH 3/3] target/arm: " Cornelia Huck
2022-07-15 8:45 ` [PATCH 0/3] target: RFC: display deprecation note for " Cornelia Huck
2022-07-18 9:25 ` Thomas Huth
2022-07-18 9:37 ` Cornelia Huck
2022-07-18 9:46 ` Daniel P. Berrangé
2022-07-18 9:58 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714150735.1835166-4-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).