From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ani Sinha <ani@anisinha.ca>
Cc: qemu-devel@nongnu.org, thuth@redhat.com,
peter.maydell@linaro.org, berrange@redhat.com, jsnow@redhat.com,
pbonzini@redhat.com, imammedo@redhat.com
Subject: Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits
Date: Fri, 15 Jul 2022 02:50:49 -0400 [thread overview]
Message-ID: <20220715015941-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2207150929020.2162493@anisinha-lenovo>
On Fri, Jul 15, 2022 at 09:47:27AM +0530, Ani Sinha wrote:
> > Instead of all this mess, can't we just spawn e.g. "git clone --depth 1"?
> > And if the directory exists I would fetch and checkout.
>
> There are two reasons I can think of why I do not like this idea:
>
> (a) a git clone of a whole directory would download all versions of the
> binary whereas we want only a specific version.
You mention shallow clone yourself, and I used --depth 1 above.
> Downloading a single file
> by shallow cloning or creating a git archive is overkill IMHO when a wget
> style retrieval works just fine.
However, it does not provide for versioning, tagging etc so you have
to implement your own schema.
> (b) we may later move the binary archives to a ftp server or a google
> drive. git/version control mechanisms are not the best place to store
> binary blobs IMHO. In this case also, wget also works.
surely neither ftp nor google drive are reasonable dependencies
for a free software project. But qemu does maintain an http server
already so that't a plus.
I am not insisting on git, but I do not like it that security,
mirroring, caching, versioning all have to be hand rolled and then
figured out by users and maintainers. Who frankly have other things to
do besides learning yet another boutique configuration language.
And I worry that after a while we come up with a new organization schema
for the files, old ones are moved around and nothing relying on the URL
works. git is kind of good in that it enforces the idea that history is
immutable.
If not vanilla git can we find another utility we can reuse?
git lfs? It seems to be supported by both github and gitlab though
bizarrely github has bandwidth limits on git lfs but apparently not on
vanilla git. Hosting on qemu.org will require maintaining a server
there though.
All that said maybe we should just run with it as it is, just so we get
*something* in the door, and then worry about getting the storage side
straight before making this test a requirement for all acpi developers.
--
MST
next prev parent reply other threads:[~2022-07-15 6:53 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-10 17:00 [PATCH v2 00/11] Introduce new acpi/smbios python tests using biosbits Ani Sinha
2022-07-10 17:00 ` [PATCH v2 01/11] acpi/tests/bits: initial commit of test scripts that are run by biosbits Ani Sinha
2022-07-11 20:38 ` John Snow
2022-07-12 7:17 ` Ani Sinha
2022-07-12 15:23 ` John Snow
2022-07-12 15:38 ` Ani Sinha
2022-07-12 15:42 ` John Snow
2022-07-12 15:46 ` Ani Sinha
2022-07-10 17:00 ` [PATCH v2 02/11] acpi/tests/bits: add SPDX license identifiers for bios bits tests Ani Sinha
2022-07-14 13:56 ` Daniel P. Berrangé
2022-07-14 14:12 ` Ani Sinha
2022-07-10 17:00 ` [PATCH v2 03/11] acpi/tests/bits: disable acpi PSS tests that are failing in biosbits Ani Sinha
2022-07-10 17:00 ` [PATCH v2 04/11] acpi/tests/bits: add smilatency test suite from bits in order to disable it Ani Sinha
2022-07-10 17:00 ` [PATCH v2 05/11] acpi/tests/bits: add SPDX license identifiers for bios bits smilatency tests Ani Sinha
2022-07-10 17:00 ` [PATCH v2 06/11] acpi/tests/bits: disable smilatency test since it does not pass everytime Ani Sinha
2022-07-10 17:00 ` [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits Ani Sinha
2022-07-11 20:42 ` John Snow
2022-07-12 7:15 ` Ani Sinha
2022-09-06 13:05 ` Daniel P. Berrangé
2022-07-14 14:05 ` Daniel P. Berrangé
2022-07-14 14:19 ` Ani Sinha
2022-07-14 17:49 ` Ani Sinha
2022-07-14 20:43 ` Michael S. Tsirkin
2022-07-14 20:41 ` Michael S. Tsirkin
2022-07-15 4:17 ` Ani Sinha
2022-07-15 6:50 ` Michael S. Tsirkin [this message]
2022-07-16 6:36 ` Ani Sinha
2022-07-16 15:30 ` Michael S. Tsirkin
2022-07-25 18:02 ` Ani Sinha
2022-07-27 18:38 ` Ani Sinha
2022-09-16 16:00 ` Ani Sinha
2022-09-17 20:28 ` Michael S. Tsirkin
2022-09-27 8:13 ` Ani Sinha
2022-09-27 8:33 ` Daniel P. Berrangé
2022-09-27 10:07 ` Ani Sinha
2022-09-27 10:18 ` Daniel P. Berrangé
2022-09-27 10:24 ` Ani Sinha
2022-09-27 11:42 ` Ani Sinha
2022-09-27 14:05 ` Ani Sinha
2022-09-27 15:45 ` Daniel P. Berrangé
2022-09-27 21:21 ` Michael S. Tsirkin
2022-09-28 8:31 ` Thomas Huth
2022-09-28 8:35 ` Daniel P. Berrangé
2022-09-28 9:47 ` Michael S. Tsirkin
2022-09-28 9:35 ` Michael S. Tsirkin
2022-09-28 9:39 ` Thomas Huth
2022-09-28 9:56 ` Michael S. Tsirkin
2022-10-06 7:58 ` Ani Sinha
2022-10-06 8:11 ` Ani Sinha
2022-10-06 10:18 ` Ani Sinha
2022-09-27 21:19 ` Michael S. Tsirkin
2022-09-27 21:18 ` Michael S. Tsirkin
2022-09-28 3:08 ` Ani Sinha
2022-09-28 3:58 ` Michael S. Tsirkin
2022-09-28 6:06 ` Ani Sinha
2022-10-06 12:12 ` Michael S. Tsirkin
2022-09-28 6:58 ` Daniel P. Berrangé
2022-09-28 7:15 ` Ani Sinha
2022-09-28 7:26 ` Daniel P. Berrangé
2022-09-28 9:19 ` Michael S. Tsirkin
2022-09-27 21:44 ` Paolo Bonzini
2022-09-27 22:09 ` Michael S. Tsirkin
2022-09-27 23:10 ` Paolo Bonzini
2022-09-28 5:53 ` Michael S. Tsirkin
2022-09-28 7:06 ` Daniel P. Berrangé
2022-09-28 7:43 ` Thomas Huth
2022-10-09 5:21 ` Ani Sinha
2022-10-09 6:30 ` Ani Sinha
2022-10-09 16:06 ` Ani Sinha
2022-07-10 17:00 ` [PATCH v2 08/11] acpi/tests/bits: add biosbits config file for running bios tests Ani Sinha
2022-07-10 17:00 ` [PATCH v2 09/11] acpi/tests/bits: add a README file describing bits pytests Ani Sinha
2022-07-10 17:00 ` [PATCH v2 10/11] pytest: add pytest to the meson build system Ani Sinha
2022-07-11 20:46 ` John Snow
2022-07-12 6:52 ` Ani Sinha
2022-09-06 13:10 ` Daniel P. Berrangé
2022-09-27 21:26 ` Michael S. Tsirkin
2022-09-28 7:32 ` Thomas Huth
2022-09-28 9:23 ` Michael S. Tsirkin
2022-07-10 17:00 ` [PATCH v2 11/11] MAINTAINERS: add myself as the maintainer for acpi biosbits pytests Ani Sinha
2022-07-11 9:33 ` [PATCH v2 00/11] Introduce new acpi/smbios python tests using biosbits Michael S. Tsirkin
2022-07-14 13:24 ` Peter Maydell
2022-09-06 6:26 ` Ani Sinha
2022-09-06 8:19 ` Michael S. Tsirkin
2022-09-06 13:15 ` Daniel P. Berrangé
2022-09-06 13:28 ` Ani Sinha
2022-09-06 13:30 ` Daniel P. Berrangé
2022-09-09 12:53 ` Ani Sinha
2022-09-06 14:03 ` Michael S. Tsirkin
2022-09-06 14:10 ` Daniel P. Berrangé
2022-09-06 14:19 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220715015941-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ani@anisinha.ca \
--cc=berrange@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).