From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: natto@weirdnatto.in
Subject: [PATCH 1/2] monitor: add support for boolean statistics
Date: Fri, 15 Jul 2022 19:02:48 +0200 [thread overview]
Message-ID: <20220715170249.404786-2-pbonzini@redhat.com> (raw)
In-Reply-To: <20220715170249.404786-1-pbonzini@redhat.com>
The next version of Linux will introduce boolean statistics, which
can only have 0 or 1 values. Support them in the schema and in
the HMP command.
Suggested-by: Amneesh Singh <natto@weirdnatto.in>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
monitor/hmp-cmds.c | 2 ++
qapi/stats.json | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index ca98df0495..e8d6963722 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -2337,6 +2337,8 @@ static void print_stats_results(Monitor *mon, StatsTarget target,
if (stats_value->type == QTYPE_QNUM) {
monitor_printf(mon, ": %" PRId64 "\n", stats_value->u.scalar);
+ } else if (stats_value->type == QTYPE_QBOOL) {
+ monitor_printf(mon, ": %s\n", stats_value->u.boolean ? "yes" : "no");
} else if (stats_value->type == QTYPE_QLIST) {
uint64List *list;
int i;
diff --git a/qapi/stats.json b/qapi/stats.json
index 2f8bfe8fdb..cb6456c67a 100644
--- a/qapi/stats.json
+++ b/qapi/stats.json
@@ -38,11 +38,12 @@
# @bytes: stat reported in bytes.
# @seconds: stat reported in seconds.
# @cycles: stat reported in clock cycles.
+# @cycles: stat is a boolean value.
#
# Since: 7.1
##
{ 'enum' : 'StatsUnit',
- 'data' : [ 'bytes', 'seconds', 'cycles' ] }
+ 'data' : [ 'bytes', 'seconds', 'cycles', 'boolean' ] }
##
# @StatsProvider:
@@ -123,6 +124,7 @@
##
{ 'alternate': 'StatsValue',
'data': { 'scalar': 'uint64',
+ 'boolean': 'bool',
'list': [ 'uint64' ] } }
##
--
2.36.1
next prev parent reply other threads:[~2022-07-15 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 17:02 [PATCH 0/2] monitor, kvm: support for boolean statistics Paolo Bonzini
2022-07-15 17:02 ` Paolo Bonzini [this message]
2022-07-15 17:02 ` [PATCH 2/2] kvm: add " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220715170249.404786-2-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=natto@weirdnatto.in \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).