* [PATCH 0/1] Fix pointer masking functionality for RISC-V
@ 2022-07-17 10:15 Alexey Baturo
2022-07-17 10:15 ` [PATCH 1/1] target/riscv: Fix typo and restore Pointer Masking " Alexey Baturo
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Baturo @ 2022-07-17 10:15 UTC (permalink / raw)
Cc: baturo.alexey, richard.henderson, space.monkey.delivers,
kupokupokupopo, palmer, Alistair.Francis, sagark, kbastian,
qemu-devel, qemu-riscv
From: Alexey Baturo <baturo.alexey@gmail.com>
Hi,
This patch fixes a typo which leads to broken pointer masking functionality for RISC-V.
Thanks.
Alexey Baturo (1):
target/riscv: Fix typo and restore Pointer Masking functionality for
RISC-V
target/riscv/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] target/riscv: Fix typo and restore Pointer Masking functionality for RISC-V
2022-07-17 10:15 [PATCH 0/1] Fix pointer masking functionality for RISC-V Alexey Baturo
@ 2022-07-17 10:15 ` Alexey Baturo
2022-07-19 6:55 ` Alistair Francis
2022-07-19 7:06 ` Alistair Francis
0 siblings, 2 replies; 4+ messages in thread
From: Alexey Baturo @ 2022-07-17 10:15 UTC (permalink / raw)
Cc: baturo.alexey, richard.henderson, space.monkey.delivers,
kupokupokupopo, palmer, Alistair.Francis, sagark, kbastian,
qemu-devel, qemu-riscv
From: Alexey Baturo <baturo.alexey@gmail.com>
Signed-off-by: Alexey Baturo <baturo.alexey@gmail.com>
---
target/riscv/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/riscv/translate.c b/target/riscv/translate.c
index 63b04e8a94..86c19ea74e 100644
--- a/target/riscv/translate.c
+++ b/target/riscv/translate.c
@@ -544,7 +544,7 @@ static TCGv get_address(DisasContext *ctx, int rs1, int imm)
tcg_gen_addi_tl(addr, src1, imm);
if (ctx->pm_mask_enabled) {
- tcg_gen_and_tl(addr, addr, pm_mask);
+ tcg_gen_andc_tl(addr, addr, pm_mask);
} else if (get_xl(ctx) == MXL_RV32) {
tcg_gen_ext32u_tl(addr, addr);
}
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] target/riscv: Fix typo and restore Pointer Masking functionality for RISC-V
2022-07-17 10:15 ` [PATCH 1/1] target/riscv: Fix typo and restore Pointer Masking " Alexey Baturo
@ 2022-07-19 6:55 ` Alistair Francis
2022-07-19 7:06 ` Alistair Francis
1 sibling, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2022-07-19 6:55 UTC (permalink / raw)
To: Alexey Baturo
Cc: Richard Henderson, space.monkey.delivers, Dave Smith,
Palmer Dabbelt, Alistair Francis, Sagar Karandikar,
Bastian Koppelmann, qemu-devel@nongnu.org Developers,
open list:RISC-V
On Sun, Jul 17, 2022 at 8:17 PM Alexey Baturo <baturo.alexey@gmail.com> wrote:
>
> From: Alexey Baturo <baturo.alexey@gmail.com>
>
> Signed-off-by: Alexey Baturo <baturo.alexey@gmail.com>
Fixes: 4302bef9e178 ("target/riscv: Calculate address according to XLEN")
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/translate.c b/target/riscv/translate.c
> index 63b04e8a94..86c19ea74e 100644
> --- a/target/riscv/translate.c
> +++ b/target/riscv/translate.c
> @@ -544,7 +544,7 @@ static TCGv get_address(DisasContext *ctx, int rs1, int imm)
>
> tcg_gen_addi_tl(addr, src1, imm);
> if (ctx->pm_mask_enabled) {
> - tcg_gen_and_tl(addr, addr, pm_mask);
> + tcg_gen_andc_tl(addr, addr, pm_mask);
> } else if (get_xl(ctx) == MXL_RV32) {
> tcg_gen_ext32u_tl(addr, addr);
> }
> --
> 2.30.2
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] target/riscv: Fix typo and restore Pointer Masking functionality for RISC-V
2022-07-17 10:15 ` [PATCH 1/1] target/riscv: Fix typo and restore Pointer Masking " Alexey Baturo
2022-07-19 6:55 ` Alistair Francis
@ 2022-07-19 7:06 ` Alistair Francis
1 sibling, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2022-07-19 7:06 UTC (permalink / raw)
To: Alexey Baturo
Cc: Richard Henderson, space.monkey.delivers, Dave Smith,
Palmer Dabbelt, Alistair Francis, Sagar Karandikar,
Bastian Koppelmann, qemu-devel@nongnu.org Developers,
open list:RISC-V
On Sun, Jul 17, 2022 at 8:17 PM Alexey Baturo <baturo.alexey@gmail.com> wrote:
>
> From: Alexey Baturo <baturo.alexey@gmail.com>
>
> Signed-off-by: Alexey Baturo <baturo.alexey@gmail.com>
Thanks!
Applied to riscv-to-apply.next
Alistair
> ---
> target/riscv/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/translate.c b/target/riscv/translate.c
> index 63b04e8a94..86c19ea74e 100644
> --- a/target/riscv/translate.c
> +++ b/target/riscv/translate.c
> @@ -544,7 +544,7 @@ static TCGv get_address(DisasContext *ctx, int rs1, int imm)
>
> tcg_gen_addi_tl(addr, src1, imm);
> if (ctx->pm_mask_enabled) {
> - tcg_gen_and_tl(addr, addr, pm_mask);
> + tcg_gen_andc_tl(addr, addr, pm_mask);
> } else if (get_xl(ctx) == MXL_RV32) {
> tcg_gen_ext32u_tl(addr, addr);
> }
> --
> 2.30.2
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-19 7:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-17 10:15 [PATCH 0/1] Fix pointer masking functionality for RISC-V Alexey Baturo
2022-07-17 10:15 ` [PATCH 1/1] target/riscv: Fix typo and restore Pointer Masking " Alexey Baturo
2022-07-19 6:55 ` Alistair Francis
2022-07-19 7:06 ` Alistair Francis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).