From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Cindy Lu <lulu@redhat.com>,
Harpreet Singh Anand <hanand@xilinx.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Liuxiangdong <liuxiangdong5@huawei.com>,
Eric Blake <eblake@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Gautam Dawar <gdawar@xilinx.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
Zhu Lingshan <lingshan.zhu@intel.com>,
Parav Pandit <parav@mellanox.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Eli Cohen <eli@mellanox.com>, Jason Wang <jasowang@redhat.com>
Subject: [PATCH v2 3/5] vdpa: Make vhost_vdpa_net_cvq_map_elem accept any out sg
Date: Mon, 18 Jul 2022 18:29:36 +0200 [thread overview]
Message-ID: <20220718162938.2938783-4-eperezma@redhat.com> (raw)
In-Reply-To: <20220718162938.2938783-1-eperezma@redhat.com>
So its generic enough to accept any out sg buffer and we can inject
NIC state messages.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
net/vhost-vdpa.c | 29 +++++++++++++++--------------
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index fa00928854..533bd9f680 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -302,35 +302,36 @@ dma_map_err:
}
/**
- * Copy the guest element into a dedicated buffer suitable to be sent to NIC
+ * Maps out sg and in buffer into dedicated buffers suitable to be sent to NIC
*
- * @iov: [0] is the out buffer, [1] is the in one
+ * @dev_iov: [0] is the out buffer, [1] is the in one
*/
-static bool vhost_vdpa_net_cvq_map_elem(VhostVDPAState *s,
- VirtQueueElement *elem,
- struct iovec *iov)
+static bool vhost_vdpa_net_cvq_map_sg(VhostVDPAState *s,
+ const struct iovec *out, size_t out_num,
+ struct iovec *dev_iov)
{
size_t in_copied;
bool ok;
- iov[0].iov_base = s->cvq_cmd_out_buffer;
- ok = vhost_vdpa_cvq_map_buf(&s->vhost_vdpa, elem->out_sg, elem->out_num,
- vhost_vdpa_net_cvq_cmd_len(), iov[0].iov_base,
- &iov[0].iov_len, false);
+ dev_iov[0].iov_base = s->cvq_cmd_out_buffer;
+ ok = vhost_vdpa_cvq_map_buf(&s->vhost_vdpa, out, out_num,
+ vhost_vdpa_net_cvq_cmd_len(),
+ dev_iov[0].iov_base, &dev_iov[0].iov_len,
+ false);
if (unlikely(!ok)) {
return false;
}
- iov[1].iov_base = s->cvq_cmd_in_buffer;
+ dev_iov[1].iov_base = s->cvq_cmd_in_buffer;
ok = vhost_vdpa_cvq_map_buf(&s->vhost_vdpa, NULL, 0,
- sizeof(virtio_net_ctrl_ack), iov[1].iov_base,
- &in_copied, true);
+ sizeof(virtio_net_ctrl_ack),
+ dev_iov[1].iov_base, &in_copied, true);
if (unlikely(!ok)) {
vhost_vdpa_cvq_unmap_buf(&s->vhost_vdpa, s->cvq_cmd_out_buffer);
return false;
}
- iov[1].iov_len = sizeof(virtio_net_ctrl_ack);
+ dev_iov[1].iov_len = sizeof(virtio_net_ctrl_ack);
return true;
}
@@ -431,7 +432,7 @@ static int vhost_vdpa_net_handle_ctrl_avail(VhostShadowVirtqueue *svq,
};
bool ok;
- ok = vhost_vdpa_net_cvq_map_elem(s, elem, dev_buffers);
+ ok = vhost_vdpa_net_cvq_map_sg(s, elem->out_sg, elem->out_num, dev_buffers);
if (unlikely(!ok)) {
goto out;
}
--
2.31.1
next prev parent reply other threads:[~2022-07-18 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 16:29 [PATCH v2 0/5] NIC vhost-vdpa state restore via Shadow CVQ Eugenio Pérez
2022-07-18 16:29 ` [PATCH v2 1/5] vhost: stop transfer elem ownership in vhost_handle_guest_kick Eugenio Pérez
2022-07-18 16:29 ` [PATCH v2 2/5] vdpa: Extract vhost_vdpa_net_cvq_add from vhost_vdpa_net_handle_ctrl_avail Eugenio Pérez
2022-07-18 16:29 ` Eugenio Pérez [this message]
2022-07-18 16:29 ` [PATCH v2 4/5] vdpa: Add virtio-net mac address via CVQ at start Eugenio Pérez
2022-07-22 2:29 ` Jason Wang
2022-07-22 7:02 ` Eugenio Perez Martin
2022-07-18 16:29 ` [PATCH v2 5/5] vdpa: Delete CVQ migration blocker Eugenio Pérez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718162938.2938783-4-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=eblake@redhat.com \
--cc=eli@mellanox.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=liuxiangdong5@huawei.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).